linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: youngjun <her0gyugyu@gmail.com>, rossmeikleham@gmail.com
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: update RANDOMIZE_MODULE_REGION_FULL config description
Date: Mon, 23 Nov 2020 11:12:14 +0000	[thread overview]
Message-ID: <20201123111213.GB9957@willie-the-truck> (raw)
In-Reply-To: <20201122070855.10506-1-her0gyugyu@gmail.com>

On Sat, Nov 21, 2020 at 11:08:55PM -0800, youngjun wrote:
> module randomization is reduced. (range to 2 GB)
> RANDOMIZE_MODULE_REGION_FULL config description is not updated.
> update RANDOMIZE_MODULE_REGION_FULL config description.
> 
> Signed-off-by: youngjun <her0gyugyu@gmail.com>
> ---
>  arch/arm64/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This looks like the same patch as the one I reviewed here:

https://lore.kernel.org/r/20201109112705.GC14356@willie-the-truck

but the commit message isn't a lot better. Please could you (or Ross)
post a version with a fixed commit message?

Thanks,

Will

> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1515f6f153a0..0da551828a59 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1804,11 +1804,11 @@ config RANDOMIZE_BASE
>  	  If unsure, say N.
>  
>  config RANDOMIZE_MODULE_REGION_FULL
> -	bool "Randomize the module region over a 4 GB range"
> +	bool "Randomize the module region over a 2 GB range"
>  	depends on RANDOMIZE_BASE
>  	default y
>  	help
> -	  Randomizes the location of the module region inside a 4 GB window
> +	  Randomizes the location of the module region inside a 2 GB window
>  	  covering the core kernel. This way, it is less likely for modules
>  	  to leak information about the location of core kernel data structures
>  	  but it does imply that function calls between modules and the core
> -- 
> 2.17.1
> 

      reply	other threads:[~2020-11-23 11:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-22  7:08 [PATCH] arm64: update RANDOMIZE_MODULE_REGION_FULL config description youngjun
2020-11-23 11:12 ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123111213.GB9957@willie-the-truck \
    --to=will@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=her0gyugyu@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rossmeikleham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).