linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org,
	Will Deacon <will@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Edgar Merger <Edgar.Merger@emerson.com>,
	Joerg Roedel <jroedel@suse.de>
Subject: [PATCH] PCI: Mark AMD Raven iGPU ATS as broken
Date: Mon, 23 Nov 2020 13:44:10 +0000	[thread overview]
Message-ID: <20201123134410.10648-1-will@kernel.org> (raw)

Edgar Merger reports that the AMD Raven GPU does not work reliably on
his system when the IOMMU is enabled:

  | [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout, signaled seq=1, emitted seq=3
  | [...]
  | amdgpu 0000:0b:00.0: GPU reset begin!
  | AMD-Vi: Completion-Wait loop timed out
  | iommu ivhd0: AMD-Vi: Event logged [IOTLB_INV_TIMEOUT device=0b:00.0 address=0x38edc0970]

This is indicative of a hardware/platform configuration issue so, since
disabling ATS has been shown to resolve the problem, add a quirk to
match this particular device while Edgar follows-up with AMD for more
information.

Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Reported-by: Edgar Merger <Edgar.Merger@emerson.com>
Suggested-by: Joerg Roedel <jroedel@suse.de>
Link: https://lore.kernel.org/linux-iommu/MWHPR10MB1310F042A30661D4158520B589FC0@MWHPR10MB1310.namprd10.prod.outlook.com
Signed-off-by: Will Deacon <will@kernel.org>
---

Hi all,

Since Joerg is away at the moment, I'm posting this to try to make some
progress with the thread in the Link: tag.

Cheers,

Will

 drivers/pci/quirks.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index f70692ac79c5..3911b0ec57ba 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -5176,6 +5176,8 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x6900, quirk_amd_harvest_no_ats);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7312, quirk_amd_harvest_no_ats);
 /* AMD Navi14 dGPU */
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7340, quirk_amd_harvest_no_ats);
+/* AMD Raven platform iGPU */
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x15d8, quirk_amd_harvest_no_ats);
 #endif /* CONFIG_PCI_ATS */
 
 /* Freescale PCIe doesn't support MSI in RC mode */
-- 
2.29.2.454.gaff20da3a2-goog


             reply	other threads:[~2020-11-23 13:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 13:44 Will Deacon [this message]
2020-11-23 21:04 ` [PATCH] PCI: Mark AMD Raven iGPU ATS as broken Deucher, Alexander
2020-11-23 22:33   ` Will Deacon
2020-11-23 22:51     ` Felix Kuehling
2020-11-24  6:43       ` Huang Rui
2020-11-24  7:28         ` [EXTERNAL] " Merger, Edgar [AUTOSOL/MAS/AUGS]
2020-11-24 15:05           ` Deucher, Alexander
2020-11-25  6:05             ` Merger, Edgar [AUTOSOL/MAS/AUGS]
2020-11-25  9:16               ` Merger, Edgar [AUTOSOL/MAS/AUGS]
2020-11-25 10:03                 ` Merger, Edgar [AUTOSOL/MAS/AUGS]
2020-11-25 16:07                   ` Deucher, Alexander
2020-11-26  9:24                     ` Merger, Edgar [AUTOSOL/MAS/AUGS]
2020-11-30 18:36                       ` Deucher, Alexander
2020-12-07  4:53                         ` Merger, Edgar [AUTOSOL/MAS/AUGS]
2020-12-08  8:23                           ` Merger, Edgar [AUTOSOL/MAS/AUGS]
2020-12-09  7:59                             ` Merger, Edgar [AUTOSOL/MAS/AUGS]
2020-12-09 14:23                               ` Deucher, Alexander
2020-12-10 10:48                                 ` Merger, Edgar [AUTOSOL/MAS/AUGS]
2020-12-10 15:36                                   ` Deucher, Alexander
2020-12-10 16:25                                     ` Bjorn Helgaas
2020-11-24  5:32     ` Merger, Edgar [AUTOSOL/MAS/AUGS]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123134410.10648-1-will@kernel.org \
    --to=will@kernel.org \
    --cc=Edgar.Merger@emerson.com \
    --cc=alexander.deucher@amd.com \
    --cc=bhelgaas@google.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).