From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Limonciello, Mario" <Mario.Limonciello@dell.com>,
Greg KH <gregkh@linuxfoundation.org>,
Bastien Nocera <hadess@hadess.net>,
Linux PM <linux-pm@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: How to enable auto-suspend by default
Date: Mon, 23 Nov 2020 16:01:51 +0200 [thread overview]
Message-ID: <20201123140151.GH2495@lahna.fi.intel.com> (raw)
In-Reply-To: <30aa8c96-1809-8c5f-2305-5e39fbeba434@redhat.com>
On Mon, Nov 23, 2020 at 02:54:19PM +0100, Hans de Goede wrote:
> Hi,
>
> On 11/11/20 3:31 PM, Mika Westerberg wrote:
> > On Wed, Nov 11, 2020 at 12:27:32PM +0100, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 11/10/20 6:25 PM, Mika Westerberg wrote:
> >>> On Tue, Nov 10, 2020 at 04:02:33PM +0000, Limonciello, Mario wrote:
> >>>>>
> >>>>> On Tue, Nov 10, 2020 at 11:57:07AM +0100, Bastien Nocera wrote:
> >>>>>> Hey,
> >>>>>>
> >>>>>> systemd has been shipping this script to enable auto-suspend on a
> >>>>>> number of USB and PCI devices:
> >>>>>>
> >>>>> https://github.com/systemd/systemd/blob/master/tools/chromiumos/gen_autosuspen
> >>>>> d_rules.py
> >>>>>>
> >>>>>> The problem here is twofold. First, the list of devices is updated from
> >>>>>> ChromeOS, and the original list obviously won't be updated by ChromeOS
> >>>>>> developers unless a device listed exists in a ChromeBook computer,
> >>>>>> which means a number of devices that do support autosuspend aren't
> >>>>>> listed.
> >>>>>>
> >>>>>> The other problem is that this list needs to exist at all, and that it
> >>>>>> doesn't seem possible for device driver developers (at various levels
> >>>>>> of the stack) to opt-in to auto-suspend when all the variants of the
> >>>>>> device (or at least detectable ones) support auto-suspend.
> >>>>>
> >>>>> A driver can say they support autosuspend today, but I think you are
> >>>>> concerned about the devices that are controlled by class-compliant
> >>>>> drivers, right? And for those, no, we can't do this in the kernel as
> >>>>> there are just too many broken devices out there.
> >>>>>
> >>>>
> >>>> I guess what Bastien is getting at is for newer devices supported by class
> >>>> drivers rather than having to store an allowlist in udev rules, can we set
> >>>> the allowlist in the kernel instead. Then distributions that either don't
> >>>> use systemd or don't regularly update udev rules from systemd can take
> >>>> advantage of better defaults on modern hardware.
> >>>>
> >>>> The one item that stood out to me in that rules file was 8086:a0ed.
> >>>> It's listed as "Volteer XHCI", but that same device ID is actually present
> >>>> in an XPS 9310 in front of me as well and used by the xhci-pci kernel module.
> >>>>
> >>>> Given we're effectively ending up with the combination of runtime PM turned
> >>>> on by udev rules, do we need something like this for that ID:
> >>>>
> >>>> https://github.com/torvalds/linux/commit/6a7c533d4a1854f54901a065d8c672e890400d8a
> >>>>
> >>>> @Mika Westerberg should 8086:a0ed be quirked like the TCSS xHCI too?
> >>>
> >>> I think this one is the TGL PCH xHCI. The quirk currently for xHCI
> >>> controllers that are part of the TCSS (Type-C SubSystem) where it is
> >>> important to put all devices into low power mode whenever possible,
> >>> otherwise it keeps the whole block on.
> >>
> >> Note that there are currently some IDs missing from the xHCIs which
> >> are part of the TCSS too. At least the id for the xHCI in the thunderbolt
> >> controller on the Lenovo T14 gen 1 is missing. I started a discussion
> >> about extending the kernel quirk list for this vs switching to hwdb
> >> a while a go:
> >>
> >> https://lore.kernel.org/linux-usb/b8b21ba3-0a8a-ff54-5e12-cf8960651086@redhat.com/
> >>
> >> The conclusion back then was to switch to hwdb, but I never got around to this.
> >
> > The reason I've added these to the xHCI driver is that it works even if
> > you are running some really small userspace (like busybox). Also for the
> > xHCI in TCSS we know for sure that it fully supports D3cold.
> >
> > (The one you refer above is actually mistake from my side as I never
> > tested Alpine Ridge LP controller which I think this is).
>
> Ok, so I'll submit a patch adding the 15c1 product-id for the
> INTEL_ALPINE_RIDGE_LP_2C_XHCI controller to the list of ids for which we
> set the XHCI_DEFAULT_PM_RUNTIME_ALLOW quirk. To fix the much too high
> idle-power consumption problem on devices with this Alpine Ridge variant.
Thanks!
next prev parent reply other threads:[~2020-11-23 14:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 10:57 How to enable auto-suspend by default Bastien Nocera
2020-11-10 11:34 ` Greg KH
2020-11-10 16:02 ` Limonciello, Mario
2020-11-10 17:18 ` Greg KH
2020-11-10 17:45 ` Limonciello, Mario
2020-11-10 18:00 ` Greg KH
2020-11-10 18:08 ` Limonciello, Mario
2020-11-10 19:55 ` Theodore Y. Ts'o
2020-11-10 20:45 ` Limonciello, Mario
2020-11-10 17:25 ` Mika Westerberg
2020-11-11 11:27 ` Hans de Goede
2020-11-11 14:31 ` Mika Westerberg
2020-11-23 13:54 ` Hans de Goede
2020-11-23 14:01 ` Mika Westerberg [this message]
2020-11-24 12:37 ` Mathias Nyman
2020-11-24 12:38 ` Hans de Goede
2020-11-24 15:53 ` Bastien Nocera
2020-11-11 16:03 ` Limonciello, Mario
2020-11-11 16:32 ` Greg KH
2020-11-24 16:02 ` Bastien Nocera
2020-11-24 16:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123140151.GH2495@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).