From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63CCC63697 for ; Mon, 23 Nov 2020 17:03:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92AFE2083E for ; Mon, 23 Nov 2020 17:03:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Kl2olBC/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390214AbgKWRDf (ORCPT ); Mon, 23 Nov 2020 12:03:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41061 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729815AbgKWRDe (ORCPT ); Mon, 23 Nov 2020 12:03:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606151013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KQjlYGpM0Jo472SEJajFJgHSfKbcvhfoBX2kIE5oOZw=; b=Kl2olBC/nZy6j67FGXVFOzru/6A9ULxpAjfjn1abRsudJHIlY4DB1eCWWE+ae7k0KCCb3Q XY/ejexk5JT/BXz0tIJQ7L+pgfke2BThtx7IJ122+bus0xg65cqMUx+mPmanaTAfz4tFQo iBhkn1b3PzfUXxQJ60VH6Xn3o1D5tP8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-WuQ-qpwTOPqDoVFfXdXKkw-1; Mon, 23 Nov 2020 12:03:31 -0500 X-MC-Unique: WuQ-qpwTOPqDoVFfXdXKkw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3055805BF6; Mon, 23 Nov 2020 17:03:28 +0000 (UTC) Received: from gondolin (ovpn-113-104.ams2.redhat.com [10.36.113.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3909A5C1C4; Mon, 23 Nov 2020 17:03:19 +0000 (UTC) Date: Mon, 23 Nov 2020 18:03:16 +0100 From: Cornelia Huck To: Halil Pasic Cc: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@linux.ibm.com, borntraeger@de.ibm.com, mjrosato@linux.ibm.com, alex.williamson@redhat.com, kwankhede@nvidia.com, fiuczy@linux.ibm.com, frankja@linux.ibm.com, david@redhat.com, hca@linux.ibm.com, gor@linux.ibm.com Subject: Re: [PATCH v11 05/14] s390/vfio-ap: implement in-use callback for vfio_ap driver Message-ID: <20201123180316.79273751.cohuck@redhat.com> In-Reply-To: <20201114004722.76c999e0.pasic@linux.ibm.com> References: <20201022171209.19494-1-akrowiak@linux.ibm.com> <20201022171209.19494-6-akrowiak@linux.ibm.com> <20201027142711.1b57825e.pasic@linux.ibm.com> <6a5feb16-46b5-9dca-7e85-7d344b0ffa24@linux.ibm.com> <20201114004722.76c999e0.pasic@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 Nov 2020 00:47:22 +0100 Halil Pasic wrote: > On Fri, 13 Nov 2020 12:14:22 -0500 > Tony Krowiak wrote: > [..] > > >> } > > >> > > >> +#define MDEV_SHARING_ERR "Userspace may not re-assign queue %02lx.%04lx " \ > > >> + "already assigned to %s" > > >> + > > >> +static void vfio_ap_mdev_log_sharing_err(const char *mdev_name, > > >> + unsigned long *apm, > > >> + unsigned long *aqm) > > >> +{ > > >> + unsigned long apid, apqi; > > >> + > > >> + for_each_set_bit_inv(apid, apm, AP_DEVICES) > > >> + for_each_set_bit_inv(apqi, aqm, AP_DOMAINS) > > >> + pr_err(MDEV_SHARING_ERR, apid, apqi, mdev_name); > > > Isn't error rather severe for this? For my taste even warning would be > > > severe for this. > > > > The user only sees a EADDRINUSE returned from the sysfs interface, > > so Conny asked if I could log a message to indicate which APQNs are > > in use by which mdev. I can change this to an info message, but it > > will be missed if the log level is set higher. Maybe Conny can put in > > her two cents here since she asked for this. > > > > I'm looking forward to Conny's opinion. :) (only just saw this; -ETOOMANYEMAILS) It is probably not an error in the sense of "things are broken, this cannot work"; but I'd consider this at least a warning "this does not work as you intended".