From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B19C64E75 for ; Tue, 24 Nov 2020 05:06:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16F222086A for ; Tue, 24 Nov 2020 05:06:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="Zc2KdqBN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgKXFGW (ORCPT ); Tue, 24 Nov 2020 00:06:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgKXFGV (ORCPT ); Tue, 24 Nov 2020 00:06:21 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 849F4C0613D6 for ; Mon, 23 Nov 2020 21:06:21 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id t21so16402938pgl.3 for ; Mon, 23 Nov 2020 21:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=t84FGtb1zqwFP9+gcpDWOJ23J5kLn0xfIZescE5RdAg=; b=Zc2KdqBNxYB8xjxn5tTvXx63XU9sSiwOQ5bx1m4TeNVcPVAfLror94nHTOVzZ+ZNu3 fQu23QQrFlQfzrwzZTPHHkKsCpc/9FMMJzOh2KNyLB8uhpH1ems/YpRfkjPMh74OhPbw 242dDi5kxAmJzWCccUwJeYs1NnEPKMyNu7RSKWzTST2C3GE0dNAwKcZow3y0U6KHzjbH hUvNKLBcGloaDU9uGqwLoN4kI9oOFnNXrc/WH9mjhLed1OTx/SYChE6zYCsQuOr9aZ+g blj08t+eSZdSmPRzKvciu4rboNxc0HqFOjt8nXjU0MOMZVWU5dJXU+HkEtzmhesKxOhk pu8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=t84FGtb1zqwFP9+gcpDWOJ23J5kLn0xfIZescE5RdAg=; b=tUfBYnCjXWyG3w2Wnr1I7h1HFJpqTWFnQsgbTmCHjVQ6+eF+rZxfZb7lzqf5YJrRl0 Y2yhRvRTiZKE/9aUfPKj6GtSQSULW8kFd2B0zWqWjo5SqEXL1O5eUuW8x8hoHVct+SCu XGXrOQmUHw1X+RfgublUuxnxoD6PeAQz4LSm+/vqx8zMmpFyLdRWEKIC7YN2TURysKQT knADUywxg3zA6pFV+Li3ayvUSdQOwXEcAxswAG93rxu2f4PGsbeSXDX5qHoM4pfZb4oo zkKL/jpsgqKCAWleGmrfQ4SyyzLcSSiTfTId0HHRRRWCAyBbPRTNiaAYiwZ9hCISd40j Puxg== X-Gm-Message-State: AOAM531OGvL8L/76ZdxA+8JDiNHAUyXmJLohBFMFHPBU+624SLE3Zzie U0yERi0VHzXHy917Xk5vLGgSyg== X-Google-Smtp-Source: ABdhPJz98eS0KOZDEN5ciizxnoNQfjEfuxC2oQL9mIxpr6zyBPi29Dl3a0yZPU/R7DM88WKv9VYqtw== X-Received: by 2002:a63:ff18:: with SMTP id k24mr2296838pgi.273.1606194381086; Mon, 23 Nov 2020 21:06:21 -0800 (PST) Received: from x1 ([2601:1c0:4701:ae70:1bab:7221:4aae:c48d]) by smtp.gmail.com with ESMTPSA id e17sm12707727pfm.155.2020.11.23.21.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 21:06:20 -0800 (PST) Date: Mon, 23 Nov 2020 21:06:18 -0800 From: Drew Fustini To: Pawan Gupta Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: core: Fix unused variable build warnings Message-ID: <20201124050618.GA337876@x1> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 23, 2020 at 02:33:33PM -0800, Pawan Gupta wrote: > A recent commit f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs > file") added build warnings when CONFIG_GPIOLIB=n. Offcourse the kernel > fails to build when warnings are treated as errors. Below is the error > message: > > $ make CFLAGS_KERNEL+=-Werror > > drivers/pinctrl/core.c: In function ‘pinctrl_pins_show’: > drivers/pinctrl/core.c:1607:20: error: unused variable ‘chip’ [-Werror=unused-variable] > 1607 | struct gpio_chip *chip; > | ^~~~ > drivers/pinctrl/core.c:1606:15: error: unused variable ‘gpio_num’ [-Werror=unused-variable] > 1606 | unsigned int gpio_num; > | ^~~~~~~~ > drivers/pinctrl/core.c:1605:29: error: unused variable ‘range’ [-Werror=unused-variable] > 1605 | struct pinctrl_gpio_range *range; > | ^~~~~ > cc1: all warnings being treated as errors > > These variables are only used inside #ifdef CONFIG_GPIOLIB, fix the > build warnings by wrapping the definition inside the config. > > Fixes: f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs file") > Signed-off-by: Pawan Gupta > --- > drivers/pinctrl/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c > index 3663d87f51a0..1bb371a5cf8d 100644 > --- a/drivers/pinctrl/core.c > +++ b/drivers/pinctrl/core.c > @@ -1602,10 +1602,11 @@ static int pinctrl_pins_show(struct seq_file *s, void *what) > struct pinctrl_dev *pctldev = s->private; > const struct pinctrl_ops *ops = pctldev->desc->pctlops; > unsigned i, pin; > +#ifdef CONFIG_GPIOLIB > struct pinctrl_gpio_range *range; > unsigned int gpio_num; > struct gpio_chip *chip; > - > +#endif > seq_printf(s, "registered pins: %d\n", pctldev->desc->npins); > > mutex_lock(&pctldev->mutex); > -- > 2.21.3 > Thanks for pointing this out. I don't have any systems where I build without CONFIG_GPIOLIB so I missed this. I'm having trouble figuring out a .config that will reproduce this. I tried tinyconfig but it compiled clean. Could you share your .config? Thank you, Drew