From: Peter Zijlstra <peterz@infradead.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Yunsheng Lin <linyunsheng@huawei.com>,
mingo@redhat.com, will@kernel.org, viro@zeniv.linux.org.uk,
kyk.segfault@gmail.com, davem@davemloft.net,
linmiaohe@huawei.com, martin.varghese@nokia.com,
pabeni@redhat.com, pshelar@ovn.org, fw@strlen.de,
gnault@redhat.com, steffen.klassert@secunet.com,
vladimir.oltean@nxp.com, edumazet@google.com, saeed@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH net-next v2 1/2] lockdep: Introduce in_softirq lockdep assert
Date: Tue, 24 Nov 2020 09:11:12 +0100 [thread overview]
Message-ID: <20201124081112.GF2414@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201123121259.312dcb82@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Nov 23, 2020 at 12:12:59PM -0800, Jakub Kicinski wrote:
> One liner would be:
>
> * Acceptable for protecting per-CPU resources accessed from BH
>
> We can add:
>
> * Much like in_softirq() - semantics are ambiguous, use carefully. *
>
>
> IIUC we basically want to protect the nc array and counter here:
Works for me, thanks!
next prev parent reply other threads:[~2020-11-24 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 3:06 [PATCH net-next v2 0/2] Add an assert in napi_consume_skb() Yunsheng Lin
2020-11-21 3:06 ` [PATCH net-next v2 1/2] lockdep: Introduce in_softirq lockdep assert Yunsheng Lin
2020-11-23 14:27 ` Peter Zijlstra
2020-11-23 20:12 ` Jakub Kicinski
2020-11-24 8:11 ` Peter Zijlstra [this message]
2020-11-24 10:30 ` Yunsheng Lin
2020-11-21 3:06 ` [PATCH net-next v2 2/2] net: Use lockdep_assert_in_softirq() in napi_consume_skb() Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124081112.GF2414@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=gnault@redhat.com \
--cc=kuba@kernel.org \
--cc=kyk.segfault@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=martin.varghese@nokia.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=saeed@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=vladimir.oltean@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).