From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9E8C63798 for ; Wed, 25 Nov 2020 00:34:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C75121527 for ; Wed, 25 Nov 2020 00:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727743AbgKYAd3 (ORCPT ); Tue, 24 Nov 2020 19:33:29 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:48576 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727688AbgKYAd3 (ORCPT ); Tue, 24 Nov 2020 19:33:29 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1khikD-008huN-Sk; Wed, 25 Nov 2020 01:33:13 +0100 Date: Wed, 25 Nov 2020 01:33:13 +0100 From: Andrew Lunn To: Chris Packham Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, linux@armlinux.org.uk, pavana.sharma@digi.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v5 1/4] net: dsa: mv88e6xxx: Don't force link when using in-band-status Message-ID: <20201125003313.GB2075216@lunn.ch> References: <20201124043440.28400-1-chris.packham@alliedtelesis.co.nz> <20201124043440.28400-2-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124043440.28400-2-chris.packham@alliedtelesis.co.nz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 05:34:37PM +1300, Chris Packham wrote: > When a port is configured with 'managed = "in-band-status"' switch chips > like the 88E6390 need to propagate the SERDES link state to the MAC > because the link state is not correctly detected. This causes problems > on the 88E6185/88E6097 where the link partner won't see link state > changes because we're forcing the link. > > To address this introduce a new device specific op port_sync_link() and > push the logic from mv88e6xxx_mac_link_up() into that. Provide an > implementation for the 88E6185 like devices which doesn't force the > link. > > Signed-off-by: Chris Packham Reviewed-by: Andrew Lunn Andrew