From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Yonglong Liu <liuyonglong@huawei.com>
Cc: Antonio Borneo <antonio.borneo@st.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Willy Liu <willy.liu@realtek.com>,
linux-kernel@vger.kernel.org,
Salil Mehta <salil.mehta@huawei.com>,
linuxarm@huawei.com, linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift
Date: Wed, 25 Nov 2020 17:07:14 +0000 [thread overview]
Message-ID: <20201125170714.GK1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <f24476cc-39f0-ea5f-d6af-faad481e3235@huawei.com>
On Thu, Nov 26, 2020 at 12:57:37AM +0800, Yonglong Liu wrote:
> Hi, Antonio:
>
> Could you help to provide a downshift warning message when this happen?
>
> It's a little strange that the adv and the lpa support 1000M, but
> finally the link speed is 100M.
That is an identifying feature of downshift.
Downshift can happen at either end of the link, and since we must not
change the "Advertised link modes" since this is what userspace
configured, if a downshift occurs at the local end, then you will get
the ethtool output you provide, where the speed does not agree with
the reported advertisements.
You should already be getting a warning in the kernel log when this
happens; phy_check_downshift() which is part of the phylib core code
will check this every time the link comes up. You should already
have a message "Downshift occurred ..." in your kernel log. Please
check.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-11-25 17:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 14:38 [PATCH] net: phy: fix auto-negotiation in case of 'down-shift' Antonio Borneo
2020-11-24 14:56 ` Russell King - ARM Linux admin
2020-11-24 15:17 ` Antonio Borneo
2020-11-24 15:26 ` Heiner Kallweit
2020-11-24 15:37 ` Russell King - ARM Linux admin
2020-11-24 17:00 ` Antonio Borneo
2020-11-24 15:03 ` Heiner Kallweit
2020-11-24 15:17 ` Russell King - ARM Linux admin
2020-11-24 15:31 ` Antonio Borneo
2020-11-24 15:46 ` David Laight
2020-11-24 21:59 ` [PATCH v2] net: phy: realtek: read actual speed on rtl8211f to detect downshift Antonio Borneo
2020-11-24 22:22 ` Heiner Kallweit
2020-11-24 22:33 ` Antonio Borneo
2020-11-24 22:41 ` Heiner Kallweit
2020-11-24 23:07 ` [PATCH v3 net-next] " Antonio Borneo
2020-11-25 15:03 ` Yonglong Liu
2020-11-25 16:57 ` Yonglong Liu
2020-11-25 17:07 ` Russell King - ARM Linux admin [this message]
2020-11-26 1:15 ` Yonglong Liu
2020-11-25 20:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125170714.GK1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=antonio.borneo@st.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linuxarm@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=willy.liu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).