From: Mike Travis <mike.travis@hpe.com>
To: Hans de Goede <hdegoede@redhat.com>,
Justin Ernst <justin.ernst@hpe.com>,
Mark Gross <mgross@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, Steve Wahl <steve.wahl@hpe.com>
Cc: Mike Travis <mike.travis@hpe.com>,
Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Russ Anderson <russ.anderson@hpe.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Ilya Dryomov <idryomov@gmail.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: [PATCH 4/5] x86/platform/uv: Add deprecated messages to /proc info leaves
Date: Wed, 25 Nov 2020 11:29:06 -0600 [thread overview]
Message-ID: <20201125172907.240996-5-mike.travis@hpe.com> (raw)
In-Reply-To: <20201125172907.240996-1-mike.travis@hpe.com>
Add "deprecated" message to any access to old /proc/sgi_uv/* leaves.
Signed-off-by: Mike Travis <mike.travis@hpe.com>
Reviewed-by: Steve Wahl <steve.wahl@hpe.com>
---
arch/x86/kernel/apic/x2apic_uv_x.c | 26 +++++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic/x2apic_uv_x.c
index 48746031b39a..bfd77a00c2a1 100644
--- a/arch/x86/kernel/apic/x2apic_uv_x.c
+++ b/arch/x86/kernel/apic/x2apic_uv_x.c
@@ -1615,21 +1615,45 @@ static void check_efi_reboot(void)
reboot_type = BOOT_ACPI;
}
-/* Setup user proc fs files */
+/*
+ * User proc fs file handling now deprecated.
+ * Recommend using /sys/firmware/sgi_uv/... instead.
+ */
+static void proc_print_msg(int *flag, char *what, char *which)
+{
+ if (*flag)
+ return;
+
+ pr_notice(
+ "%s: using deprecated /proc/sgi_uv/%s, use /sys/firmware/sgi_uv/%s\n",
+ current->comm, what, which ? which : what);
+
+ *flag = 1;
+}
+
static int __maybe_unused proc_hubbed_show(struct seq_file *file, void *data)
{
+ static int flag;
+
+ proc_print_msg(&flag, "hubbed", "hub_type");
seq_printf(file, "0x%x\n", uv_hubbed_system);
return 0;
}
static int __maybe_unused proc_hubless_show(struct seq_file *file, void *data)
{
+ static int flag;
+
+ proc_print_msg(&flag, "hubless", NULL);
seq_printf(file, "0x%x\n", uv_hubless_system);
return 0;
}
static int __maybe_unused proc_archtype_show(struct seq_file *file, void *data)
{
+ static int flag;
+
+ proc_print_msg(&flag, "archtype", NULL);
seq_printf(file, "%s/%s\n", uv_archtype, oem_table_id);
return 0;
}
--
2.21.0
next prev parent reply other threads:[~2020-11-25 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 17:29 [PATCH 0/5] x86/platform/uv: Move UV procfs leaves to sysfs Mike Travis
2020-11-25 17:29 ` [PATCH 1/5] x86/platform/uv: Add kernel interfaces for obtaining system info Mike Travis
2020-11-25 17:29 ` [PATCH 2/5] x86/platform/uv: Add sysfs leaves to replace those in procfs Mike Travis
2020-11-25 17:29 ` [PATCH 3/5] x86/platform/uv: Add sysfs hubless leaves Mike Travis
2020-11-25 17:29 ` Mike Travis [this message]
2020-11-26 10:45 ` [PATCH 4/5] x86/platform/uv: Add deprecated messages to /proc info leaves Hans de Goede
2020-11-27 14:58 ` Mike Travis
2020-11-27 18:06 ` Hans de Goede
2020-11-25 17:29 ` [PATCH 5/5] x86/platform/uv: Update sysfs document file Mike Travis
2020-11-26 10:44 ` [PATCH 0/5] x86/platform/uv: Move UV procfs leaves to sysfs Hans de Goede
2020-11-27 14:41 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125172907.240996-5-mike.travis@hpe.com \
--to=mike.travis@hpe.com \
--cc=bp@alien8.de \
--cc=dimitri.sivanich@hpe.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=idryomov@gmail.com \
--cc=justin.ernst@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mgross@linux.intel.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=russ.anderson@hpe.com \
--cc=steve.wahl@hpe.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).