From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F840C56202 for ; Wed, 25 Nov 2020 19:48:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFAC220B1F for ; Wed, 25 Nov 2020 19:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729102AbgKYTsa (ORCPT ); Wed, 25 Nov 2020 14:48:30 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:38154 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729007AbgKYTs3 (ORCPT ); Wed, 25 Nov 2020 14:48:29 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 0FA611C0B81; Wed, 25 Nov 2020 20:48:26 +0100 (CET) Date: Wed, 25 Nov 2020 20:48:25 +0100 From: Pavel Machek To: Qinglang Miao Cc: Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case Message-ID: <20201125194825.GC9791@amd> References: <20201119070841.712-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eHhjakXzOLJAF9wJ" Content-Disposition: inline In-Reply-To: <20201119070841.712-1-miaoqinglang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eHhjakXzOLJAF9wJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Fix to set ret and goto child_out for fwnode_handle_put(child) > in the error handling case rather than simply return, as done > elsewhere in this function. >=20 > Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED = driver") > Reported-by: Hulk Robot > Suggested-by: Pavel Machek > Signed-off-by: Qinglang Miao Thanks, applied. Best regards, Pavel =09 --=20 http://www.livejournal.com/~pavelmachek --eHhjakXzOLJAF9wJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl++tQkACgkQMOfwapXb+vJG0wCaAlLJdIuFosHFwt3YMwltlylb wFcAoLER+4Rr7BWnyCik1CE2QBeu/YA+ =/Cv4 -----END PGP SIGNATURE----- --eHhjakXzOLJAF9wJ--