linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Andi Kleen <ak@linux.intel.com>, Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>
Subject: [PATCH 0/3] clear_warn_once: add timed interval resetting
Date: Thu, 26 Nov 2020 01:30:26 -0500	[thread overview]
Message-ID: <20201126063029.2030-1-paul.gortmaker@windriver.com> (raw)

The existing clear_warn_once functionality is currently a manually
issued state reset via the file /sys/kernel/debug/clear_warn_once when
debugfs is mounted.  The idea being that a developer would be running
some tests, like LTP or similar, and want to check reproducibility
without having to reboot.

But you currently can't make use of clear_warn_once unless you've got
debugfs enabled and mounted - which may not be desired by some people
in some deployment situations.

The functionality added here allows for periodic resets in addition to
the one-shot reset it already had.  Then we allow for a boot-time setting
of the periodic resets so it can be used even when debugfs isn't mounted.

By having a periodic reset, we also open the door for having the various
"once" functions act as long period ratelimited messages, where a sysadmin
can pick an hour or a day reset if they are facing an issue and are
wondering "did this just happen once, or am I only being informed once?"

Tested with DEBUG_FS_ALLOW_ALL and DEBUG_FS_ALLOW_NONE on an otherwise
defconfig.

---

Cc: Andi Kleen <ak@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: John Ogness <john.ogness@linutronix.de>

Paul Gortmaker (3):
  clear_warn_once: expand debugfs to include read support
  clear_warn_once: bind a timer to written reset value
  clear_warn_once: add a warn_once_reset= boot parameter

 .../admin-guide/clearing-warn-once.rst        |  9 +++
 .../admin-guide/kernel-parameters.txt         |  8 ++
 kernel/panic.c                                | 78 +++++++++++++++++--
 3 files changed, 90 insertions(+), 5 deletions(-)

-- 
2.25.1


             reply	other threads:[~2020-11-26  6:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26  6:30 Paul Gortmaker [this message]
2020-11-26  6:30 ` [PATCH 1/3] clear_warn_once: expand debugfs to include read support Paul Gortmaker
2020-11-26  6:30 ` [PATCH 2/3] clear_warn_once: bind a timer to written reset value Paul Gortmaker
2020-11-30 16:20   ` Steven Rostedt
2020-11-30 17:17     ` Paul Gortmaker
2020-12-01  3:36       ` Steven Rostedt
2020-11-26  6:30 ` [PATCH 3/3] clear_warn_once: add a warn_once_reset= boot parameter Paul Gortmaker
2020-11-27 16:13 ` [PATCH 0/3] clear_warn_once: add timed interval resetting Petr Mladek
2020-11-27 17:43   ` Paul Gortmaker
2020-12-01 12:59     ` Petr Mladek
2020-11-30  6:02   ` Sergey Senozhatsky
2020-11-30 16:24   ` Steven Rostedt
2020-11-30  3:08 ` Andi Kleen
2020-11-30 17:38   ` Paul Gortmaker
2020-12-01 12:49     ` Petr Mladek
2020-12-01 18:05       ` Paul Gortmaker
2020-12-09 16:37 ` Petr Mladek
2020-12-09 17:21   ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201126063029.2030-1-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=ak@linux.intel.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).