From: SeongJae Park <sjpark@amazon.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: SeongJae Park <sjpark@amazon.com>,
SeongJae Park <sjpark@amazon.de>, <Jonathan.Cameron@huawei.com>,
Andrea Arcangeli <aarcange@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <amit@kernel.org>,
<benh@kernel.crashing.org>, <brendan.d.gregg@gmail.com>,
Brendan Higgins <brendanhiggins@google.com>,
Qian Cai <cai@lca.pw>, Colin Ian King <colin.king@canonical.com>,
Jonathan Corbet <corbet@lwn.net>,
"David Hildenbrand" <david@redhat.com>, <dwmw@amazon.com>,
Marco Elver <elver@google.com>, "Du, Fan" <fan.du@intel.com>,
<foersleo@amazon.de>, "Greg Thelen" <gthelen@google.com>,
Ian Rogers <irogers@google.com>, <jolsa@redhat.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Mark Rutland <mark.rutland@arm.com>, Mel Gorman <mgorman@suse.de>,
Minchan Kim <minchan@kernel.org>, Ingo Molnar <mingo@redhat.com>,
<namhyung@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>,
Rik van Riel <riel@surriel.com>,
David Rientjes <rientjes@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mike Rapoport <rppt@kernel.org>, <sblbir@amazon.com>,
Shuah Khan <shuah@kernel.org>, <sj38.park@gmail.com>,
<snu@amazon.de>, Vlastimil Babka <vbabka@suse.cz>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Huang Ying <ying.huang@intel.com>, <zgf574564920@gmail.com>,
<linux-damon@amazon.com>, Linux MM <linux-mm@kvack.org>,
<linux-doc@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v22 04/18] mm/damon: Track dynamic monitoring target regions update
Date: Thu, 26 Nov 2020 13:18:58 +0100 [thread overview]
Message-ID: <20201126121858.19832-1-sjpark@amazon.com> (raw)
In-Reply-To: <CALvZod6iLkNyePTMn9=DOgbD5Q7Yqc_WrQrNqOQ3e-2+FtJZsg@mail.gmail.com>
On Wed, 25 Nov 2020 07:29:57 -0800 Shakeel Butt <shakeelb@google.com> wrote:
> On Tue, Oct 20, 2020 at 2:02 AM SeongJae Park <sjpark@amazon.com> wrote:
> >
> > From: SeongJae Park <sjpark@amazon.de>
> >
> > The monitoring target address range can be dynamically changed. For
> > example, virtual memory could be dynamically mapped and unmapped.
> > Physical memory could be hot-plugged.
> >
> > As the changes could be quite frequent in some cases,
>
> Which cases? Usually address space changes are very infrequent for
> performance reasons.
It depends on the application, but there are some cases for the mmap[1].
ebizzy, the popular benchmarks in mm community is also one such application.
[1] Section 4.3, https://dl.acm.org/doi/pdf/10.1145/3342195.3387527
>
> > DAMON checks the
> > dynamic memory mapping changes and applies it to the abstracted target
> > area only for each of a user-specified time interval, ``regions update
> > interval``.
> >
> > Signed-off-by: SeongJae Park <sjpark@amazon.de>
> > Reviewed-by: Leonard Foerster <foersleo@amazon.de>
> [snip]
> > * Check whether current monitoring should be stopped
> > *
> > @@ -612,6 +625,11 @@ static int kdamond_fn(void *data)
> > kdamond_reset_aggregated(ctx);
> > kdamond_split_regions(ctx);
> > }
> > +
> > + if (kdamond_need_update_regions(ctx)) {
> > + kdamond_call_prmt(ctx, update_target_regions);
>
> The implementation of update_target_regions callback should be part of
> this patch.
Agreed, will make so in the next version.
Thanks,
SeongJae Park
>
>
> > + sz_limit = damon_region_sz_limit(ctx);
> > + }
> > }
> > damon_for_each_target(t, ctx) {
> > damon_for_each_region_safe(r, next, t)
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2020-11-26 12:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 8:59 [PATCH v22 00/18] Introduce Data Access MONitor (DAMON) SeongJae Park
2020-10-20 8:59 ` [PATCH v22 01/18] mm: " SeongJae Park
2020-11-25 15:29 ` Shakeel Butt
2020-11-26 11:51 ` SeongJae Park
2020-12-08 7:41 ` SeongJae Park
2020-10-20 8:59 ` [PATCH v22 02/18] mm/damon: Implement region based sampling SeongJae Park
2020-11-25 15:29 ` Shakeel Butt
2020-11-26 12:09 ` SeongJae Park
2020-10-20 8:59 ` [PATCH v22 03/18] mm/damon: Adaptively adjust regions SeongJae Park
2020-11-25 15:29 ` Shakeel Butt
2020-11-26 12:12 ` SeongJae Park
2020-10-20 8:59 ` [PATCH v22 04/18] mm/damon: Track dynamic monitoring target regions update SeongJae Park
2020-11-25 15:29 ` Shakeel Butt
2020-11-26 12:18 ` SeongJae Park [this message]
2020-10-20 8:59 ` [PATCH v22 05/18] mm/idle_page_tracking: Make PG_(idle|young) reusable SeongJae Park
2020-11-25 15:30 ` Shakeel Butt
2020-11-26 12:31 ` SeongJae Park
2020-10-20 8:59 ` [PATCH v22 06/18] mm/damon: Implement primitives for the virtual memory address spaces SeongJae Park
2020-11-25 15:30 ` Shakeel Butt
2020-11-26 13:34 ` SeongJae Park
2020-10-20 8:59 ` [PATCH v22 07/18] mm/page_idle: Avoid interferences from concurrent users SeongJae Park
2020-11-25 15:30 ` Shakeel Butt
2020-11-26 13:37 ` SeongJae Park
2020-10-20 8:59 ` [PATCH v22 08/18] mm/damon/primitives: Make coexistable with Idle Page Tracking SeongJae Park
2020-10-20 8:59 ` [PATCH v22 09/18] mm/damon: Add a tracepoint SeongJae Park
2020-10-20 8:59 ` [PATCH v22 10/18] mm/damon: Implement a debugfs-based user space interface SeongJae Park
2020-11-25 15:30 ` Shakeel Butt
2020-11-26 13:45 ` SeongJae Park
2020-10-20 8:59 ` [PATCH v22 11/18] mm/damon/dbgfs: Implement recording feature SeongJae Park
2020-10-20 8:59 ` [PATCH v22 12/18] mm/damon/dbgfs: Export kdamond pid to the user space SeongJae Park
2020-10-20 8:59 ` [PATCH v22 13/18] mm/damon/dbgfs: Support multiple contexts SeongJae Park
2020-10-20 8:59 ` [PATCH v22 14/18] tools: Introduce a minimal user-space tool for DAMON SeongJae Park
2020-10-20 8:59 ` [PATCH v22 15/18] Documentation: Add documents " SeongJae Park
2020-10-20 8:59 ` [PATCH v22 16/18] mm/damon: Add kunit tests SeongJae Park
2020-10-20 8:59 ` [PATCH v22 17/18] mm/damon: Add user space selftests SeongJae Park
2020-10-20 8:59 ` [PATCH v22 18/18] MAINTAINERS: Update for DAMON SeongJae Park
2020-11-11 16:41 ` [PATCH v22 00/18] Introduce Data Access MONitor (DAMON) SeongJae Park
2020-11-17 8:05 ` SeongJae Park
2020-11-17 14:30 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126121858.19832-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=aarcange@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendan.d.gregg@gmail.com \
--cc=brendanhiggins@google.com \
--cc=cai@lca.pw \
--cc=colin.king@canonical.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=elver@google.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=gthelen@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=sblbir@amazon.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=snu@amazon.de \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
--cc=zgf574564920@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).