* [PATCH v2 0/4] [Set 2/2] Rid W=1 issues from Input
@ 2020-11-26 13:36 Lee Jones
2020-11-26 13:36 ` [PATCH v2 1/4] input: mouse: synaptics: Replace NOOP with suitable commentary Lee Jones
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Lee Jones @ 2020-11-26 13:36 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Benjamin Tissoires, Bruce Kalk, C. Scott Ananian,
Daniel Ritz, Dmitry Torokhov, Henrik Rydberg, James Hilliard,
linux-input, Peter Osterlund, Sangwon Jee, Stefan Gmeiner
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This is the second (and last) of 2 sets.
v2:
- Replace empty if() with commentary
- Suggested-by: Joe Perches
Lee Jones (4):
input: mouse: synaptics: Replace NOOP with suitable commentary
input: touchscreen: melfas_mip4: Remove a bunch of unused variables
input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
input: touchscreen: surface3_spi: Remove set but unused variable
'timestamp'
drivers/input/mouse/synaptics.c | 7 +++++--
drivers/input/touchscreen/melfas_mip4.c | 11 -----------
drivers/input/touchscreen/surface3_spi.c | 2 --
drivers/input/touchscreen/usbtouchscreen.c | 4 ++--
4 files changed, 7 insertions(+), 17 deletions(-)
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Bruce Kalk <kall@compass.com>
Cc: "C. Scott Ananian" <cananian@alumni.priceton.edu>
Cc: Daniel Ritz <daniel.ritz@gmx.ch>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: James Hilliard <james.hilliard1@gmail.com>
Cc: linux-input@vger.kernel.org
Cc: Peter Osterlund <petero2@telia.com>
Cc: Sangwon Jee <jeesw@melfas.com>
Cc: Stefan Gmeiner <riddlebox@freesurf.ch>
Cc: this to <linux-input@vger.kernel.org>
--
2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/4] input: mouse: synaptics: Replace NOOP with suitable commentary
2020-11-26 13:36 [PATCH v2 0/4] [Set 2/2] Rid W=1 issues from Input Lee Jones
@ 2020-11-26 13:36 ` Lee Jones
2020-11-26 13:36 ` [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables Lee Jones
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2020-11-26 13:36 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Henrik Rydberg, Peter Osterlund,
Stefan Gmeiner, C. Scott Ananian, Bruce Kalk, this to
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Peter Osterlund <petero2@telia.com>
Cc: Stefan Gmeiner <riddlebox@freesurf.ch>
Cc: "C. Scott Ananian" <cananian@alumni.priceton.edu>
Cc: Bruce Kalk <kall@compass.com>
Cc: this to <linux-input@vger.kernel.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/mouse/synaptics.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 8fb7b4385ded9..3cc8b76629fa2 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -1106,8 +1106,11 @@ static void synaptics_process_packet(struct psmouse *psmouse)
num_fingers = hw.w + 2;
break;
case 2:
- if (SYN_MODEL_PEN(info->model_id))
- ; /* Nothing, treat a pen as a single finger */
+ /*
+ * Keep defaults
+ *
+ * SYN_MODEL_PEN: Treat pens as a single finger
+ */
break;
case 4 ... 15:
if (SYN_CAP_PALMDETECT(info->capabilities))
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables
2020-11-26 13:36 [PATCH v2 0/4] [Set 2/2] Rid W=1 issues from Input Lee Jones
2020-11-26 13:36 ` [PATCH v2 1/4] input: mouse: synaptics: Replace NOOP with suitable commentary Lee Jones
@ 2020-11-26 13:36 ` Lee Jones
2020-11-29 2:59 ` Dmitry Torokhov
2020-11-26 13:36 ` [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Lee Jones
2020-11-26 13:36 ` [PATCH v2 4/4] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Lee Jones
3 siblings, 1 reply; 8+ messages in thread
From: Lee Jones @ 2020-11-26 13:36 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Sangwon Jee, Dmitry Torokhov, Henrik Rydberg, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’:
drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable]
drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable]
drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable]
Cc: Sangwon Jee <jeesw@melfas.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/touchscreen/melfas_mip4.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
index f67efdd040b24..9c98759098c7a 100644
--- a/drivers/input/touchscreen/melfas_mip4.c
+++ b/drivers/input/touchscreen/melfas_mip4.c
@@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)
static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
{
int id;
- bool hover;
- bool palm;
bool state;
u16 x, y;
- u8 pressure_stage = 0;
u8 pressure;
- u8 size;
u8 touch_major;
u8 touch_minor;
@@ -480,14 +476,11 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
case 1:
/* Touch only */
state = packet[0] & BIT(7);
- hover = packet[0] & BIT(5);
- palm = packet[0] & BIT(4);
id = (packet[0] & 0x0F) - 1;
x = ((packet[1] & 0x0F) << 8) | packet[2];
y = (((packet[1] >> 4) & 0x0F) << 8) |
packet[3];
pressure = packet[4];
- size = packet[5];
if (ts->event_format == 0) {
touch_major = packet[5];
touch_minor = packet[5];
@@ -501,14 +494,10 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
default:
/* Touch + Force(Pressure) */
id = (packet[0] & 0x0F) - 1;
- hover = packet[1] & BIT(2);
- palm = packet[1] & BIT(1);
state = packet[1] & BIT(0);
x = ((packet[2] & 0x0F) << 8) | packet[3];
y = (((packet[2] >> 4) & 0x0F) << 8) |
packet[4];
- size = packet[6];
- pressure_stage = (packet[7] & 0xF0) >> 4;
pressure = ((packet[7] & 0x0F) << 8) |
packet[8];
touch_major = packet[9];
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
2020-11-26 13:36 [PATCH v2 0/4] [Set 2/2] Rid W=1 issues from Input Lee Jones
2020-11-26 13:36 ` [PATCH v2 1/4] input: mouse: synaptics: Replace NOOP with suitable commentary Lee Jones
2020-11-26 13:36 ` [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables Lee Jones
@ 2020-11-26 13:36 ` Lee Jones
2020-11-29 2:59 ` Dmitry Torokhov
2020-11-26 13:36 ` [PATCH v2 4/4] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Lee Jones
3 siblings, 1 reply; 8+ messages in thread
From: Lee Jones @ 2020-11-26 13:36 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Henrik Rydberg, James Hilliard,
Daniel Ritz, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’:
drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: James Hilliard <james.hilliard1@gmail.com>
Cc: Daniel Ritz <daniel.ritz@gmx.ch>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/touchscreen/usbtouchscreen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index 397cb1d3f481b..c3b7130cd9033 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)
unsigned int data_len = be16_to_cpu(packet->data_len);
unsigned int x_len = be16_to_cpu(packet->x_len);
unsigned int y_len = be16_to_cpu(packet->y_len);
- int x, y, begin_x, begin_y, end_x, end_y, w, h, ret;
+ int x, y, begin_x, begin_y, end_x, end_y, w, h;
/* got touch data? */
if ((pkt[0] & 0xe0) != 0xe0)
@@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)
x_len -= 0x80;
/* send ACK */
- ret = usb_submit_urb(priv->ack, GFP_ATOMIC);
+ usb_submit_urb(priv->ack, GFP_ATOMIC);
if (!usbtouch->type->max_xc) {
usbtouch->type->max_xc = 2 * x_len;
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 4/4] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'
2020-11-26 13:36 [PATCH v2 0/4] [Set 2/2] Rid W=1 issues from Input Lee Jones
` (2 preceding siblings ...)
2020-11-26 13:36 ` [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Lee Jones
@ 2020-11-26 13:36 ` Lee Jones
3 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2020-11-26 13:36 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Dmitry Torokhov, Henrik Rydberg,
Benjamin Tissoires, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’:
drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable]
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/touchscreen/surface3_spi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c
index 731454599fcee..1da23e5585a0d 100644
--- a/drivers/input/touchscreen/surface3_spi.c
+++ b/drivers/input/touchscreen/surface3_spi.c
@@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data,
static void surface3_spi_process_touch(struct surface3_ts_data *ts_data, u8 *data)
{
- u16 timestamp;
unsigned int i;
- timestamp = get_unaligned_le16(&data[15]);
for (i = 0; i < 13; i++) {
struct surface3_ts_data_finger *finger;
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables
2020-11-26 13:36 ` [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables Lee Jones
@ 2020-11-29 2:59 ` Dmitry Torokhov
0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Torokhov @ 2020-11-29 2:59 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Sangwon Jee, Henrik Rydberg, linux-input
Hi Lee,
On Thu, Nov 26, 2020 at 01:36:05PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’:
> drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
> drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable]
> drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable]
> drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable]
>
> Cc: Sangwon Jee <jeesw@melfas.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/input/touchscreen/melfas_mip4.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
> index f67efdd040b24..9c98759098c7a 100644
> --- a/drivers/input/touchscreen/melfas_mip4.c
> +++ b/drivers/input/touchscreen/melfas_mip4.c
> @@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)
> static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
> {
> int id;
> - bool hover;
> - bool palm;
So __always_unused did not work?
--
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
2020-11-26 13:36 ` [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Lee Jones
@ 2020-11-29 2:59 ` Dmitry Torokhov
2020-11-29 8:27 ` Lee Jones
0 siblings, 1 reply; 8+ messages in thread
From: Dmitry Torokhov @ 2020-11-29 2:59 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Henrik Rydberg, James Hilliard, Daniel Ritz, linux-input
Hi Lee,
On Thu, Nov 26, 2020 at 01:36:06PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’:
> drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: James Hilliard <james.hilliard1@gmail.com>
> Cc: Daniel Ritz <daniel.ritz@gmx.ch>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/input/touchscreen/usbtouchscreen.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
> index 397cb1d3f481b..c3b7130cd9033 100644
> --- a/drivers/input/touchscreen/usbtouchscreen.c
> +++ b/drivers/input/touchscreen/usbtouchscreen.c
> @@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)
> unsigned int data_len = be16_to_cpu(packet->data_len);
> unsigned int x_len = be16_to_cpu(packet->x_len);
> unsigned int y_len = be16_to_cpu(packet->y_len);
> - int x, y, begin_x, begin_y, end_x, end_y, w, h, ret;
> + int x, y, begin_x, begin_y, end_x, end_y, w, h;
>
> /* got touch data? */
> if ((pkt[0] & 0xe0) != 0xe0)
> @@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)
> x_len -= 0x80;
>
> /* send ACK */
> - ret = usb_submit_urb(priv->ack, GFP_ATOMIC);
> + usb_submit_urb(priv->ack, GFP_ATOMIC);
I thought you were going to add error handling here?
>
> if (!usbtouch->type->max_xc) {
> usbtouch->type->max_xc = 2 * x_len;
> --
> 2.25.1
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
2020-11-29 2:59 ` Dmitry Torokhov
@ 2020-11-29 8:27 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2020-11-29 8:27 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-kernel, Henrik Rydberg, James Hilliard, Daniel Ritz, linux-input
On Sat, 28 Nov 2020, Dmitry Torokhov wrote:
> Hi Lee,
>
> On Thu, Nov 26, 2020 at 01:36:06PM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’:
> > drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Henrik Rydberg <rydberg@bitmath.org>
> > Cc: James Hilliard <james.hilliard1@gmail.com>
> > Cc: Daniel Ritz <daniel.ritz@gmx.ch>
> > Cc: linux-input@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/input/touchscreen/usbtouchscreen.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
> > index 397cb1d3f481b..c3b7130cd9033 100644
> > --- a/drivers/input/touchscreen/usbtouchscreen.c
> > +++ b/drivers/input/touchscreen/usbtouchscreen.c
> > @@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)
> > unsigned int data_len = be16_to_cpu(packet->data_len);
> > unsigned int x_len = be16_to_cpu(packet->x_len);
> > unsigned int y_len = be16_to_cpu(packet->y_len);
> > - int x, y, begin_x, begin_y, end_x, end_y, w, h, ret;
> > + int x, y, begin_x, begin_y, end_x, end_y, w, h;
> >
> > /* got touch data? */
> > if ((pkt[0] & 0xe0) != 0xe0)
> > @@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt)
> > x_len -= 0x80;
> >
> > /* send ACK */
> > - ret = usb_submit_urb(priv->ack, GFP_ATOMIC);
> > + usb_submit_urb(priv->ack, GFP_ATOMIC);
>
> I thought you were going to add error handling here?
Hmm... I thought I handed all of the review comments!
Will look into this again on Monday.
> > if (!usbtouch->type->max_xc) {
> > usbtouch->type->max_xc = 2 * x_len;
>
> Thanks.
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-11-29 8:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 13:36 [PATCH v2 0/4] [Set 2/2] Rid W=1 issues from Input Lee Jones
2020-11-26 13:36 ` [PATCH v2 1/4] input: mouse: synaptics: Replace NOOP with suitable commentary Lee Jones
2020-11-26 13:36 ` [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables Lee Jones
2020-11-29 2:59 ` Dmitry Torokhov
2020-11-26 13:36 ` [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Lee Jones
2020-11-29 2:59 ` Dmitry Torokhov
2020-11-29 8:27 ` Lee Jones
2020-11-26 13:36 ` [PATCH v2 4/4] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).