From: Matthew Wilcox <willy@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Yu Zhao <yuzhao@google.com>,
Alex Shi <alex.shi@linux.alibaba.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next] mm/swap.c: reduce lock contention in lru_cache_add
Date: Thu, 26 Nov 2020 15:55:53 +0000 [thread overview]
Message-ID: <20201126155553.GT4327@casper.infradead.org> (raw)
In-Reply-To: <c3d53633-af28-79c1-f42c-d5b851af4d56@suse.cz>
On Thu, Nov 26, 2020 at 04:44:04PM +0100, Vlastimil Babka wrote:
> However, Matthew wanted to increase pagevec size [1] and once 15^2 becomes
> 63^2, it starts to be somewhat more worrying.
>
> [1] https://lore.kernel.org/linux-mm/20201105172651.2455-1-willy@infradead.org/
Well, Tim wanted it ;-)
I would suggest that rather than an insertion sort (or was it a bubble
sort?), we should be using a Shell sort. It's ideal for these kinds of
smallish arrays.
https://en.wikipedia.org/wiki/Shellsort
next prev parent reply other threads:[~2020-11-26 15:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 8:27 [PATCH next] mm/swap.c: reduce lock contention in lru_cache_add Alex Shi
2020-11-20 23:19 ` Andrew Morton
2020-11-23 4:46 ` Alex Shi
2020-11-25 15:38 ` Vlastimil Babka
2020-11-26 3:12 ` Alex Shi
2020-11-26 11:05 ` Vlastimil Babka
2020-11-26 4:52 ` Yu Zhao
2020-11-26 6:39 ` Alex Shi
2020-11-26 7:24 ` Yu Zhao
2020-11-26 8:09 ` Alex Shi
2020-11-26 11:22 ` Vlastimil Babka
2020-11-26 15:44 ` Vlastimil Babka
2020-11-26 15:55 ` Matthew Wilcox [this message]
2020-11-27 3:14 ` Alex Shi
2020-12-01 8:02 ` [PATCH 1/3] mm/swap.c: pre-sort pages in pagevec for pagevec_lru_move_fn Alex Shi
2020-12-01 8:02 ` [PATCH 2/3] mm/swap.c: bail out early for no memcg and no numa Alex Shi
2020-12-01 8:02 ` [PATCH 3/3] mm/swap.c: extend the usage to pagevec_lru_add Alex Shi
2020-12-01 8:10 ` [PATCH 1/3] mm/swap.c: pre-sort pages in pagevec for pagevec_lru_move_fn Michal Hocko
2020-12-01 8:20 ` Alex Shi
2020-12-25 9:59 ` [RFC PATCH 0/4] pre sort pages on lruvec in pagevec Alex Shi
2020-12-25 9:59 ` [RFC PATCH 1/4] mm/swap.c: pre-sort pages in pagevec for pagevec_lru_move_fn Alex Shi
2020-12-25 9:59 ` [RFC PATCH 2/4] mm/swap.c: bail out early for no memcg and no numa Alex Shi
2020-12-25 9:59 ` [RFC PATCH 3/4] mm/swap.c: extend the usage to pagevec_lru_add Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126155553.GT4327@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=hughd@google.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).