From: Florent Revest <revest@chromium.org>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kpsingh@chromium.org, revest@google.com,
linux-kernel@vger.kernel.org
Subject: [PATCH bpf-next 2/2] selftests/bpf: Add bpf_kallsyms_lookup test
Date: Thu, 26 Nov 2020 17:57:48 +0100 [thread overview]
Message-ID: <20201126165748.1748417-2-revest@google.com> (raw)
In-Reply-To: <20201126165748.1748417-1-revest@google.com>
This piggybacks on the existing "ksyms" test because this test also
relies on a __ksym symbol and requires CONFIG_KALLSYMS.
Signed-off-by: Florent Revest <revest@google.com>
---
tools/testing/selftests/bpf/config | 1 +
.../testing/selftests/bpf/prog_tests/ksyms.c | 46 ++++++++++++++++++-
.../bpf/progs/test_kallsyms_lookup.c | 38 +++++++++++++++
3 files changed, 84 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/selftests/bpf/progs/test_kallsyms_lookup.c
diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
index 365bf9771b07..791a46e5d013 100644
--- a/tools/testing/selftests/bpf/config
+++ b/tools/testing/selftests/bpf/config
@@ -43,3 +43,4 @@ CONFIG_IMA=y
CONFIG_SECURITYFS=y
CONFIG_IMA_WRITE_POLICY=y
CONFIG_IMA_READ_POLICY=y
+CONFIG_KALLSYMS=y
diff --git a/tools/testing/selftests/bpf/prog_tests/ksyms.c b/tools/testing/selftests/bpf/prog_tests/ksyms.c
index b295969b263b..0478b67a92ae 100644
--- a/tools/testing/selftests/bpf/prog_tests/ksyms.c
+++ b/tools/testing/selftests/bpf/prog_tests/ksyms.c
@@ -3,11 +3,12 @@
#include <test_progs.h>
#include "test_ksyms.skel.h"
+#include "test_kallsyms_lookup.skel.h"
#include <sys/stat.h>
static int duration;
-void test_ksyms(void)
+void test_ksyms_variables(void)
{
const char *btf_path = "/sys/kernel/btf/vmlinux";
struct test_ksyms *skel;
@@ -59,3 +60,46 @@ void test_ksyms(void)
cleanup:
test_ksyms__destroy(skel);
}
+
+void test_kallsyms_lookup(void)
+{
+ struct test_kallsyms_lookup *skel;
+ int err;
+
+ skel = test_kallsyms_lookup__open_and_load();
+ if (CHECK(!skel, "skel_open", "failed to open and load skeleton\n"))
+ return;
+
+ err = test_kallsyms_lookup__attach(skel);
+ if (CHECK(err, "skel_attach", "skeleton attach failed: %d\n", err))
+ goto cleanup;
+
+ /* trigger tracepoint */
+ usleep(1);
+
+ CHECK(strcmp(skel->bss->name, "schedule"), "name",
+ "got \"%s\", exp \"schedule\"\n", skel->bss->name);
+ CHECK(strcmp(skel->bss->name_truncated, "sched"), "name_truncated",
+ "got \"%s\", exp \"sched\"\n", skel->bss->name_truncated);
+ CHECK(strcmp(skel->bss->name_invalid, ""), "name_invalid",
+ "got \"%s\", exp \"\"\n", skel->bss->name_invalid);
+ CHECK(strcmp(skel->bss->module_name, ""), "module_name",
+ "got \"%s\", exp \"\"\n", skel->bss->module_name);
+ CHECK(skel->bss->schedule_ret != 9, "schedule_ret",
+ "got %d, exp 0\n", skel->bss->schedule_ret);
+ CHECK(skel->bss->sched_ret != 9, "sched_ret",
+ "got %d, exp 0\n", skel->bss->sched_ret);
+ CHECK(skel->bss->invalid_ret != -EINVAL, "invalid_ret",
+ "got %d, exp %d\n", skel->bss->invalid_ret, -EINVAL);
+
+cleanup:
+ test_kallsyms_lookup__destroy(skel);
+}
+
+void test_ksyms(void)
+{
+ if (test__start_subtest("ksyms_variables"))
+ test_ksyms_variables();
+ if (test__start_subtest("kallsyms_lookup"))
+ test_kallsyms_lookup();
+}
diff --git a/tools/testing/selftests/bpf/progs/test_kallsyms_lookup.c b/tools/testing/selftests/bpf/progs/test_kallsyms_lookup.c
new file mode 100644
index 000000000000..4f15f1527ab4
--- /dev/null
+++ b/tools/testing/selftests/bpf/progs/test_kallsyms_lookup.c
@@ -0,0 +1,38 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2020 Google LLC. */
+
+#include <linux/bpf.h>
+#include <bpf/bpf_helpers.h>
+
+extern const void schedule __ksym;
+
+#define SYMBOL_NAME_LEN 10
+char name[SYMBOL_NAME_LEN];
+char name_invalid[SYMBOL_NAME_LEN];
+
+#define SYMBOL_TRUNCATED_NAME_LEN 6
+char name_truncated[SYMBOL_TRUNCATED_NAME_LEN];
+
+#define MODULE_NAME_LEN 64
+char module_name[MODULE_NAME_LEN];
+
+long schedule_ret;
+long sched_ret;
+long invalid_ret;
+
+SEC("raw_tp/sys_enter")
+int handler(const void *ctx)
+{
+ schedule_ret = bpf_kallsyms_lookup((__u64)&schedule,
+ name, SYMBOL_NAME_LEN,
+ module_name, MODULE_NAME_LEN);
+ invalid_ret = bpf_kallsyms_lookup(0,
+ name_invalid, SYMBOL_NAME_LEN,
+ module_name, MODULE_NAME_LEN);
+ sched_ret = bpf_kallsyms_lookup((__u64)&schedule, name_truncated,
+ SYMBOL_TRUNCATED_NAME_LEN,
+ module_name, MODULE_NAME_LEN);
+ return 0;
+}
+
+char _license[] SEC("license") = "GPL";
--
2.29.2.454.gaff20da3a2-goog
next prev parent reply other threads:[~2020-11-26 16:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 16:57 [PATCH bpf-next 1/2] bpf: Add a bpf_kallsyms_lookup helper Florent Revest
2020-11-26 16:57 ` Florent Revest [this message]
2020-12-02 0:57 ` [PATCH bpf-next 2/2] selftests/bpf: Add bpf_kallsyms_lookup test Andrii Nakryiko
2020-11-27 2:32 ` [PATCH bpf-next 1/2] bpf: Add a bpf_kallsyms_lookup helper KP Singh
2020-11-27 9:25 ` Florent Revest
2020-11-27 9:27 ` Florent Revest
2020-11-27 7:35 ` Yonghong Song
2020-11-27 9:20 ` Florent Revest
2020-11-27 11:20 ` KP Singh
2020-11-27 16:09 ` Yonghong Song
2020-12-02 0:55 ` Andrii Nakryiko
2020-12-02 20:32 ` Florent Revest
2020-12-02 21:18 ` Alexei Starovoitov
2020-12-11 14:40 ` Florent Revest
2020-12-14 6:47 ` Yonghong Song
2020-12-17 15:31 ` Florent Revest
2020-12-17 17:26 ` Yonghong Song
2020-12-18 3:20 ` Alexei Starovoitov
2020-12-18 4:39 ` Yonghong Song
2020-12-18 18:53 ` Andrii Nakryiko
2020-12-18 20:36 ` Alexei Starovoitov
2020-12-18 20:47 ` Andrii Nakryiko
2020-12-22 20:38 ` Florent Revest
2020-12-22 20:52 ` Florent Revest
2020-12-22 14:18 ` Christoph Hellwig
2020-12-22 20:17 ` Florent Revest
2020-12-23 7:50 ` Christoph Hellwig
2020-12-02 0:47 ` Andrii Nakryiko
2020-11-27 17:20 ` kernel test robot
2020-11-27 17:20 ` [RFC PATCH] bpf: bpf_kallsyms_lookup_proto can be static kernel test robot
2020-11-29 1:07 ` [PATCH bpf-next 1/2] bpf: Add a bpf_kallsyms_lookup helper Alexei Starovoitov
2020-11-30 16:23 ` Florent Revest
2020-12-01 2:41 ` Alexei Starovoitov
2020-12-01 20:25 ` Florent Revest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126165748.1748417-2-revest@google.com \
--to=revest@chromium.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=revest@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).