From: Matthew Wilcox <willy@infradead.org>
To: trix@redhat.com
Cc: jlayton@kernel.org, bfields@fieldses.org,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locks: remove trailing semicolon in macro definition
Date: Fri, 27 Nov 2020 19:53:23 +0000 [thread overview]
Message-ID: <20201127195323.GZ4327@casper.infradead.org> (raw)
In-Reply-To: <20201127190707.2844580-1-trix@redhat.com>
On Fri, Nov 27, 2020 at 11:07:07AM -0800, trix@redhat.com wrote:
> +++ b/fs/fcntl.c
> @@ -526,7 +526,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned int, cmd,
> (dst)->l_whence = (src)->l_whence; \
> (dst)->l_start = (src)->l_start; \
> (dst)->l_len = (src)->l_len; \
> - (dst)->l_pid = (src)->l_pid;
> + (dst)->l_pid = (src)->l_pid
This should be wrapped in a do { } while (0).
Look, this warning is clearly great at finding smelly code, but the
fixes being generated to shut up the warning are low quality.
next prev parent reply other threads:[~2020-11-28 3:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 19:07 [PATCH] locks: remove trailing semicolon in macro definition trix
2020-11-27 19:53 ` Matthew Wilcox [this message]
2020-11-29 17:47 ` Tom Rix
2020-11-29 17:52 ` Randy Dunlap
2020-11-29 18:15 ` James Bottomley
2020-11-29 22:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201127195323.GZ4327@casper.infradead.org \
--to=willy@infradead.org \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).