From: Al Viro <viro@zeniv.linux.org.uk>
To: Walt Drummond <walt@drummond.us>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, hpa@zytor.com, brgerst@gmail.com,
linux@dominikbrodowski.net, gustavoars@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/signals: Fix save/restore signal stack to correctly support sigset_t
Date: Sat, 28 Nov 2020 05:23:17 +0000 [thread overview]
Message-ID: <20201128052317.GY3576660@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20201119221132.1515696-1-walt@drummond.us>
On Thu, Nov 19, 2020 at 02:11:33PM -0800, Walt Drummond wrote:
> The macro unsafe_put_sigmask() only handles the first 64 bits of the
> sigmask_t, which works today. However, if the definition of the
> sigset_t structure ever changed,
... existing userland would get fucked over, since sigset_t is
present in user-visible data structures. Including the ones
we are using that thing for - struct rt_sigframe, for starters.
Layout of those suckers is very much cast in stone. We *can't*
change it, no matter what we do kernel-side.
NAKed-by: Al Viro <viro@zeniv.linux.org.uk>
next prev parent reply other threads:[~2020-11-28 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 22:11 [PATCH] x86/signals: Fix save/restore signal stack to correctly support sigset_t Walt Drummond
2020-11-28 5:23 ` Al Viro [this message]
[not found] ` <CADCN6nyGW0=QS=J+704n-mtAqTxgVrKZC=P8d01NZ_pjssptew@mail.gmail.com>
2020-11-29 2:52 ` Walt Drummond
2020-11-29 3:28 ` Al Viro
2020-11-29 16:27 ` Walt Drummond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128052317.GY3576660@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=gustavoars@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=walt@drummond.us \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).