From: Daniel Wagner <dwagner@suse.de>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: trix@redhat.com, njavali@marvell.com, jejb@linux.ibm.com,
"Martin K . Petersen" <martin.petersen@oracle.com>,
GR-QLogic-Storage-Upstream@marvell.com,
linux-scsi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition
Date: Mon, 30 Nov 2020 10:34:04 +0100 [thread overview]
Message-ID: <20201130093404.xjow7bddb5jw3myj@beryllium.lan> (raw)
In-Reply-To: <CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com>
On Mon, Nov 30, 2020 at 01:29:19AM -0800, Maciej Żenczykowski wrote:
> On Mon, Nov 30, 2020 at 1:23 AM Daniel Wagner <dwagner@suse.de> wrote:
> > > #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
> > > - atomic_dec(&__qpair->ref_count); \
> > > + atomic_dec(&__qpair->ref_count) \
> >
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> >
>
> Uhm, if there's no semicolon, then presumably it's the final line of the
> macro, and thus there should be no tabs and no backslash at the end of the
> line.
Right! Didn't realize it. The backslash should be removed.
next prev parent reply other threads:[~2020-11-30 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 18:27 [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition trix
2020-11-30 9:17 ` Daniel Wagner
[not found] ` <CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com>
2020-11-30 9:34 ` Daniel Wagner [this message]
2020-11-30 16:16 ` Tom Rix
2020-11-30 16:30 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130093404.xjow7bddb5jw3myj@beryllium.lan \
--to=dwagner@suse.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=trix@redhat.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).