From: Will Deacon <will@kernel.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Wei Li <liwei391@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Marc Zyngier <maz@kernel.org>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Amit Daniel Kachhap <amit.kachhap@arm.com>,
Vladimir Murzin <vladimir.murzin@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, guohanjun@huawei.com
Subject: Re: [PATCH v3] drivers/perf: Add support for ARMv8.3-SPE
Date: Mon, 30 Nov 2020 09:55:12 +0000 [thread overview]
Message-ID: <20201130095512.GA24098@willie-the-truck> (raw)
In-Reply-To: <861cf678-3e6f-7627-8d41-b9395cb6e5e0@arm.com>
On Fri, Nov 27, 2020 at 12:03:35PM +0000, Suzuki K Poulose wrote:
> On 11/27/20 6:03 AM, Wei Li wrote:
> > Armv8.3 extends the SPE by adding:
> > - Alignment field in the Events packet, and filtering on this event
> > using PMSEVFR_EL1.
> > - Support for the Scalable Vector Extension (SVE).
> >
> > The main additions for SVE are:
> > - Recording the vector length for SVE operations in the Operation Type
> > packet. It is not possible to filter on vector length.
> > - Incomplete predicate and empty predicate fields in the Events packet,
> > and filtering on these events using PMSEVFR_EL1.
> >
> > Update the check of pmsevfr for empty/partial predicated SVE and
> > alignment event in SPE driver. For adaption by the version of SPE,
> > expose 'pmsver' as cap attribute to userspace.
> >
> > Signed-off-by: Wei Li <liwei391@huawei.com>
>
> nit: Do we need to update the Kconfig help text too ? Right now that says :
>
> --
>
>
> tristate "Enable support for the ARMv8.2 Statistical Profiling Extension""
> ....
>
> help
> Enable perf support for the ARMv8.2 Statistical Profiling
> Extension, which provides periodic sampling of operations in
I think it's ok as-is, to be honest. It identifies the version of the
architecture when the feature was introduced, and I think it's only
reasonable to assume that subsequent versions of the architecture might
add extensions.
Will
next prev parent reply other threads:[~2020-11-30 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 6:03 [PATCH v3] drivers/perf: Add support for ARMv8.3-SPE Wei Li
2020-11-27 12:03 ` Suzuki K Poulose
2020-11-30 9:55 ` Will Deacon [this message]
2020-11-30 10:06 ` Will Deacon
2020-12-03 8:42 ` liwei (GF)
2020-12-03 9:19 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130095512.GA24098@willie-the-truck \
--to=will@kernel.org \
--cc=amit.kachhap@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=guohanjun@huawei.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=vincenzo.frascino@arm.com \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).