From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 2/2] media: i2c: Add support for the OV5648 image sensor
Date: Mon, 30 Nov 2020 15:53:31 +0200 [thread overview]
Message-ID: <20201130135331.GW3940@paasikivi.fi.intel.com> (raw)
In-Reply-To: <X8T4FH/QjRdLu0hS@aptenodytes>
Hi Paul,
On Mon, Nov 30, 2020 at 02:48:04PM +0100, Paul Kocialkowski wrote:
> Hi Sakari,
>
> On Mon 30 Nov 20, 11:28, Sakari Ailus wrote:
> > Hi Paul,
> >
> > Thanks for the update. I have a few comments on the driver, too.
>
> Thanks for the review!
>
> [...]
>
> > > + ret = ov5648_write(sensor, OV5648_GAIN_BLUE_MAN_L_REG,
> > > + OV5648_GAIN_BLUE_MAN_L(blue_balance));
> >
> > return ...
> >
> > Same below (and above).
>
> Well I don't think that makes any functional difference, right?
> My personal preference is to have explicit checks even at the end of functions
> for symetry and alignment with other blocks.
>
> If it's okay, it'd like to keep it as-is. But if that's against kernel coding
> style guidelines, I won't argue more.
Please do change them.
It's useless code, repeated at the end of a number of functions in this
driver. I wouldn't mind otherwise, but people do take examples from
existing drivers so such patterns tend to repeat in other places.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2020-11-30 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 14:33 [PATCH v4 0/2] media: i2c: OV5648 image sensor support Paul Kocialkowski
2020-11-28 14:33 ` [PATCH v4 1/2] dt-bindings: media: i2c: Add OV5648 bindings documentation Paul Kocialkowski
2020-11-28 14:33 ` [PATCH v4 2/2] media: i2c: Add support for the OV5648 image sensor Paul Kocialkowski
2020-11-30 9:28 ` Sakari Ailus
2020-11-30 13:48 ` Paul Kocialkowski
2020-11-30 13:53 ` Sakari Ailus [this message]
2020-12-02 13:50 ` Paul Kocialkowski
2020-12-08 23:34 ` Sakari Ailus
2020-12-09 14:05 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130135331.GW3940@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).