From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A52C8300F for ; Mon, 30 Nov 2020 14:53:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 993DB20725 for ; Mon, 30 Nov 2020 14:53:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="x4dw/ep/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727774AbgK3OxB (ORCPT ); Mon, 30 Nov 2020 09:53:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727151AbgK3OxA (ORCPT ); Mon, 30 Nov 2020 09:53:00 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7317FC0617A6; Mon, 30 Nov 2020 06:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=00hy5+VjqFwiD2syVRyuoORrm6whlaAbkwtX1jJA8To=; b=x4dw/ep/4HrrUswFPw0AW1VXX yDtM71P5YxG4Ye9p1sUwdGauhdfv2QK+Uz8//pwIJmTpe8sCz1J1AMsGTbPiboiYVwn7ifOfRO72F xebP4pllpdUAJfZBvUR+xmnJCU5X3ukPx9Wi61GGTiV24WMx7+5pRsZ8daUvTf0th+MbKEjBWtkJT 3lUQsfDflyxbRuXagDkNryQpG3R2A1HKEPXJMv5iDE12+3WHLOnfZWIx6KiJ0L6o+4rwGTBcNwXIY buWPIokux2rPUbRiS63JORxOFdUdcvQoOjFZ2f09LSSQAfBcP9JmWg6cY5pFvapsGgUJs1vbQkzKH byBSbO4ng==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38024) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjkXG-0006wU-MI; Mon, 30 Nov 2020 14:52:14 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kjkXG-00055w-Ci; Mon, 30 Nov 2020 14:52:14 +0000 Date: Mon, 30 Nov 2020 14:52:14 +0000 From: Russell King - ARM Linux admin To: Steen Hegelund Cc: Andrew Lunn , "David S. Miller" , Jakub Kicinski , Masahiro Yamada , Lars Povlsen , Bjarni Jonasson , Microchip Linux Driver Support , Alexandre Belloni , Microsemi List , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver Message-ID: <20201130145214.GX1551@shell.armlinux.org.uk> References: <20201127133307.2969817-1-steen.hegelund@microchip.com> <20201127133307.2969817-3-steen.hegelund@microchip.com> <20201128190616.GF2191767@lunn.ch> <20201128222828.GQ1551@shell.armlinux.org.uk> <20201129105245.GG1605@shell.armlinux.org.uk> <20201130141556.o4vg32lr4uykwxmu@mchp-dev-shegelun> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130141556.o4vg32lr4uykwxmu@mchp-dev-shegelun> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2020 at 03:15:56PM +0100, Steen Hegelund wrote: > On 29.11.2020 10:52, Russell King - ARM Linux admin wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Sat, Nov 28, 2020 at 10:28:28PM +0000, Russell King - ARM Linux admin wrote: > > > On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > > > > +static void sparx5_phylink_mac_config(struct phylink_config *config, > > > > > + unsigned int mode, > > > > > + const struct phylink_link_state *state) > > > > > +{ > > > > > + struct sparx5_port *port = netdev_priv(to_net_dev(config->dev)); > > > > > + struct sparx5_port_config conf; > > > > > + int err = 0; > > > > > + > > > > > + conf = port->conf; > > > > > + conf.autoneg = state->an_enabled; > > > > > + conf.pause = state->pause; > > > > > + conf.duplex = state->duplex; > > > > > + conf.power_down = false; > > > > > + conf.portmode = state->interface; > > > > > + > > > > > + if (state->speed == SPEED_UNKNOWN) { > > > > > + /* When a SFP is plugged in we use capabilities to > > > > > + * default to the highest supported speed > > > > > + */ > > > > > > > > This looks suspicious. > > > > > > Yes, it looks highly suspicious. The fact that > > > sparx5_phylink_mac_link_up() is empty, and sparx5_phylink_mac_config() > > > does all the work suggests that this was developed before the phylink > > > re-organisation, and this code hasn't been updated for it. > > > > > > Any new code for the kernel really ought to be updated for the new > > > phylink methodology before it is accepted. > > > > > > Looking at sparx5_port_config(), it also seems to use > > > PHY_INTERFACE_MODE_1000BASEX for both 1000BASE-X and 2500BASE-X. All > > > very well for the driver to do that internally, but it's confusing > > > when it comes to reviewing this stuff, especially when people outside > > > of the driver (such as myself) reviewing it need to understand what's > > > going on with the configuration. > > > > Hi Russell, > > > There are other issues too. > > > > Looking at sparx5_get_1000basex_status(), we have: > > > > + status->link = DEV2G5_PCS1G_LINK_STATUS_LINK_STATUS_GET(value) | > > + DEV2G5_PCS1G_LINK_STATUS_SYNC_STATUS_GET(value); > > > > > Why is the link status the logical OR of these? > > Oops: It should have been AND. Well spotted. Do you need to check the sync status? Isn't it impossible to have "link up" on a link that is unsynchronised? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!