From: Rob Herring <robh@kernel.org>
To: Bongsu jeon <bongsu.jeon2@gmail.com>
Cc: Bongsu Jeon <bongsu.jeon@samsung.com>,
linux-nfc@lists.01.org, krzk@kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/4] dt-bindings: net: nfc: s3fwrn5: Support a UART interface
Date: Mon, 30 Nov 2020 10:37:52 -0700 [thread overview]
Message-ID: <20201130173752.GB2684526@robh.at.kernel.org> (raw)
In-Reply-To: <1606737627-29485-1-git-send-email-bongsu.jeon@samsung.com>
On Mon, 30 Nov 2020 21:00:27 +0900, Bongsu jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> Since S3FWRN82 NFC Chip, The UART interface can be used.
> S3FWRN82 supports I2C and UART interface.
>
> Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
> ---
>
> Changes in v2:
> -change the compatible name.
> -change the const to enum for compatible.
> -change the node name to nfc.
>
> .../bindings/net/nfc/samsung,s3fwrn5.yaml | 32 ++++++++++++++++++++--
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml:17:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
dtschema/dtc warnings/errors:
See https://patchwork.ozlabs.org/patch/1408172
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-11-30 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 12:00 [PATCH v2 net-next 1/4] dt-bindings: net: nfc: s3fwrn5: Support a UART interface Bongsu jeon
2020-11-30 16:55 ` Jakub Kicinski
2020-11-30 18:29 ` Krzysztof Kozlowski
2020-11-30 17:37 ` Rob Herring [this message]
2020-11-30 17:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130173752.GB2684526@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bongsu.jeon2@gmail.com \
--cc=bongsu.jeon@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).