From: Ezequiel Garcia <ezequiel@collabora.com>
To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kernel@collabora.com, Jonas Karlman <jonas@kwiboo.se>,
Hans Verkuil <hverkuil@xs4all.nl>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Maxime Ripard <mripard@kernel.org>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH v3 0/3] MPEG-2 stateless API cleanup
Date: Mon, 30 Nov 2020 15:52:56 -0300 [thread overview]
Message-ID: <20201130185259.111817-1-ezequiel@collabora.com> (raw)
Hello everyone,
Now that H.264 API is finally parked, and with all the lessons
learned from it, here's a revisit to MPEG-2.
The biggest changes are:
* Drop slice size and offset parameters, given the API doesn't
seem to be designed to work per-slice.
* Convert all the 1-bit syntax elements from structure fields
to bits in a bit field flags field, following the other codec APIs.
* Split the sequence, picture and slice headers to separate controls.
The series is tested by Jonas on RK3288 (Hantro G1) with FFmpeg + Kodi,
with some fixes that I included here. Thanks a lot Jonas!
v3:
* No API changes, just minor boilerplate fixes for the new
controls to be properly exposed, initialized and validated.
v2:
* Fixed bad use of boolean negation in a flag, which
was fortunately reported by 0day bot.
Ezequiel Garcia (3):
media: uapi: mpeg2: Cleanup flags
media: uapi: mpeg2: Remove unused slice size and offset
media: uapi: mpeg2: Split sequence and picture parameters
.../media/v4l/ext-ctrls-codec.rst | 159 +++++++++++-------
.../media/v4l/pixfmt-compressed.rst | 5 +-
drivers/media/v4l2-core/v4l2-ctrls.c | 71 +++++---
drivers/staging/media/hantro/hantro_drv.c | 10 ++
.../media/hantro/hantro_g1_mpeg2_dec.c | 82 +++++----
.../media/hantro/rk3399_vpu_hw_mpeg2_dec.c | 82 +++++----
drivers/staging/media/sunxi/cedrus/cedrus.c | 14 ++
drivers/staging/media/sunxi/cedrus/cedrus.h | 2 +
.../staging/media/sunxi/cedrus/cedrus_mpeg2.c | 49 +++---
include/media/mpeg2-ctrls.h | 153 +++++++++++++----
include/media/v4l2-ctrls.h | 4 +
11 files changed, 407 insertions(+), 224 deletions(-)
--
2.27.0
next reply other threads:[~2020-11-30 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 18:52 Ezequiel Garcia [this message]
2020-11-30 18:52 ` [PATCH v3 1/3] media: uapi: mpeg2: Cleanup flags Ezequiel Garcia
2020-11-30 18:52 ` [PATCH v3 2/3] media: uapi: mpeg2: Remove unused slice size and offset Ezequiel Garcia
2020-11-30 18:52 ` [PATCH v3 3/3] media: uapi: mpeg2: Split sequence and picture parameters Ezequiel Garcia
2020-12-02 15:11 ` Hans Verkuil
2020-12-02 21:46 ` Ezequiel Garcia
2020-12-03 8:51 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130185259.111817-1-ezequiel@collabora.com \
--to=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).