From: Rob Herring <robh@kernel.org>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: kieran.bingham+renesas@ideasonboard.com,
laurent.pinchart+renesas@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Hyun Kwon <hyunk@xilinx.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
sergei.shtylyov@gmail.com
Subject: Re: [PATCH v5 2/8] dt-bindings: media: max9286: Document 'maxim,initial-reverse-channel-mV'
Date: Mon, 30 Nov 2020 15:00:48 -0700 [thread overview]
Message-ID: <20201130220048.GA3104550@robh.at.kernel.org> (raw)
In-Reply-To: <20201116135305.81319-3-jacopo+renesas@jmondi.org>
On Mon, Nov 16, 2020 at 02:52:59PM +0100, Jacopo Mondi wrote:
> Document the 'initial-reverse-channel-mV' vendor property in the
> bindings document of the max9286 driver.
>
> The newly introduced property allows to specifying the initial
> configuration of the GMSL reverse control channel to accommodate
> remote serializers pre-programmed with the high threshold power
> supply noise immunity enabled.
>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> .../bindings/media/i2c/maxim,max9286.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index 9ea827092fdd..f61234d204fa 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -51,6 +51,26 @@ properties:
> '#gpio-cells':
> const: 2
>
> + maxim,initial-reverse-channel-mV:
Use standard unit suffix.
> + $ref: '/schemas/types.yaml#/definitions/uint32'
> + minimum: 30
> + maximum: 200
> + default: 170
> + description: |
> + Initial amplitude of the reverse control channel, in millivolts.
> +
> + The initial amplitude shall be adjusted to a value compatible with the
> + configuration of the connected remote serializer.
> +
> + Some camera modules (for example RDACM20) include an on-board MCU that
> + pre-programs the embedded serializer with power supply noise immunity
> + (high-threshold) enabled. A typical value of the deserializer's reverse
> + channel amplitude to communicate with pre-programmed serializers is 170mV.
> +
> + A typical value for the reverse channel amplitude to communicate with
> + a remote serializer whose high-threshold noise immunity is not enabled
> + is 100mV.
> +
> ports:
> type: object
> description: |
> @@ -221,6 +241,7 @@ required:
> - ports
> - i2c-mux
> - gpio-controller
> + - maxim,initial-reverse-channel-mV
>
> additionalProperties: false
>
> @@ -243,6 +264,8 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
>
> + maxim,initial-reverse-channel-mV = <170>;
> +
> ports {
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.29.1
>
next prev parent reply other threads:[~2020-11-30 22:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 13:52 [PATCH v5 0/8] media: i2c: Add RDACM21 camera module Jacopo Mondi
2020-11-16 13:52 ` [PATCH v5 1/8] media: i2c: Add driver for " Jacopo Mondi
2020-11-16 14:47 ` Kieran Bingham
2020-11-17 13:36 ` Jacopo Mondi
2020-11-17 15:31 ` Kieran Bingham
2020-11-19 14:42 ` Jacopo Mondi
2020-11-16 13:52 ` [PATCH v5 2/8] dt-bindings: media: max9286: Document 'maxim,initial-reverse-channel-mV' Jacopo Mondi
2020-11-30 22:00 ` Rob Herring [this message]
2020-12-15 11:14 ` Jacopo Mondi
2020-12-15 11:44 ` Geert Uytterhoeven
2020-12-15 12:08 ` Jacopo Mondi
2020-12-15 13:49 ` Rob Herring
2020-11-16 13:53 ` [PATCH v5 3/8] media: i2c: max9286: Break-out reverse channel setup Jacopo Mondi
2020-11-16 13:53 ` [PATCH v5 4/8] media: i2c: max9286: Make channel amplitude programmable Jacopo Mondi
2020-11-16 13:53 ` [PATCH v5 5/8] media: i2c: max9286: Configure reverse channel amplitude Jacopo Mondi
2020-11-16 13:53 ` [PATCH v5 6/8] arm64: dts: renesas: salvator-x: Add MAX9286 expansion board Jacopo Mondi
2020-11-16 13:53 ` [PATCH v5 7/8] [DNI] arm64: dts: renesas: salvator-x-max9286: Specify channel amplitude Jacopo Mondi
2020-11-18 13:40 ` Kieran Bingham
2020-11-16 13:53 ` [PATCH v5 8/8] [DNI] arm64: dts: renesas: eagle: " Jacopo Mondi
2020-11-18 13:34 ` [PATCH v5 0/8] media: i2c: Add RDACM21 camera module Kieran Bingham
2020-11-19 14:38 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130220048.GA3104550@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=hyunk@xilinx.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).