linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Masayoshi Mizuma <msys.mizuma@gmail.com>
Cc: Libo Chen <libo.chen@oracle.com>,
	linux-kernel@vger.kernel.org, m.mizuma@jp.fujitsu.com
Subject: Re: [PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls
Date: Mon, 30 Nov 2020 22:25:14 -0500	[thread overview]
Message-ID: <20201130222514.0949e3cc@oasis.local.home> (raw)
In-Reply-To: <20201130013256.oryyz4wxd356n74o@gabell>

On Sun, 29 Nov 2020 20:32:56 -0500
Masayoshi Mizuma <msys.mizuma@gmail.com> wrote:

> On Fri, Nov 20, 2020 at 06:12:43PM -0800, Libo Chen wrote:
> > This issue was first noticed when I was testing different kernels on
> > Oracle Linux 8 which as Fedora 30+ adopts BLS as default. Even though a
> > kernel entry was added successfully and the index of that kernel entry was
> > retrieved correctly, ktest still wouldn't reboot the system into
> > user-specified kernel.
> > 
> > The bug was spotted in subroutine reboot_to where the if-statement never
> > checks for REBOOT_TYPE "grub2bls", therefore the desired entry will not be
> > set for the next boot.
> > 
> > Add a check for "grub2bls" so that $grub_reboot $grub_number can
> > be run before a reboot if REBOOT_TYPE is "grub2bls" then we can boot to
> > the correct kernel.
> > 
> > Fixes: ac2466456eaa ("ktest: introduce grub2bls REBOOT_TYPE option")
> > 
> > Signed-off-by: Libo Chen <libo.chen@oracle.com>  
> 
> Thank you for the fix!
> I tested the patch with fedora33. It works well.
> 
> Please feel free to add:
> 
> 	Tested-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> 
>

Thanks.

I may push this upstream by the end of the week.

-- Steve

  reply	other threads:[~2020-12-01  3:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-21  2:12 [PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls Libo Chen
2020-11-21  4:12 ` Steven Rostedt
2020-11-25  1:33   ` Steven Rostedt
2020-11-30  1:32 ` Masayoshi Mizuma
2020-12-01  3:25   ` Steven Rostedt [this message]
2020-12-10 23:09     ` Libo Chen
2020-12-11  0:45       ` Steven Rostedt
2020-12-11  3:12         ` Libo Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201130222514.0949e3cc@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=libo.chen@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.mizuma@jp.fujitsu.com \
    --cc=msys.mizuma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).