linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] regulator: axp20x: Fix DLDO2 voltage control register mask for AXP22x
@ 2020-12-01  0:10 dinghua.ma, dinghua.ma.sz
  0 siblings, 0 replies; only message in thread
From: dinghua.ma, dinghua.ma.sz @ 2020-12-01  0:10 UTC (permalink / raw)
  To: Chen-Yu Tsai; +Cc: Mark Brown, Liam Girdwood, linux-kernel, DingHua Ma, stable

From: "DingHua Ma" <dinghua.ma.sz@gmail.com>

When I use the axp20x chip to power my SDIO device on the 5.4 kernel, 
the output voltage of DLDO2 is wrong. After comparing the register 
manual and source code of the chip, I found that the mask bit of the 
driver register of the port was wrong. I fixed this error by modifying 
the mask register of the source code. This error seems to be a copy 
error of the macro when writing the code. Now the voltage output of 
the DLDO2 port of axp20x is correct. My development environment is 
Allwinner A40I of arm architecture, and the kernel version is 5.4.

Signed-off-by: DingHua Ma <dinghua.ma.sz@gmail.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org> 
Cc: <stable@vger.kernel.org>
Fixes: db4a555f7c4c ("regulator: axp20x: use defines for masks")
---
Changes since v2:
- Modify topic description
---
Changes since v1:
- More accurate description for this patch
---
 drivers/regulator/axp20x-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index cd1224182ad7..90cb8445f721 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -594,7 +594,7 @@ static const struct regulator_desc axp22x_regulators[] = {
 		 AXP22X_DLDO1_V_OUT, AXP22X_DLDO1_V_OUT_MASK,
 		 AXP22X_PWR_OUT_CTRL2, AXP22X_PWR_OUT_DLDO1_MASK),
 	AXP_DESC(AXP22X, DLDO2, "dldo2", "dldoin", 700, 3300, 100,
-		 AXP22X_DLDO2_V_OUT, AXP22X_PWR_OUT_DLDO2_MASK,
+		 AXP22X_DLDO2_V_OUT, AXP22X_DLDO2_V_OUT_MASK,
 		 AXP22X_PWR_OUT_CTRL2, AXP22X_PWR_OUT_DLDO2_MASK),
 	AXP_DESC(AXP22X, DLDO3, "dldo3", "dldoin", 700, 3300, 100,
 		 AXP22X_DLDO3_V_OUT, AXP22X_DLDO3_V_OUT_MASK,
-- 
2.25.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-04 17:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01  0:10 [PATCH v3] regulator: axp20x: Fix DLDO2 voltage control register mask for AXP22x dinghua.ma, dinghua.ma.sz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).