From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Ingo Molnar <mingo@redhat.com>,
"Li, Aubrey" <aubrey.li@linux.intel.com>,
Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/fair: Clear SMT siblings after determining the core is not idle
Date: Tue, 1 Dec 2020 12:03:00 +0100 [thread overview]
Message-ID: <20201201110300.GR3040@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKfTPtBcZnxR073=eRsWNAGOnA8K4emL0BYEUzbkzZx6qJWmSg@mail.gmail.com>
On Mon, Nov 30, 2020 at 03:47:01PM +0100, Vincent Guittot wrote:
> On Mon, 30 Nov 2020 at 15:40, Mel Gorman <mgorman@techsingularity.net> wrote:
> >
> > The clearing of SMT siblings from the SIS mask before checking for an idle
> > core is a small but unnecessary cost. Defer the clearing of the siblings
> > until the scan moves to the next potential target. The cost of this was
> > not measured as it is borderline noise but it should be self-evident.
>
> Good point
>
> >
> > Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
>
> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Thanks!
next prev parent reply other threads:[~2020-12-01 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 14:40 [PATCH] sched/fair: Clear SMT siblings after determining the core is not idle Mel Gorman
2020-11-30 14:47 ` Vincent Guittot
2020-12-01 1:04 ` Li, Aubrey
2020-12-01 11:03 ` Peter Zijlstra [this message]
2020-12-03 9:13 ` [tip: sched/core] " tip-bot2 for Mel Gorman
2020-12-11 9:34 ` tip-bot2 for Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201110300.GR3040@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aubrey.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).