From: Christoph Hellwig <hch@lst.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Joel Becker <jlbec@evilplan.org>, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2 2/4] configfs: use BIT() for internal flags
Date: Tue, 1 Dec 2020 12:22:15 +0100 [thread overview]
Message-ID: <20201201112215.GA31985@lst.de> (raw)
In-Reply-To: <20201130164704.22991-3-brgl@bgdev.pl>
On Mon, Nov 30, 2020 at 05:47:02PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> For better readability and maintenance: use the BIT() macro for flag
> definitions.
This does not improve readability, as I now need to look up a macro,
one that doesn't make any sense at all. If you really prefer bit based
numbering just use the totally obvious (1 << bit) syntax.
next prev parent reply other threads:[~2020-12-01 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 16:47 [PATCH v2 0/4] configfs: implement committable items and add sample code Bartosz Golaszewski
2020-11-30 16:47 ` [PATCH v2 1/4] configfs: increase the item name length Bartosz Golaszewski
2020-11-30 16:47 ` [PATCH v2 2/4] configfs: use BIT() for internal flags Bartosz Golaszewski
2020-12-01 11:22 ` Christoph Hellwig [this message]
2020-12-01 14:08 ` Bartosz Golaszewski
2020-11-30 16:47 ` [PATCH v2 3/4] configfs: implement committable items Bartosz Golaszewski
2020-12-01 11:26 ` Christoph Hellwig
2020-12-01 14:06 ` Bartosz Golaszewski
2020-11-30 16:47 ` [PATCH v2 4/4] samples: configfs: add a committable group Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201112215.GA31985@lst.de \
--to=hch@lst.de \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).