From: Borislav Petkov <bp@alien8.de>
To: wangrongwei <rongwei.wang@linux.alibaba.com>
Cc: catalin.marinas@arm.com, Will Deacon <will@kernel.org>,
bjorn.andersson@linaro.org, shawnguo@kernel.org,
vkoul@kernel.org, geert+renesas@glider.be, Anson.Huang@nxp.com,
michael@walle.cc, krzk@kernel.org, olof@lixom.net,
vincenzo.frascino@arm.com, ardb@kernel.org, masahiroy@kernel.org,
gshan@redhat.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] arm64:msr: Add MSR driver
Date: Tue, 1 Dec 2020 12:26:47 +0100 [thread overview]
Message-ID: <20201201112647.GA22927@zn.tnic> (raw)
In-Reply-To: <8724DF91-5BF0-4265-8091-F9E0C7DC2F1A@linux.alibaba.com>
On Tue, Dec 01, 2020 at 11:44:52AM +0800, wangrongwei wrote:
> Indeed, I have read the commit message, and it seems that writes data
> to a system register may cause many problems. Actually, we have taken
> this into account. In the current version, we have separated the read
> and write functions to the system registers into two commands,
There's rdmsr and wrmsr in msr-tools on x86 too.
> In providing the WRASR function, we consider that users should bear
> the consequences of rewriting registers during the debugging phase. In
> fact, most of the time we rarely use WRASR, and only use it when we
> are very confident.
As I said, there should never never ever be a tool which allows writing
of registers from userspace. If I could go back in time, I'd stop this
on x86 but it is too late now. Not for ARM though.
Also, do you see how all the people who replied to your mail, put the
text under the quoted text. Do that too, pls, from now on, and refrain
from top-posting.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-12-01 11:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 17:48 [PATCH 0/3] arm64:msr: Add MSR driver Rongwei Wang
2020-11-30 17:48 ` [PATCH 1/3] arm64:insn: Export symbols for MSR ARM driver Rongwei Wang
2020-11-30 17:48 ` [PATCH 2/3] arm64:msr: Introduce " Rongwei Wang
2020-11-30 17:48 ` [PATCH 3/3] arm64:msr: Enable " Rongwei Wang
2020-11-30 17:57 ` [PATCH 0/3] arm64:msr: Add MSR driver Will Deacon
2020-12-01 2:55 ` wangrongwei
2020-12-01 5:44 ` wangrongwei
2020-11-30 18:05 ` Marc Zyngier
2020-11-30 18:20 ` Randy Dunlap
2020-12-01 3:09 ` wangrongwei
2020-12-01 8:12 ` Marc Zyngier
2020-12-01 14:25 ` wangrongwei
2020-12-01 15:37 ` Marc Zyngier
2020-12-03 5:45 ` Rongwei Wang
2020-12-03 8:35 ` Marc Zyngier
2020-12-03 11:25 ` Rongwei Wang
2020-12-03 11:45 ` Marc Zyngier
2020-12-03 12:22 ` Rongwei Wang
2020-12-03 11:50 ` Mark Rutland
2020-11-30 19:03 ` Borislav Petkov
2020-12-01 3:44 ` wangrongwei
2020-12-01 11:26 ` Borislav Petkov [this message]
2020-12-01 14:33 ` wangrongwei
2020-12-01 14:54 ` Borislav Petkov
2020-12-01 15:17 ` Rongwei Wang
2020-12-01 15:25 ` Borislav Petkov
2020-12-03 2:09 ` Rongwei Wang
2020-12-01 15:26 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201112647.GA22927@zn.tnic \
--to=bp@alien8.de \
--cc=Anson.Huang@nxp.com \
--cc=ardb@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=geert+renesas@glider.be \
--cc=gshan@redhat.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michael@walle.cc \
--cc=olof@lixom.net \
--cc=rongwei.wang@linux.alibaba.com \
--cc=shawnguo@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).