From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD33C64E7A for ; Tue, 1 Dec 2020 18:37:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 377E721741 for ; Tue, 1 Dec 2020 18:37:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Oq6aB190" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392274AbgLAShI (ORCPT ); Tue, 1 Dec 2020 13:37:08 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:45160 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392246AbgLAShH (ORCPT ); Tue, 1 Dec 2020 13:37:07 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4AE09DBD; Tue, 1 Dec 2020 19:36:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1606847784; bh=k5QyTVWA4Jc+ywHyi2x/6LgWGDBVIjOrvUWrw4fdzDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Oq6aB190ZbolqktbLd2lQtY1IEs2kNdnSPqvEx6/o+BFEPDJGW3O1QZBl0nWS+FOm 3nkHIY29uUf9Nyew9WsjI9dNwpMWKIIkyYDb0FKoH1saZb62605kjEryMSE8nnO5SM 5/NpWYRHvvnurHE4YP70bNNFGmcQ7oTO0FNzPXD0= Date: Tue, 1 Dec 2020 20:36:16 +0200 From: Laurent Pinchart To: Andy Shevchenko Cc: Dan Scally , Jean-Michel Hautbois , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, mika.westerberg@linux.intel.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, wsa@kernel.org, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, laurent.pinchart+renesas@ideasonboard.com, jorhand@linux.microsoft.com, kitakar@gmail.com, heikki.krogerus@linux.intel.com Subject: Re: [PATCH 18/18] ipu3: Add driver for dummy INT3472 ACPI device Message-ID: <20201201183616.GD3085@pendragon.ideasonboard.com> References: <20201130133129.1024662-1-djrscally@gmail.com> <20201130133129.1024662-19-djrscally@gmail.com> <20201201183139.GH4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201201183139.GH4077@smile.fi.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Tue, Dec 01, 2020 at 08:31:39PM +0200, Andy Shevchenko wrote: > On Mon, Nov 30, 2020 at 11:20:55PM +0000, Dan Scally wrote: > > On 30/11/2020 16:17, Jean-Michel Hautbois wrote: > > ... > > > but the ACPI table doesn't define an I2CSerialBusV2 for it. Instead it's > > rolled under the sensor's entry, there's a second entry in _CRS for the > > sensor that matches the address of the new device: > > > > > > Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings > > { > > Name (SBUF, ResourceTemplate () > > { > > I2cSerialBusV2 (0x0036, ControllerInitiated, 0x00061A80, > > AddressingMode7Bit, "\\_SB.PCI0.I2C2", > > 0x00, ResourceConsumer, , Exclusive, > > ) > > I2cSerialBusV2 (0x000C, ControllerInitiated, 0x00061A80, > > AddressingMode7Bit, "\\_SB.PCI0.I2C2", > > 0x00, ResourceConsumer, , Exclusive, > > ) > > }) > > Return (SBUF) /* \_SB_.PCI0.CAM0._CRS.SBUF */ > > } > > > > So that's another thing we need to work on. At the moment it doesn't > > exist as far as the kernel is concerned. > > Maybe something along i2c-multi-instantiate can help here (maybe not). It's two different devices really. That's also one of the "annoyances" related to this platform. The INT* HID for the camera sensor actually refers to a camera module, with VCM, EEPROM, ... On Chrome OS devices, the same HID refers to the camera sensor only. *sigh* :-( > P.S. Dan, can you drop unrelated text when replying? I find a full quote actually useful, as it saves me from having to dig up original e-mails to read missing parts :-) It's a matter of preference I suppose. -- Regards, Laurent Pinchart