From: Maxime Ripard <maxime@cerno.tech>
To: "André Przywara" <andre.przywara@arm.com>
Cc: Rob Herring <robh@kernel.org>,
Frank Lee <frank@allwinnertech.com>,
devicetree@vger.kernel.org, tiny.windzz@gmail.com,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org,
Jernej Skrabec <jernej.skrabec@siol.net>
Subject: Re: [RESEND PATCH 12/19] dt-bindings: Add bindings for USB phy on Allwinner A100
Date: Tue, 1 Dec 2020 19:44:33 +0100 [thread overview]
Message-ID: <20201201184433.s4i3gd3tqu4jtpvv@gilmour> (raw)
In-Reply-To: <a52f7350-b7b5-290c-c43a-020fecd58874@arm.com>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
On Sat, Nov 28, 2020 at 08:18:16PM +0000, André Przywara wrote:
> On 11/11/2020 22:50, Rob Herring wrote:
>
> Hi,
>
> > On Tue, Nov 10, 2020 at 02:39:42PM +0800, Frank Lee wrote:
> >> From: Yangtao Li <frank@allwinnertech.com>
> >>
> >> Add a device tree binding for the A100's USB PHY.
>
> Not your fault, Yangto, but why do we actually have a separate binding
> document per SoC, when the differences between the PHYs are so minimal
> that we get away with some flags in the compatible match, in one driver
> file?
They are similar, but there's massive differences between them still
(like which regulators are supposed to be there, or the register names).
So putting them all in the same file just ended up in an unmaintainable
mess.
> For a start this file is basically identical to the A64 one (apart from
> the example), so can you just add the A100 compatible string to that
> one, instead?
But yeah, if two are identical they should be merged
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-12-01 18:45 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 6:20 [RESEND PATCH 00/19] Second step support for A100 Frank Lee
2020-11-10 6:22 ` [RESEND PATCH 01/19] pinctrl: sunxi: fix irq bank map for the Allwinner A100 pin controller Frank Lee
2020-11-24 8:40 ` Linus Walleij
2020-11-10 6:23 ` [RESEND PATCH 02/19] pinctrl: sunxi: Mark the irq bank not found in sunxi_pinctrl_irq_handler() with WARN_ON Frank Lee
2020-11-24 8:41 ` Linus Walleij
2020-11-10 6:24 ` [RESEND PATCH 03/19] pinctrl: sunxi: Always call chained_irq_{enter, exit} in sunxi_pinctrl_irq_handler Frank Lee
2020-11-24 8:41 ` Linus Walleij
2020-11-10 6:26 ` [RESEND PATCH 04/19] dt-bindings: dma: allwinner,sun50i-a64-dma: Add A100 compatible Frank Lee
2020-11-11 22:46 ` Rob Herring
2020-11-18 11:01 ` Vinod Koul
2020-11-10 6:28 ` [RESEND PATCH 05/19] dmaengine: sun6i: Add support for A100 DMA Frank Lee
2020-11-18 10:59 ` Vinod Koul
2020-11-28 20:31 ` André Przywara
2020-11-10 6:29 ` [RESEND PATCH 06/19] arm64: allwinner: a100: Add device node for DMA controller Frank Lee
2020-11-28 20:34 ` André Przywara
2020-11-10 6:31 ` [RESEND PATCH 07/19] arm64: dts: allwinner: A100: Add PMU mode Frank Lee
2020-11-28 20:47 ` André Przywara
2020-11-10 6:32 ` [RESEND PATCH 08/19] phy: sun4i-usb: remove enable_pmu_unk1 from sun50i_h6_cfg Frank Lee
2020-11-19 6:19 ` Vinod Koul
2020-11-10 6:35 ` [RESEND PATCH 09/19] phy: allwinner: Convert to devm_platform_ioremap_* API Frank Lee
2020-11-19 6:20 ` Vinod Koul
2020-11-10 6:36 ` [RESEND PATCH 10/19] dt-bindings: watchdog: sun4i: Add A100 compatible Frank Lee
2020-11-11 22:46 ` Rob Herring
2020-11-10 6:38 ` [RESEND PATCH 11/19] arm64: dts: allwinner: a100: add watchdog node Frank Lee
2020-11-28 20:20 ` André Przywara
2020-11-10 6:39 ` [RESEND PATCH 12/19] dt-bindings: Add bindings for USB phy on Allwinner A100 Frank Lee
2020-11-11 22:50 ` Rob Herring
2020-11-28 20:18 ` André Przywara
2020-12-01 18:44 ` Maxime Ripard [this message]
2020-11-10 6:40 ` [RESEND PATCH 13/19] phy: sun4i-usb: add support for A100 USB PHY Frank Lee
2020-11-28 19:39 ` André Przywara
2020-12-07 1:18 ` André Przywara
2020-11-10 6:41 ` [RESEND PATCH 14/19] arm64: dts: allwinner: a100: add usb related nodes Frank Lee
2020-11-10 6:43 ` [RESEND PATCH 15/19] arm64: allwinner: A100: enable EHCI, OHCI and USB PHY nodes in Perf1 Frank Lee
2020-11-10 6:45 ` [RESEND PATCH 16/19] dt-bindings: mmc: sunxi: Add A100 compatibles Frank Lee
2020-11-11 22:51 ` Rob Herring
2020-11-10 6:46 ` [RESEND PATCH 17/19] mmc: sunxi: add support for A100 mmc controller Frank Lee
2020-11-28 19:56 ` André Przywara
2020-11-29 1:38 ` André Przywara
2020-11-10 6:48 ` [RESEND PATCH 18/19] arm64: allwinner: a100: Add MMC related nodes Frank Lee
2020-11-28 20:07 ` André Przywara
2020-11-10 6:49 ` [RESEND PATCH 19/19] arm64: dts: allwinner: a100: perf1: Add eMMC and MMC node Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201184433.s4i3gd3tqu4jtpvv@gilmour \
--to=maxime@cerno.tech \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frank@allwinnertech.com \
--cc=jernej.skrabec@siol.net \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tiny.windzz@gmail.com \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).