From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0804C64E8A for ; Wed, 2 Dec 2020 09:44:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 758B922202 for ; Wed, 2 Dec 2020 09:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388270AbgLBJnw (ORCPT ); Wed, 2 Dec 2020 04:43:52 -0500 Received: from mga18.intel.com ([134.134.136.126]:51489 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388226AbgLBJnv (ORCPT ); Wed, 2 Dec 2020 04:43:51 -0500 IronPort-SDR: 6VtFn2QjPXAA5Hzr+ubgtWbZqgmgvaFSMUM5AmL9UzcuoI6I5FOHrcFqljQIUwGW70QUjcxWKs f1RIIl8TKv7g== X-IronPort-AV: E=McAfee;i="6000,8403,9822"; a="160758355" X-IronPort-AV: E=Sophos;i="5.78,386,1599548400"; d="scan'208";a="160758355" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 01:43:08 -0800 IronPort-SDR: PUay8JE6CyCYGQ6OEqTbAITVx1PocfHXw7Y+ZE7N83/IJBWZY2mgXSVQMEs3J47Ae/ZqgTCjZT PE1macl5QL+Q== X-IronPort-AV: E=Sophos;i="5.78,386,1599548400"; d="scan'208";a="316040233" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 01:43:06 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kkOgC-00BToQ-4M; Wed, 02 Dec 2020 11:44:08 +0200 Date: Wed, 2 Dec 2020 11:44:08 +0200 From: Andy Shevchenko To: Arpitha Raghunandan <98.arpi@gmail.com> Cc: Brendan Higgins , Shuah Khan , kunit-dev@googlegroups.com, "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v3] lib: Convert test_hexdump.c to KUnit Message-ID: <20201202094408.GW4077@smile.fi.intel.com> References: <20201201071632.68471-1-98.arpi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 02, 2020 at 09:51:19AM +0530, Arpitha Raghunandan wrote: > On 01/12/20 4:36 pm, Andy Shevchenko wrote: > > On Tue, Dec 1, 2020 at 9:21 AM Arpitha Raghunandan <98.arpi@gmail.com> wrote: ... > >> I ran both the original and converted tests as is to produce the > >> output for success of the test in the two cases. I also ran these > >> tests with a small modification to show the difference in the output > >> for failure of the test in both cases. The modification I made is: > >> static const char * const test_data_4_le[] __initconst = { > >> - "7bdb32be", "b293180a", "24c4ba70", "9b34837d", > >> + "7bdb32be", "b293180a", "24c4ba70", "9b3483d", > >> > >> The difference in outputs can be seen here: > >> https://gist.github.com/arpi-r/38f53a3c65692bf684a6bf3453884b6e > > > > Looks pretty much good, what I'm sad to see is the absence of the test > > statistics. Any ideas if we can get it back? > > > > I could again include variable total_tests as was in the original test. > Would that be fine? What I;m talking about is the output. How it will be implemented (using the same variable or differently) is up to you. So the point is I want to see the statistics of success/total at the end. I think this should be done in KUNIT rather than in the individual test cases. -- With Best Regards, Andy Shevchenko