From: Jakub Kicinski <kuba@kernel.org>
To: Jarod Wilson <jarod@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ivan Vecera <ivecera@redhat.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
Thomas Davis <tadavis@lbl.gov>, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net v2] bonding: fix feature flag setting at init time
Date: Wed, 2 Dec 2020 11:22:56 -0800 [thread overview]
Message-ID: <20201202112256.59a97b9c@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> (raw)
In-Reply-To: <CAKfmpSeGEpjVxw5J=tNBYc2bZEY-z7DbQeb2TcekbqkiBe7O6g@mail.gmail.com>
On Wed, 2 Dec 2020 14:03:53 -0500 Jarod Wilson wrote:
> On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote:
> > > + if (bond->dev->reg_state != NETREG_REGISTERED)
> > > + goto noreg;
> > > +
> > > if (newval->value == BOND_MODE_ACTIVEBACKUP)
> > > bond->dev->wanted_features |= BOND_XFRM_FEATURES;
> > > else
> > > bond->dev->wanted_features &= ~BOND_XFRM_FEATURES;
> > > - netdev_change_features(bond->dev);
> > > + netdev_update_features(bond->dev);
> > > +noreg:
> >
> > Why the goto?
>
> Seemed cleaner to prevent an extra level of indentation of the code
> following the goto and before the label, but I'm not that attached to
> it if it's not wanted for coding style reasons.
Yes, please don't use gotos where a normal if statement is sufficient.
If you must avoid the indentation move the code to a helper.
Also - this patch did not apply to net, please make sure you're
developing on the correct base.
next prev parent reply other threads:[~2020-12-02 19:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 3:17 [PATCH net] bonding: fix feature flag setting at init time Jarod Wilson
2020-11-23 8:19 ` Ivan Vecera
2020-11-23 15:32 ` kernel test robot
2020-12-02 17:30 ` [PATCH net v2] " Jarod Wilson
2020-12-02 17:41 ` Ivan Vecera
2020-12-02 17:53 ` Jakub Kicinski
2020-12-02 19:03 ` Jarod Wilson
2020-12-02 19:22 ` Jakub Kicinski [this message]
2020-12-02 19:39 ` Jarod Wilson
2020-12-02 17:55 ` Jay Vosburgh
2020-12-02 19:23 ` Jarod Wilson
2020-12-02 20:17 ` Jay Vosburgh
2020-12-02 20:54 ` Jarod Wilson
2020-12-03 0:43 ` [PATCH net v3] " Jarod Wilson
2020-12-03 16:45 ` Jakub Kicinski
2020-12-05 16:13 ` Jarod Wilson
2020-12-03 16:50 ` Jakub Kicinski
2020-12-04 3:14 ` Jarod Wilson
2020-12-04 15:45 ` Jakub Kicinski
2020-12-05 17:22 ` [PATCH net v4] " Jarod Wilson
2020-12-08 19:27 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202112256.59a97b9c@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com \
--to=kuba@kernel.org \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=j.vosburgh@gmail.com \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tadavis@lbl.gov \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).