From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Li Yang <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>,
linux-amarula@amarulasolutions.com
Subject: Re: [PATCH 05/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit
Date: Wed, 2 Dec 2020 19:38:09 +0200 [thread overview]
Message-ID: <20201202173809.GE3490@kozik-lap> (raw)
In-Reply-To: <20201202121241.109952-6-jagan@amarulasolutions.com>
On Wed, Dec 02, 2020 at 05:42:36PM +0530, Jagan Teki wrote:
> i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam.
>
> EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive
> Evaluation Board from Engicam.
>
> i.Core MX8M Mini needs to mount on top of this Evaluation board for
> creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit.
>
> Add support for it.
>
> Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../imx8mm-engicam-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++
> 2 files changed, 22 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-edimm2.2.dts
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 6f0777ee6cd6..4369d783dade 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
>
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-edimm2.2.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-edimm2.2.dts b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-edimm2.2.dts
> new file mode 100644
> index 000000000000..a8afc0998fcd
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-edimm2.2.dts
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2019 NXP
> + * Copyright (c) 2019 Engicam srl
> + * Copyright (c) 2020 Amarula Solutions(India)
> + */
> +
> +/dts-v1/;
> +#include "imx8mm.dtsi"
imx8mm should be included in the SoM, not here. It's really wrong that
you override some nodes in imx8mm-engicam-icore-mx8mm.dtsi which do not
exist there (not included).
> +#include "imx8mm-engicam-edimm2.2.dtsi"
> +#include "imx8mm-engicam-icore-mx8mm.dtsi"
> +
> +/ {
> + model = "Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit";
> + compatible = "engicam,icore-mx8mm-edimm2.2", "engicam,icore-mx8mm",
This won't validate against your own bindings. Please fix either the DTS
or the bindings. Then run dtbs_check.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-12-02 17:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 12:12 [PATCH 00/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini Jagan Teki
2020-12-02 12:12 ` [PATCH 01/10] arm64: defconfig: Enable REGULATOR_PF8X00 Jagan Teki
2020-12-02 17:22 ` Krzysztof Kozlowski
2020-12-02 19:21 ` Jagan Teki
2020-12-02 12:12 ` [PATCH 02/10] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Jagan Teki
2020-12-02 12:12 ` [PATCH 03/10] arm64: dts: imx: Add Engicam " Jagan Teki
2020-12-02 17:26 ` Krzysztof Kozlowski
2020-12-02 12:12 ` [PATCH 04/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SOM Jagan Teki
2020-12-02 17:34 ` Krzysztof Kozlowski
2020-12-02 19:30 ` Jagan Teki
2020-12-02 19:37 ` Krzysztof Kozlowski
2020-12-02 19:40 ` Jagan Teki
2020-12-02 12:12 ` [PATCH 05/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Jagan Teki
2020-12-02 17:38 ` Krzysztof Kozlowski [this message]
2020-12-02 12:12 ` [PATCH 06/10] arm64: dts: imx: Add Engicam C.TOUCH 2.0 Jagan Teki
2020-12-02 17:39 ` Krzysztof Kozlowski
2020-12-02 12:12 ` [PATCH 07/10] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini " Jagan Teki
2020-12-02 17:24 ` Krzysztof Kozlowski
2020-12-02 12:12 ` [PATCH 08/10] arm64: dts: imx8mm: " Jagan Teki
2020-12-02 17:45 ` Krzysztof Kozlowski
2020-12-02 17:53 ` Fabio Estevam
2020-12-02 19:20 ` Jagan Teki
2020-12-02 19:25 ` Krzysztof Kozlowski
2020-12-02 19:36 ` Jagan Teki
2020-12-02 12:12 ` [PATCH 09/10] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 10.1" OF Jagan Teki
2020-12-02 17:40 ` Krzysztof Kozlowski
2020-12-02 12:12 ` [PATCH 10/10] arm64: dts: imx8mm: " Jagan Teki
2020-12-02 17:49 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202173809.GE3490@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=leoyang.li@nxp.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matteo.lisi@engicam.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).