From: Andi Kleen <ak@linux.intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Ian Rogers <irogers@google.com>
Subject: Re: [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event
Date: Wed, 2 Dec 2020 11:28:28 -0800 [thread overview]
Message-ID: <20201202192828.GG1363814@tassilo.jf.intel.com> (raw)
In-Reply-To: <20201202150205.35750-1-namhyung@kernel.org>
> + prev_cgrp = task_css_check(prev, perf_event_cgrp_id, 1)->cgroup;
> + next_cgrp = task_css_check(next, perf_event_cgrp_id, 1)->cgroup;
> +
> + if (prev_cgrp != next_cgrp)
> + perf_sw_event_sched(PERF_COUNT_SW_CGROUP_SWITCHES, 1, 0);
Seems to be the perf cgroup only, not all cgroups.
That's a big difference and needs to be documented properly.
Probably would make sense to have two events for both, one for
all cgroups and one for perf only.
-Andi
next prev parent reply other threads:[~2020-12-02 19:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 15:02 [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event Namhyung Kim
2020-12-02 15:02 ` [RFC 2/2] perf tools: Add 'cgroup-switches' software event Namhyung Kim
2020-12-02 16:19 ` [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event Peter Zijlstra
2020-12-03 1:05 ` Namhyung Kim
2020-12-03 2:10 ` Namhyung Kim
2020-12-03 7:45 ` Peter Zijlstra
2020-12-04 7:25 ` Namhyung Kim
2020-12-02 19:28 ` Andi Kleen [this message]
2020-12-02 19:47 ` Stephane Eranian
2020-12-02 22:42 ` Andi Kleen
2020-12-02 23:40 ` Stephane Eranian
2020-12-03 1:03 ` Namhyung Kim
2020-12-03 12:20 ` Peter Zijlstra
2020-12-04 7:27 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202192828.GG1363814@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).