From: Mark Brown <broonie@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-spi <linux-spi@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"Bogdan, Dragos" <Dragos.Bogdan@analog.com>
Subject: Re: [PATCH v3 2/3] spi: Add SPI_NO_TX/RX support
Date: Thu, 3 Dec 2020 09:47:39 +0000 [thread overview]
Message-ID: <20201203094739.GB4700@sirena.org.uk> (raw)
In-Reply-To: <CY4PR03MB29661063937AD783F6B2A010F9F20@CY4PR03MB2966.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]
On Thu, Dec 03, 2020 at 08:20:57AM +0000, Ardelean, Alexandru wrote:
> > > > @@ -43,5 +43,7 @@
> > > > #define SPI_TX_OCTAL 0x2000 /* transmit with 8 wires */
> > > > #define SPI_RX_OCTAL 0x4000 /* receive with 8 wires */
> > > > #define SPI_3WIRE_HIZ 0x8000 /* high impedance turnaround
> > */
> > > > +#define SPI_NO_TX 0x10000 /* no transmit wire */
> > > > +#define SPI_NO_RX 0x20000 /* no receive wire */
> > > Is it really material for uAPI?
> > > Perhaps we may have something like
> > > SPI_MODE_USER_MASK in uAPI and
> > > in internal headers
> Hmm, in a way this could make sense for some SPIDEVs as well, to set these flags and get an error if they try to TX with the NO_TX flag set.
> Not really sure about this.
> Initially I mechanically added these here as an inertia to the previous patch which is just unifying the headers.
> Any other opinions? Thoughts?
> Mark?
spidev is hacky at the best of times... It *is* probably better to only
have the usefully mainpulable modes exposed in uapi and then define the
rest internally though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-03 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 13:08 [PATCH v3 1/3] spi: uapi: unify SPI modes into a single spi.h header Alexandru Ardelean
2020-11-27 13:08 ` [PATCH v3 2/3] spi: Add SPI_NO_TX/RX support Alexandru Ardelean
2020-11-27 14:22 ` Andy Shevchenko
2020-11-27 14:23 ` Andy Shevchenko
2020-12-03 8:20 ` Ardelean, Alexandru
2020-12-03 9:47 ` Mark Brown [this message]
2020-11-27 13:08 ` [PATCH v3 3/3] spi: dt-bindings: document zero value for spi-{rx,tx}-bus-width properties Alexandru Ardelean
2020-11-27 14:26 ` Andy Shevchenko
2020-12-03 13:35 ` Ardelean, Alexandru
2020-11-27 14:12 ` [PATCH v3 1/3] spi: uapi: unify SPI modes into a single spi.h header Andy Shevchenko
2020-12-03 8:15 ` Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203094739.GB4700@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Dragos.Bogdan@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).