From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A31C83016 for ; Thu, 3 Dec 2020 11:41:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC51322201 for ; Thu, 3 Dec 2020 11:41:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388774AbgLCLl3 (ORCPT ); Thu, 3 Dec 2020 06:41:29 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:34472 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388687AbgLCLl2 (ORCPT ); Thu, 3 Dec 2020 06:41:28 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 65C661C0B9E; Thu, 3 Dec 2020 12:40:44 +0100 (CET) Date: Thu, 3 Dec 2020 12:40:44 +0100 From: Pavel Machek To: Gene Chen Cc: Jacek Anaszewski , Rob Herring , Matthias Brugger , Dan Murphy , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Gene Chen , Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Subject: Re: [PATCH v11 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions Message-ID: <20201203114044.GA9061@duo.ucw.cz> References: <1606906011-25633-1-git-send-email-gene.chen.richtek@gmail.com> <1606906011-25633-4-git-send-email-gene.chen.richtek@gmail.com> <20201202122329.GA30929@duo.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > +++ b/include/dt-bindings/leds/common.h > > > @@ -78,6 +78,7 @@ > > > #define LED_FUNCTION_INDICATOR "indicator" > > > #define LED_FUNCTION_LAN "lan" > > > #define LED_FUNCTION_MAIL "mail" > > > +#define LED_FUNCTION_MOONLIGHT "moonlight" > > > > There's "torch" function that should be used for this. I guess comment > > should be added with explanation what exactly that is and how should > > the LED be named. > > >=20 > According to mail, 11/25 "Re: [PATCH v7 2/5] dt-bindings: leds: Add > LED_COLOR_ID_MOONLIGHT definitions", > The Moonlight LED is LED which maximum current more than torch, but > less than flash. Such as front camera fill light. > I think our channel is moonlight, not torch. > I will add this description to comment. > We can't exactly define moonlight current level, because every vendor > has their own specification. So... what is the timelimit on moonlight? But if it is used for camera illumination, I believe it should be simply called flash. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX8jOvAAKCRAw5/Bqldv6 8pj3AJ9cRVAbTOCXxcUiV3mbTJXFFTKK3QCgpfgXoggeGNEUdtl5msUvdmWnkSA= =gXOZ -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--