linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] Documentation: Coccinelle: Improve command example for debugging patches
@ 2020-11-26  7:57 Sumera Priyadarsini
  2020-12-03 22:45 ` Jonathan Corbet
  0 siblings, 1 reply; 2+ messages in thread
From: Sumera Priyadarsini @ 2020-11-26  7:57 UTC (permalink / raw)
  To: Julia.Lawall
  Cc: corbet, cocci, linux-doc, linux-kernel, michal.lkml,
	nicolas.palix, Gilles.Muller

Modify Coccinelle documentation to clarify usage of make command to
run coccicheck on a folder.

Changes in v2:
- Give example of folder instead of file
- Add note

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
 Documentation/dev-tools/coccinelle.rst | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst
index 74c5e6aeeff5..9c454de5a7f7 100644
--- a/Documentation/dev-tools/coccinelle.rst
+++ b/Documentation/dev-tools/coccinelle.rst
@@ -224,14 +224,21 @@ you may want to use::
 
     rm -f err.log
     export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
-    make coccicheck DEBUG_FILE="err.log" MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
+    make coccicheck DEBUG_FILE="err.log" MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd
 
 err.log will now have the profiling information, while stdout will
 provide some progress information as Coccinelle moves forward with
 work.
 
+NOTE:
+
 DEBUG_FILE support is only supported when using coccinelle >= 1.0.2.
 
+Currently, DEBUG_FILE support is only available to check folders, and
+not single files. This is because checking a single file requires spatch
+to be called twice leading to DEBUG_FILE being set both times to the same value,
+giving rise to an error.
+
 .cocciconfig support
 --------------------
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] Documentation: Coccinelle: Improve command example for debugging patches
  2020-11-26  7:57 [PATCH v2] Documentation: Coccinelle: Improve command example for debugging patches Sumera Priyadarsini
@ 2020-12-03 22:45 ` Jonathan Corbet
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2020-12-03 22:45 UTC (permalink / raw)
  To: Sumera Priyadarsini
  Cc: Julia.Lawall, cocci, linux-doc, linux-kernel, michal.lkml,
	nicolas.palix, Gilles.Muller

On Thu, 26 Nov 2020 13:27:30 +0530
Sumera Priyadarsini <sylphrenadin@gmail.com> wrote:

> Modify Coccinelle documentation to clarify usage of make command to
> run coccicheck on a folder.
> 
> Changes in v2:
> - Give example of folder instead of file
> - Add note
> 
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
> ---
>  Documentation/dev-tools/coccinelle.rst | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-03 22:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26  7:57 [PATCH v2] Documentation: Coccinelle: Improve command example for debugging patches Sumera Priyadarsini
2020-12-03 22:45 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).