* [PATCH bpf-next] tools/resolve_btfids: Fix some error messages
@ 2020-12-03 10:22 Brendan Jackman
2020-12-03 15:10 ` Jiri Olsa
2020-12-03 18:41 ` Alexei Starovoitov
0 siblings, 2 replies; 3+ messages in thread
From: Brendan Jackman @ 2020-12-03 10:22 UTC (permalink / raw)
To: bpf
Cc: Alexei Starovoitov, Daniel Borkmann, KP Singh, Florent Revest,
linux-kernel, Jiri Olsa, Brendan Jackman
Add missing newlines and fix polarity of strerror argument.
Signed-off-by: Brendan Jackman <jackmanb@google.com>
---
tools/bpf/resolve_btfids/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
index dfa540d8a02d..e3ea569ee125 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -454,7 +454,7 @@ static int symbols_collect(struct object *obj)
return -ENOMEM;
if (id->addr_cnt >= ADDR_CNT) {
- pr_err("FAILED symbol %s crossed the number of allowed lists",
+ pr_err("FAILED symbol %s crossed the number of allowed lists\n",
id->name);
return -1;
}
@@ -477,8 +477,8 @@ static int symbols_resolve(struct object *obj)
btf = btf__parse(obj->btf ?: obj->path, NULL);
err = libbpf_get_error(btf);
if (err) {
- pr_err("FAILED: load BTF from %s: %s",
- obj->path, strerror(err));
+ pr_err("FAILED: load BTF from %s: %s\n",
+ obj->path, strerror(-err));
return -1;
}
base-commit: 97306be45fbe7a02461c3c2a57e666cf662b1aaf
--
2.29.2.454.gaff20da3a2-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] tools/resolve_btfids: Fix some error messages
2020-12-03 10:22 [PATCH bpf-next] tools/resolve_btfids: Fix some error messages Brendan Jackman
@ 2020-12-03 15:10 ` Jiri Olsa
2020-12-03 18:41 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Olsa @ 2020-12-03 15:10 UTC (permalink / raw)
To: Brendan Jackman
Cc: bpf, Alexei Starovoitov, Daniel Borkmann, KP Singh,
Florent Revest, linux-kernel, Jiri Olsa
On Thu, Dec 03, 2020 at 10:22:34AM +0000, Brendan Jackman wrote:
> Add missing newlines and fix polarity of strerror argument.
>
> Signed-off-by: Brendan Jackman <jackmanb@google.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
> tools/bpf/resolve_btfids/main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
> index dfa540d8a02d..e3ea569ee125 100644
> --- a/tools/bpf/resolve_btfids/main.c
> +++ b/tools/bpf/resolve_btfids/main.c
> @@ -454,7 +454,7 @@ static int symbols_collect(struct object *obj)
> return -ENOMEM;
>
> if (id->addr_cnt >= ADDR_CNT) {
> - pr_err("FAILED symbol %s crossed the number of allowed lists",
> + pr_err("FAILED symbol %s crossed the number of allowed lists\n",
> id->name);
> return -1;
> }
> @@ -477,8 +477,8 @@ static int symbols_resolve(struct object *obj)
> btf = btf__parse(obj->btf ?: obj->path, NULL);
> err = libbpf_get_error(btf);
> if (err) {
> - pr_err("FAILED: load BTF from %s: %s",
> - obj->path, strerror(err));
> + pr_err("FAILED: load BTF from %s: %s\n",
> + obj->path, strerror(-err));
> return -1;
> }
>
>
> base-commit: 97306be45fbe7a02461c3c2a57e666cf662b1aaf
> --
> 2.29.2.454.gaff20da3a2-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] tools/resolve_btfids: Fix some error messages
2020-12-03 10:22 [PATCH bpf-next] tools/resolve_btfids: Fix some error messages Brendan Jackman
2020-12-03 15:10 ` Jiri Olsa
@ 2020-12-03 18:41 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2020-12-03 18:41 UTC (permalink / raw)
To: Brendan Jackman
Cc: bpf, Alexei Starovoitov, Daniel Borkmann, KP Singh,
Florent Revest, linux-kernel, Jiri Olsa
On Thu, Dec 03, 2020 at 10:22:34AM +0000, Brendan Jackman wrote:
> Add missing newlines and fix polarity of strerror argument.
>
> Signed-off-by: Brendan Jackman <jackmanb@google.com>
Applied, Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-03 18:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 10:22 [PATCH bpf-next] tools/resolve_btfids: Fix some error messages Brendan Jackman
2020-12-03 15:10 ` Jiri Olsa
2020-12-03 18:41 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).