From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40FBAC4361B for ; Thu, 3 Dec 2020 22:11:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECDC72220F for ; Thu, 3 Dec 2020 22:11:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729226AbgLCWLN (ORCPT ); Thu, 3 Dec 2020 17:11:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727315AbgLCWLM (ORCPT ); Thu, 3 Dec 2020 17:11:12 -0500 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18287C061A4F for ; Thu, 3 Dec 2020 14:10:32 -0800 (PST) Received: by mail-pf1-x44a.google.com with SMTP id v2so2290174pfi.11 for ; Thu, 03 Dec 2020 14:10:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=nhqHUHB81FfDRC5Dmlf7b4++uLFouwQ+DbxloM/znL0=; b=lET6kU1tz5H9yxZDEMqtRCf0/SXFWhxbeju2hpUgYSr+oZtUv3MSgLpla0i95J2qJI PSPfEfKEw9TU9+Imn0OgG4helXYWBDiPTs1+ljRX3netRIyP+hnUHagTew6Ng0EU+Htj jzS9VjM74iL8Kc0sS1och2P1Fv99LwUIEqkKy4Ek9Z7laEnGeQZN5usI12k+ZtIt/iIA sAdWUr1GwY3xpT5d6ZAGX00/Pt4s9aY5tIqhW/x2OGKt1cUTl3qydSk/XRoM3oOMDu+u f/A+sDLNUnjiPkT85OxmChzqP1tdwTfbCKa2Q6Hy9+6DRnsngLpPwVgH+Sz78C40hzIh kHrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=nhqHUHB81FfDRC5Dmlf7b4++uLFouwQ+DbxloM/znL0=; b=uYvjbUsK5t9sigromayhVIIeNX35djVdX1PGACCQ+0wLwvtF8gXx90aBBoBoOz+yGH jprzVXElWRBiWrmB2JzZwGOTi2oD+f0TgPJrztfPXXBnuCTYtL0HcNEeIyMYk3zsOfKa RkqkYAKUa8g8taksVFHC81oyKCzA3VOqeXmquVnvEwLrrLUvxqAilCW3B2CxpexDY4pQ ik9t/hB+pfaGOCEDHhMcH2Xs0P4W9LkulBKBH2OI+qV+UgBdpQPmhCOMbezkg8IgalSl ecKY9iPgA1K5FYNJlwYdSmU9xIHWIb1C9QpHoAYu/+7TtaAtjHYZ28UrgrF/Kprn4vgc mYhA== X-Gm-Message-State: AOAM5316ZPL7fC/JRillkGRInxdczpcJXPWBSN8vcmxqxOZ2e6VKhBG3 JGbPWfR9DFcBJcnuB6LpAVYxoFJ0EQ== X-Google-Smtp-Source: ABdhPJyoDq63rkO5+ydSicpI3O4b+U4VThB8sabazPQvgaChurpclUhtXF0OEbx+DbHTiwjGGtS95ozEFg== Sender: "adelg via sendgmr" X-Received: from adelg.c.googlers.com ([fda3:e722:ac3:10:24:72f4:c0a8:a16]) (user=adelg job=sendgmr) by 2002:a17:90a:460a:: with SMTP id w10mr96452pjg.1.1607033431208; Thu, 03 Dec 2020 14:10:31 -0800 (PST) Date: Thu, 3 Dec 2020 22:10:05 +0000 Message-Id: <20201203221005.2813159-1-adelg@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.29.2.576.ga3fc446d84-goog Subject: [PATCH] selftests: propagate CC to selftest submakes From: Andrew Delgadillo To: Shuah Khan Cc: Nathan Chancellor , Nick Desaulniers , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Andrew Delgadillo Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org lib.mk defaults to gcc when CC is not set. When building selftests as part of a kernel compilation, MAKEFLAGS is cleared to allow implicit build rules to be used. This has the side-effect of clearing the CC variable, which will cause selftests to be built with gcc regardless of if we are using gcc or clang. To remedy this, propagate the CC variable when clearing makeflags to ensure the correct compiler is used. Signed-off-by: Andrew Delgadillo --- tools/testing/selftests/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index d9c283503159..a4dd6d7e8276 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -90,10 +90,12 @@ FORCE_TARGETS ?= # Clear LDFLAGS and MAKEFLAGS when implicit rules are missing. This provides # implicit rules to sub-test Makefiles which avoids build failures in test -# Makefile that don't have explicit build rules. +# Makefile that don't have explicit build rules. Since lib.mk defaults to +# using gcc for compilation when the CC variable is not set, we propagate the +# CC variable so if clang is being used, selftests will build with clang. ifeq (,$(LINK.c)) override LDFLAGS = -override MAKEFLAGS = +override MAKEFLAGS = CC=$(CC) endif # Append kselftest to KBUILD_OUTPUT and O to avoid cluttering -- 2.29.2.576.ga3fc446d84-goog