From: Mel Gorman <mgorman@suse.de>
To: Yunfeng Ye <yeyunfeng@huawei.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com,
linux-kernel@vger.kernel.org, Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>
Subject: Re: [PATCH 2/2] sched: Split the function show_schedstat()
Date: Fri, 4 Dec 2020 09:40:21 +0000 [thread overview]
Message-ID: <20201204094021.GG3306@suse.de> (raw)
In-Reply-To: <b2919179-3045-bd4b-2e0a-2f472ddb73d8@huawei.com>
On Fri, Dec 04, 2020 at 09:22:34AM +0800, Yunfeng Ye wrote:
>
>
> On 2020/12/3 17:42, Mel Gorman wrote:
> > On Thu, Dec 03, 2020 at 02:47:14PM +0800, Yunfeng Ye wrote:
> >> The schedstat include runqueue-specific stats and domain-specific stats,
> >> so split it into two functions, show_rqstat() and show_domainstat().
> >>
> >> No functional changes.
> >>
> >> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> >
> > Why?
> >
> > I could understand if there was a follow-up patch that adjusted some
> > subset or there was a difference in checking for schedstat_enabled,
> > locking or inserting new schedstat information. This can happen in the
> > general case when the end result is easier to review here it seems to be
> > just moving code around.
> >
> The rqstat and domainstat is independent state information. so I think
> split it into two individual function is clearer.
>
The comments and the names of the structures being accessesd is sufficient
to make it clear.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2020-12-04 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 6:46 [PATCH 1/2] sched: Move '\n' to the prior seq_printf in show_schedstat() Yunfeng Ye
2020-12-03 6:47 ` [PATCH 2/2] sched: Split the function show_schedstat() Yunfeng Ye
2020-12-03 9:42 ` Mel Gorman
2020-12-04 1:22 ` Yunfeng Ye
2020-12-04 9:40 ` Mel Gorman [this message]
2020-12-05 2:31 ` Yunfeng Ye
2020-12-03 9:40 ` [PATCH 1/2] sched: Move '\n' to the prior seq_printf in show_schedstat() Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204094021.GG3306@suse.de \
--to=mgorman@suse.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).