From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Joel Becker <jlbec@evilplan.org>, Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v3 0/4] configfs: implement committable items and add sample code
Date: Fri, 4 Dec 2020 11:00:35 +0100 [thread overview]
Message-ID: <20201204100039.19159-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Committable items in configfs are well defined and documented but unfortunately
so far never implemented.
The use-case we have over at the GPIO subsystem is using configfs in
conjunction with sysfs to replace our current gpio-mockup testing module
with one that will be much more flexible and will allow complete coverage
of the GPIO uAPI.
The current gpio-mockup module is controlled using module parameters which
forces the user to reload it everytime they need to change the chip
configuration or layout and makes it difficult to extend its functionality.
Testing module based on configfs would allow fine-grained control over dummy
GPIO chips but since GPIO devices must be configured before they are
instantiated, we need committable items.
This implements them and adds code examples to configfs_sample module. The
first two patches are just cosmetic.
v1 -> v2:
- fix a 'set but not used' build warning reported by kernel test robot
v2 -> v3:
- use (1UL << bit) instead of BIT() in patch 2/4
- extend configfs_dump_one() to make it print the new flags
- clear the CONFIGFS_USET_DIR bit on the live group dirent
Bartosz Golaszewski (4):
configfs: increase the item name length
configfs: use (1UL << bit) for internal flags
configfs: implement committable items
samples: configfs: add a committable group
Documentation/filesystems/configfs.rst | 6 +-
fs/configfs/configfs_internal.h | 22 +--
fs/configfs/dir.c | 240 ++++++++++++++++++++++++-
fs/configfs/file.c | 8 +
include/linux/configfs.h | 3 +-
samples/configfs/configfs_sample.c | 150 ++++++++++++++++
6 files changed, 409 insertions(+), 20 deletions(-)
--
2.29.1
next reply other threads:[~2020-12-04 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 10:00 Bartosz Golaszewski [this message]
2020-12-04 10:00 ` [PATCH v3 1/4] configfs: increase the item name length Bartosz Golaszewski
2020-12-04 10:00 ` [PATCH v3 2/4] configfs: use (1UL << bit) for internal flags Bartosz Golaszewski
[not found] ` <CAHp75VdWMVoXyBBHFhweygAWpwOYg8GPU09DvXsgpGF2Oi04FA@mail.gmail.com>
2020-12-04 20:23 ` Bartosz Golaszewski
2020-12-04 10:00 ` [PATCH v3 3/4] configfs: implement committable items Bartosz Golaszewski
2020-12-04 10:00 ` [PATCH v3 4/4] samples: configfs: add a committable group Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204100039.19159-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).