From: Alan Stern <stern@rowland.harvard.edu>
To: Bui Quang Minh <minhquangbui99@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Corentin Labbe <clabbe@baylibre.com>,
Jules Irenge <jbi.octave@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: dummy-hcd: Fix uninitialized array use in init()
Date: Fri, 4 Dec 2020 11:12:49 -0500 [thread overview]
Message-ID: <20201204161249.GA1141609@rowland.harvard.edu> (raw)
In-Reply-To: <1607063090-3426-1-git-send-email-minhquangbui99@gmail.com>
On Fri, Dec 04, 2020 at 06:24:49AM +0000, Bui Quang Minh wrote:
> This error path
>
> err_add_pdata:
> for (i = 0; i < mod_data.num; i++)
> kfree(dum[i]);
>
> can be triggered when not all dum's elements are initialized.
>
> Fix this by initializing all dum's elements to NULL.
>
> Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
> ---
> drivers/usb/gadget/udc/dummy_hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> index 0eeaead..a2cf009 100644
> --- a/drivers/usb/gadget/udc/dummy_hcd.c
> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> @@ -2734,7 +2734,7 @@ static int __init init(void)
> {
> int retval = -ENOMEM;
> int i;
> - struct dummy *dum[MAX_NUM_UDC];
> + struct dummy *dum[MAX_NUM_UDC] = {};
>
> if (usb_disabled())
> return -ENODEV;
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Does this initialization end up using less memory than an explicit
memset() call?
Alan Stern
next prev parent reply other threads:[~2020-12-04 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 6:24 [PATCH] USB: dummy-hcd: Fix uninitialized array use in init() Bui Quang Minh
2020-12-04 16:12 ` Alan Stern [this message]
2020-12-05 12:47 ` Minh Bùi Quang
2020-12-05 15:15 ` Alan Stern
2020-12-06 11:24 ` Bui Quang Minh
2020-12-06 16:07 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204161249.GA1141609@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=andreyknvl@gmail.com \
--cc=balbi@kernel.org \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbi.octave@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=minhquangbui99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).