linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: dwc: exynos: add back MSI dependency
@ 2020-12-04 16:58 Arnd Bergmann
  2020-12-07 14:23 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-04 16:58 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Bjorn Helgaas, Jaehoon Chung, Jingoo Han,
	Krzysztof Kozlowski, Rob Herring
  Cc: Arnd Bergmann, Andrew Murray, Dilip Kota, Vidya Sagar,
	Kunihiko Hayashi, Alex Dewar, linux-pci, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

While the exynos driver does not always need MSI, the generic
deisgnware host code it uses fails to build without it:

WARNING: unmet direct dependencies detected for PCIE_DW_HOST
  Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
  Selected by [y]:
  - PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS [=n] || COMPILE_TEST [=y])
drivers/pci/controller/dwc/pcie-designware-host.c:247:19: error: implicit declaration of function 'pci_msi_create_irq_domain' [-Werror,-Wimplicit-function-declaration]
        pp->msi_domain = pci_msi_create_irq_domain(fwnode,
                         ^

Add back the dependency that all other designware controllers have.

Fixes: f0a6743028f9 ("PCI: dwc: exynos: Rework the driver to support Exynos5433 variant")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 020101b58155..e403bb2eeb4c 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
 config PCI_EXYNOS
 	tristate "Samsung Exynos PCIe controller"
 	depends on ARCH_EXYNOS || COMPILE_TEST
+	depends on PCI && PCI_MSI_IRQ_DOMAIN
 	select PCIE_DW_HOST
 	help
 	  Enables support for the PCIe controller in the Samsung Exynos SoCs
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: dwc: exynos: add back MSI dependency
  2020-12-04 16:58 [PATCH] PCI: dwc: exynos: add back MSI dependency Arnd Bergmann
@ 2020-12-07 14:23 ` Rob Herring
  2020-12-07 14:48   ` Arnd Bergmann
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-12-07 14:23 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Lorenzo Pieralisi, Bjorn Helgaas, Jaehoon Chung, Jingoo Han,
	Krzysztof Kozlowski, Arnd Bergmann, Andrew Murray, Dilip Kota,
	Vidya Sagar, Kunihiko Hayashi, Alex Dewar, PCI, linux-kernel

On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> While the exynos driver does not always need MSI, the generic
> deisgnware host code it uses fails to build without it:
>
> WARNING: unmet direct dependencies detected for PCIE_DW_HOST
>   Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>   Selected by [y]:
>   - PCI_EXYNOS [=y] && PCI [=y] && (ARCH_EXYNOS [=n] || COMPILE_TEST [=y])
> drivers/pci/controller/dwc/pcie-designware-host.c:247:19: error: implicit declaration of function 'pci_msi_create_irq_domain' [-Werror,-Wimplicit-function-declaration]
>         pp->msi_domain = pci_msi_create_irq_domain(fwnode,
>                          ^
>
> Add back the dependency that all other designware controllers have.
>
> Fixes: f0a6743028f9 ("PCI: dwc: exynos: Rework the driver to support Exynos5433 variant")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/pci/controller/dwc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Seems like we should rework this to avoid select on options with
depends, but that's a separate change.

> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 020101b58155..e403bb2eeb4c 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
>  config PCI_EXYNOS
>         tristate "Samsung Exynos PCIe controller"
>         depends on ARCH_EXYNOS || COMPILE_TEST
> +       depends on PCI && PCI_MSI_IRQ_DOMAIN

PCI isn't needed here.

>         select PCIE_DW_HOST
>         help
>           Enables support for the PCIe controller in the Samsung Exynos SoCs
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: dwc: exynos: add back MSI dependency
  2020-12-07 14:23 ` Rob Herring
@ 2020-12-07 14:48   ` Arnd Bergmann
  0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-07 14:48 UTC (permalink / raw)
  To: Rob Herring
  Cc: Lorenzo Pieralisi, Bjorn Helgaas, Jaehoon Chung, Jingoo Han,
	Krzysztof Kozlowski, Arnd Bergmann, Andrew Murray, Dilip Kota,
	Vidya Sagar, Kunihiko Hayashi, Alex Dewar, PCI, linux-kernel

On Mon, Dec 7, 2020 at 3:23 PM Rob Herring <robh@kernel.org> wrote:
> On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann <arnd@kernel.org> wrote:
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 020101b58155..e403bb2eeb4c 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
> >  config PCI_EXYNOS
> >         tristate "Samsung Exynos PCIe controller"
> >         depends on ARCH_EXYNOS || COMPILE_TEST
> > +       depends on PCI && PCI_MSI_IRQ_DOMAIN
>
> PCI isn't needed here.

Ah right. I had copied this from PCIE_DW_PLAT_HOST, and
I'm fairly sure it used to be needed at some point in the past,
but the Kconfig file has been changed enough over time that
it clearly is not needed any more, as the entire menu depends on
PCI nowadays, i.e. you can no longer have an endpoint-only
configuration.

      Arnd

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-07 14:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-04 16:58 [PATCH] PCI: dwc: exynos: add back MSI dependency Arnd Bergmann
2020-12-07 14:23 ` Rob Herring
2020-12-07 14:48   ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).