From: laniel_francis@privacyrequired.com To: "Hauke Mehrtens" <hauke@hauke-m.de>, "Rafał Miłecki" <zajec5@gmail.com>, "Thomas Bogendoerfer" <tsbogend@alpha.franken.de> Cc: Francis Laniel <laniel_francis@privacyrequired.com>, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v1 02/12] mips: Replace strstarts() by str_has_prefix(). Date: Fri, 4 Dec 2020 18:03:08 +0100 [thread overview] Message-ID: <20201204170319.20383-3-laniel_francis@privacyrequired.com> (raw) In-Reply-To: <20201204170319.20383-1-laniel_francis@privacyrequired.com> From: Francis Laniel <laniel_francis@privacyrequired.com> The two functions indicates if a string begins with a given prefix. The only difference is that strstarts() returns a bool while str_has_prefix() returns the length of the prefix if the string begins with it or 0 otherwise. Signed-off-by: Francis Laniel <laniel_francis@privacyrequired.com> --- arch/mips/bcm47xx/board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/bcm47xx/board.c b/arch/mips/bcm47xx/board.c index 35266a70e22a..c21a15b581f6 100644 --- a/arch/mips/bcm47xx/board.c +++ b/arch/mips/bcm47xx/board.c @@ -243,7 +243,7 @@ static __init const struct bcm47xx_board_type *bcm47xx_board_get_nvram(void) if (bcm47xx_nvram_getenv("hardware_version", buf1, sizeof(buf1)) >= 0) { for (e1 = bcm47xx_board_list_hardware_version; e1->value1; e1++) { - if (strstarts(buf1, e1->value1)) + if (str_has_prefix(buf1, e1->value1)) return &e1->board; } } @@ -251,7 +251,7 @@ static __init const struct bcm47xx_board_type *bcm47xx_board_get_nvram(void) if (bcm47xx_nvram_getenv("hardware_version", buf1, sizeof(buf1)) >= 0 && bcm47xx_nvram_getenv("boardnum", buf2, sizeof(buf2)) >= 0) { for (e2 = bcm47xx_board_list_hw_version_num; e2->value1; e2++) { - if (!strstarts(buf1, e2->value1) && + if (!str_has_prefix(buf1, e2->value1) && !strcmp(buf2, e2->value2)) return &e2->board; } -- 2.20.1
next prev parent reply other threads:[~2020-12-04 17:05 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 17:03 [RFC PATCH v1 00/12] " laniel_francis 2020-12-04 17:03 ` [RFC PATCH v1 01/12] arm: " laniel_francis 2020-12-04 17:03 ` laniel_francis [this message] 2020-12-04 17:03 ` [RFC PATCH v1 03/12] crypto: " laniel_francis 2020-12-04 17:03 ` [RFC PATCH v1 04/12] device-mapper: " laniel_francis 2020-12-04 17:03 ` [RFC PATCH v1 05/12] renesas: " laniel_francis 2020-12-04 17:03 ` [RFC PATCH v1 06/12] omap: " laniel_francis 2020-12-04 17:03 ` [RFC PATCH v1 07/12] efi: " laniel_francis 2020-12-04 17:07 ` Ard Biesheuvel 2020-12-04 17:19 ` Francis Laniel 2020-12-04 18:02 ` James Bottomley 2020-12-05 19:08 ` Francis Laniel 2020-12-05 19:36 ` Ard Biesheuvel 2020-12-05 20:24 ` James Bottomley 2020-12-05 20:57 ` Ard Biesheuvel 2020-12-05 21:15 ` James Bottomley 2020-12-05 21:20 ` Ard Biesheuvel 2020-12-05 23:04 ` James Bottomley 2020-12-07 15:10 ` Steven Rostedt 2020-12-07 16:25 ` David Laight 2020-12-05 20:28 ` Rasmus Villemoes 2020-12-10 18:14 ` Arvind Sankar 2020-12-11 9:45 ` David Laight 2020-12-11 16:10 ` Arvind Sankar 2020-12-04 17:03 ` [RFC PATCH v1 08/12] ide: " laniel_francis 2020-12-04 17:03 ` [RFC PATCH v1 09/12] mips: " laniel_francis 2020-12-04 17:03 ` [RFC PATCH v1 10/12] module: " laniel_francis 2020-12-04 17:03 ` [RFC PATCH v1 11/12] musb: " laniel_francis 2020-12-04 17:03 ` [RFC PATCH v1 12/12] string.h: Remove strstarts() laniel_francis 2020-12-04 17:56 ` [RFC PATCH v1 00/12] Replace strstarts() by str_has_prefix() James Bottomley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201204170319.20383-3-laniel_francis@privacyrequired.com \ --to=laniel_francis@privacyrequired.com \ --cc=hauke@hauke-m.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=tsbogend@alpha.franken.de \ --cc=zajec5@gmail.com \ --subject='Re: [RFC PATCH v1 02/12] mips: Replace strstarts() by str_has_prefix().' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).