linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the rcu tree
@ 2020-12-04  8:25 Stephen Rothwell
  2020-12-04 19:20 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2020-12-04  8:25 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (sparc defconfig)
failed like this:

mm/slab_common.o: In function `kmem_last_alloc':
slab_common.c:(.text+0xc4): undefined reference to `kmem_cache_last_alloc'

Caused by commit

  f7c3fb4fc476 ("mm: Add kmem_last_alloc() to return last allocation for memory block")

in mm/slab.c, kmem_cache_last_alloc() is only defined when CONFIG_NUMA
is set - which is not for this build.

I applied the following hack fix patch for today.

From ac5dcf78be1e6da530302966369a3bd63007cf81 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 4 Dec 2020 19:11:01 +1100
Subject: [PATCH] fixup for "mm: Add kmem_last_alloc() to return last
 allocation for memory block"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 mm/slab.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/mm/slab.c b/mm/slab.c
index 1f3b263f81ee..064707ac9f54 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3650,6 +3650,11 @@ void *__kmalloc_node_track_caller(size_t size, gfp_t flags,
 	return __do_kmalloc_node(size, flags, node, caller);
 }
 EXPORT_SYMBOL(__kmalloc_node_track_caller);
+#else
+void *kmem_cache_last_alloc(struct kmem_cache *cachep, void *object)
+{
+	return NULL;
+}
 #endif /* CONFIG_NUMA */
 
 /**
-- 
2.29.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2024-01-24  4:17 Stephen Rothwell
  2024-01-24  9:49 ` Jiri Wiesner
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2024-01-24  4:17 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Jiri Wiesner, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (i386 defconfig)
failed like this:

In file included from include/linux/dev_printk.h:14,
                 from include/linux/device.h:15,
                 from kernel/time/clocksource.c:10:
kernel/time/clocksource.c: In function 'clocksource_watchdog':
kernel/time/clocksource.c:103:34: error: integer overflow in expression of type 'long int' results in '-1619276800' [-Werror=overflow]
  103 |                                  * NSEC_PER_SEC / HZ)
      |                                  ^
include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
   77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
      |                                             ^
kernel/time/clocksource.c:486:41: note: in expansion of macro 'WATCHDOG_INTR_MAX_NS'
  486 |                 if (unlikely(interval > WATCHDOG_INTR_MAX_NS)) {
      |                                         ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  1a4545025600 ("clocksource: Skip watchdog check for large watchdog intervals")

I have used the rcu tree from next-20240123 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2023-07-27  4:19 Stephen Rothwell
  2023-07-27 14:08 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2023-07-27  4:19 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Arnd Bergmann, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2561 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (arm64 defconfig)
failed like this:

In file included from arch/arm64/include/asm/alternative.h:9,
                 from arch/arm64/include/asm/lse.h:14,
                 from arch/arm64/include/asm/cmpxchg.h:14,
                 from arch/arm64/include/asm/atomic.h:16,
                 from include/linux/atomic.h:7,
                 from include/asm-generic/bitops/atomic.h:5,
                 from arch/arm64/include/asm/bitops.h:25,
                 from include/linux/bitops.h:68,
                 from arch/arm64/include/asm/cache.h:40,
                 from include/linux/cache.h:6,
                 from include/linux/slab.h:15,
                 from include/linux/resource_ext.h:11,
                 from include/linux/acpi.h:13,
                 from include/acpi/apei.h:9,
                 from include/acpi/ghes.h:5,
                 from include/linux/arm_sdei.h:8,
                 from arch/arm64/kernel/asm-offsets.c:10:
include/linux/init.h:149:33: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__ro_after_init'
  149 | extern char boot_command_line[] __ro_after_init;
      |                                 ^~~~~~~~~~~~~~~

Caused by commit

  de2f542cfbec ("fs/proc: Add /proc/cmdline_load for boot loader arguments")

I have applied the following fix up (I have a faint memory that the
section setting attributes are only needed on the definition, not the
declaration):

From 9f56e539ed7d9c402caa85d4f5f3f8cec8373b2f Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 27 Jul 2023 13:26:08 +1000
Subject: [PATCH] fix up for "fs/proc: Add /proc/cmdline_load for boot loader
 arguments"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/init.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/init.h b/include/linux/init.h
index e3ce68988e1b..c075983c5015 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -113,8 +113,6 @@
 
 #ifndef __ASSEMBLY__
 
-#include <linux/cache.h>
-
 /*
  * Used for initialization calls..
  */
@@ -146,7 +144,7 @@ struct file_system_type;
 
 /* Defined in init/main.c */
 extern int do_one_initcall(initcall_t fn);
-extern char boot_command_line[] __ro_after_init;
+extern char boot_command_line[];
 extern char *saved_command_line;
 extern unsigned int saved_command_line_len;
 extern unsigned int reset_devices;
-- 
2.40.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2023-05-19  0:59 Stephen Rothwell
  2023-05-19  2:12 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2023-05-19  0:59 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

kernel/rcu/rcuscale.c:340:27: error: 'get_rcu_tasks_trace_gp_kthread' undeclared here (not in a function); did you mean 'show_rcu_tasks_trace_gp_kthread'?
  340 |         .rso_gp_kthread = get_rcu_tasks_trace_gp_kthread,
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                           show_rcu_tasks_trace_gp_kthread

Caused by commit

  9bb839a83e1b ("rcuscale: Measure grace-period kthread CPU time")

CONFIG_RCU_SCALE_TEST=m

I have used the rcu tree from next-20230518 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2023-03-14  1:29 Stephen Rothwell
  2023-03-14  4:43 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2023-03-14  1:29 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Uladzislau Rezki (Sony),
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 3010 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

net/mac802154/scan.c: In function 'mac802154_scan_cleanup_locked':
net/mac802154/scan.c:55:26: error: macro "kfree_rcu" requires 2 arguments, but only 1 given
   55 |         kfree_rcu(request);
      |                          ^
In file included from include/linux/rbtree.h:24,
                 from include/linux/mm_types.h:11,
                 from include/linux/buildid.h:5,
                 from include/linux/module.h:14,
                 from net/mac802154/scan.c:11:
include/linux/rcupdate.h:984: note: macro "kfree_rcu" defined here
  984 | #define kfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf)
      | 
net/mac802154/scan.c:55:9: error: 'kfree_rcu' undeclared (first use in this function); did you mean 'kfree_skb'?
   55 |         kfree_rcu(request);
      |         ^~~~~~~~~
      |         kfree_skb
net/mac802154/scan.c:55:9: note: each undeclared identifier is reported only once for each function it appears in
net/mac802154/scan.c: In function 'mac802154_stop_beacons_locked':
net/mac802154/scan.c:406:26: error: macro "kfree_rcu" requires 2 arguments, but only 1 given
  406 |         kfree_rcu(request);
      |                          ^
include/linux/rcupdate.h:984: note: macro "kfree_rcu" defined here
  984 | #define kfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf)
      | 
net/mac802154/scan.c:406:9: error: 'kfree_rcu' undeclared (first use in this function); did you mean 'kfree_skb'?
  406 |         kfree_rcu(request);
      |         ^~~~~~~~~
      |         kfree_skb
drivers/infiniband/sw/rxe/rxe_mr.c: In function 'rxe_dereg_mr':
drivers/infiniband/sw/rxe/rxe_mr.c:734:21: error: macro "kfree_rcu" requires 2 arguments, but only 1 given
  734 |         kfree_rcu(mr);
      |                     ^
In file included from include/linux/rculist.h:11,
                 from include/linux/dcache.h:8,
                 from include/linux/fs.h:8,
                 from include/linux/highmem.h:5,
                 from include/linux/bvec.h:10,
                 from include/linux/blk_types.h:10,
                 from include/linux/bio.h:10,
                 from include/linux/libnvdimm.h:14,
                 from drivers/infiniband/sw/rxe/rxe_mr.c:7:
include/linux/rcupdate.h:984: note: macro "kfree_rcu" defined here
  984 | #define kfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf)
      | 
drivers/infiniband/sw/rxe/rxe_mr.c:734:9: error: 'kfree_rcu' undeclared (first use in this function); did you mean 'kfree_skb'?
  734 |         kfree_rcu(mr);
      |         ^~~~~~~~~
      |         kfree_skb
drivers/infiniband/sw/rxe/rxe_mr.c:734:9: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  62a2ac23b35f ("rcu/kvfree: Eliminate k[v]free_rcu() single argument macro")

I have used the rcu tree from next-20230310 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2022-10-17 23:26 Stephen Rothwell
  2022-10-18 10:43 ` Frederic Weisbecker
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2022-10-17 23:26 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Frederic Weisbecker, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: modpost: "srcu_check_nmi_safety" [arch/x86/kvm/kvm.ko] undefined!
ERROR: modpost: "srcu_check_nmi_safety" [arch/x86/kvm/kvm-intel.ko] undefined!
ERROR: modpost: "srcu_check_nmi_safety" [arch/x86/kvm/kvm-amd.ko] undefined!
ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcutorture.ko] undefined!
ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcuscale.ko] undefined!
ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/refscale.ko] undefined!
ERROR: modpost: "srcu_check_nmi_safety" [fs/dlm/dlm.ko] undefined!
ERROR: modpost: "srcu_check_nmi_safety" [drivers/pci/controller/vmd.ko] undefined!
ERROR: modpost: "srcu_check_nmi_safety" [drivers/char/ipmi/ipmi_msghandler.ko] undefined!
ERROR: modpost: "srcu_check_nmi_safety" [drivers/gpu/drm/drm.ko] undefined!
WARNING: modpost: suppressed 10 unresolved symbol warnings because there were too many)

Presumably caused by commit

  54a118fce487 ("srcu: Debug NMI safety even on archs that don't require it")

I have used the rcu tree from next-20221017 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2022-04-19  2:36 Stephen Rothwell
  2022-04-19  3:31 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2022-04-19  2:36 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Joel Fernandes, Frederic Weisbecker, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from kernel/rcu/tree.c:5031:
kernel/rcu/tree_nocb.h: In function 'rcu_init_nohz':
kernel/rcu/tree_nocb.h:1162:14: error: 'rcu_nocb_is_setup' undeclared (first use in this function); did you mean 'rcu_nocb_setup'?
 1162 |         if (!rcu_nocb_is_setup) {
      |              ^~~~~~~~~~~~~~~~~
      |              rcu_nocb_setup
kernel/rcu/tree_nocb.h:1162:14: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  d6932dca19b1 ("rcu/nocb: Add an option to offload all CPUs on boot")

interacting with commit

  8d2aaa9b7c29 ("rcu/nocb: Move rcu_nocb_is_setup to rcu_state")

I have used the rcu tree from next-20220414 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2021-05-03  0:11 Stephen Rothwell
  2021-05-03 16:25 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2021-05-03  0:11 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: modpost: "clocksource_verify_percpu" [kernel/time/clocksource-wdtest.ko] undefined!

Caused by commit

  98f0fdb43573 ("clocksource: Provide kernel module to test clocksource watchdog")

I have used the rcu tree from next-20210430 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2021-04-22  4:10 Stephen Rothwell
  2021-04-22 16:36 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2021-04-22  4:10 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from kernel/rcu/update.c:584:
kernel/rcu/tasks.h:1404:20: error: static declaration of 'show_rcu_tasks_gp_kthreads' follows non-static declaration
 1404 | static inline void show_rcu_tasks_gp_kthreads(void) {}
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/rcu/update.c:49:
kernel/rcu/rcu.h:440:6: note: previous declaration of 'show_rcu_tasks_gp_kthreads' was here
  440 | void show_rcu_tasks_gp_kthreads(void);
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  4bf02dd6048d ("tasks-rcu: Make show_rcu_tasks_gp_kthreads() be static inline")

I have used the rcu tree from next-20210421 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2021-03-17  5:36 Stephen Rothwell
  2021-03-17 14:23 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2021-03-17  5:36 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: modpost: "rcu_read_lock_longwait_held" [kernel/rcu/rcutorture.ko] undefined!
ERROR: modpost: "rcu_read_unlock_longwait" [kernel/rcu/rcutorture.ko] undefined!
ERROR: modpost: "rcu_read_lock_longwait" [kernel/rcu/rcutorture.ko] undefined!

Caused by commit

  bd6ae31d1b1f ("rcutorture: Add the ability to torture RCU longsleep")

CONFIG_LONGWAIT_RCU=y
CONFIG_RCU_TORTURE_TEST=m

I have used the rcu tree from next-20210316 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2021-01-04  0:37 Stephen Rothwell
  2021-01-04 12:56 ` Frederic Weisbecker
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2021-01-04  0:37 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Frederic Weisbecker, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

arch/arm/mach-imx/cpuidle-imx6q.c: In function 'imx6q_enter_wait':
arch/arm/mach-imx/cpuidle-imx6q.c:32:7: error: implicit declaration of function 'need_resched'; did you mean 'tif_need_resched'? [-Werror=implicit-function-declaration]
   32 |  if (!need_resched())
      |       ^~~~~~~~~~~~
      |       tif_need_resched

Caused by commit

  7ca83ec735ce ("ARM: imx6q: Fix missing need_resched() check after rcu_idle_enter()")

I have used the rcu tree from next-20201223 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2020-09-17  5:19 Stephen Rothwell
  2020-09-17 22:01 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2020-09-17  5:19 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from kernel/rcu/update.c:578:
kernel/rcu/tasks.h:601:20: error: static declaration of 'show_rcu_tasks_classic_gp_kthread' follows non-static declaration
  601 | static inline void show_rcu_tasks_classic_gp_kthread(void) { }
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/rcu/update.c:49:
kernel/rcu/rcu.h:537:6: note: previous declaration of 'show_rcu_tasks_classic_gp_kthread' was here
  537 | void show_rcu_tasks_classic_gp_kthread(void);
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  675d3ca52626 ("rcutorture: Make grace-period kthread report match RCU flavor being tested")

I have used the rcu tree from next-20200916 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2020-09-08  5:38 Stephen Rothwell
  2020-09-08 13:54 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2020-09-08  5:38 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: modpost: "resched_cpu" [kernel/scftorture.ko] undefined!

Caused by commit

  20c881d0592c ("scftorture: Add an alternative IPI vector")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2020-08-18  1:43 Stephen Rothwell
  2020-08-18 14:08 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2020-08-18  1:43 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from include/linux/kernel.h:15,
                 from kernel/rcu/rcuscale.c:13:
kernel/rcu/rcuscale.c: In function 'rcu_scale_writer':
kernel/rcu/rcuscale.c:430:6: error: 'perf_type' undeclared (first use in this function); did you mean 'kernfs_type'?
  430 |      perf_type, PERF_FLAG, me, MIN_MEAS);
      |      ^~~~~~~~~
include/linux/printk.h:319:35: note: in definition of macro 'pr_alert'
  319 |  printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
      |                                   ^~~~~~~~~~~
kernel/rcu/rcuscale.c:430:6: note: each undeclared identifier is reported only once for each function it appears in
  430 |      perf_type, PERF_FLAG, me, MIN_MEAS);
      |      ^~~~~~~~~
include/linux/printk.h:319:35: note: in definition of macro 'pr_alert'
  319 |  printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
      |                                   ^~~~~~~~~~~
kernel/rcu/rcuscale.c:430:17: error: 'PERF_FLAG' undeclared (first use in this function)
  430 |      perf_type, PERF_FLAG, me, MIN_MEAS);
      |                 ^~~~~~~~~
include/linux/printk.h:319:35: note: in definition of macro 'pr_alert'
  319 |  printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
      |                                   ^~~~~~~~~~~
kernel/rcu/rcuscale.c:431:27: error: 'n_rcu_perf_writer_finished' undeclared (first use in this function); did you mean 'n_rcu_scale_writer_finished'?
  431 |    if (atomic_inc_return(&n_rcu_perf_writer_finished) >=
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                           n_rcu_scale_writer_finished

Caused by commit

  a20b5bd09813 ("rcuperf: Change rcuperf to rcuscale")

I have used the rcu tree from next-20200817 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2020-06-25  2:57 Stephen Rothwell
  2020-06-25  3:45 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2020-06-25  2:57 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Peter Zijlstra

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

kernel/rcu/tree.c: In function 'rcu_dynticks_eqs_enter':
kernel/rcu/tree.c:251:8: error: implicit declaration of function 'arch_atomic_add_return'; did you mean 'atomic_add_return'? [-Werror=implicit-function-declaration]
  251 |  seq = arch_atomic_add_return(RCU_DYNTICK_CTRL_CTR, &rdp->dynticks);
      |        ^~~~~~~~~~~~~~~~~~~~~~
      |        atomic_add_return
kernel/rcu/tree.c: In function 'rcu_dynticks_eqs_exit':
kernel/rcu/tree.c:281:3: error: implicit declaration of function 'arch_atomic_andnot'; did you mean 'atomic_andnot'? [-Werror=implicit-function-declaration]
  281 |   arch_atomic_andnot(RCU_DYNTICK_CTRL_MASK, &rdp->dynticks);
      |   ^~~~~~~~~~~~~~~~~~
      |   atomic_andnot
kernel/rcu/tree.c: In function 'rcu_dynticks_curr_cpu_in_eqs':
kernel/rcu/tree.c:314:11: error: implicit declaration of function 'arch_atomic_read'; did you mean 'atomic_read'? [-Werror=implicit-function-declaration]
  314 |  return !(arch_atomic_read(&rdp->dynticks) & RCU_DYNTICK_CTRL_CTR);
      |           ^~~~~~~~~~~~~~~~
      |           atomic_read

Caused by commit

  d2f8491368e5 ("rcu: Fixup noinstr warnings")

I reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2020-05-28  9:05 Stephen Rothwell
  2020-05-28 16:33 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2020-05-28  9:05 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Joel Fernandes (Google)

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (powercp
allyesconfig) failed like this:

ld: kernel/rcu/refperf.o:(.discard+0x0): multiple definition of `__pcpu_unique_srcu_ctl_perf_srcu_data'; kernel/rcu/rcuperf.o:(.discard+0x0): first defined here

Caused by commit

  786a25497743 ("refperf: Add a test to measure performance of read-side synchronization")

From srcutree.h:

 * Note that although DEFINE_STATIC_SRCU() hides the name from other
 * files, the per-CPU variable rules nevertheless require that the
 * chosen name be globally unique.

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 28 May 2020 18:57:17 +1000
Subject: [PATCH] refperf: uniqify name

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 kernel/rcu/refperf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/rcu/refperf.c b/kernel/rcu/refperf.c
index 8c4a63257be9..47df72c492b3 100644
--- a/kernel/rcu/refperf.c
+++ b/kernel/rcu/refperf.c
@@ -133,8 +133,8 @@ static struct ref_perf_ops rcu_ops = {
 
 
 // Definitions for SRCU ref perf testing.
-DEFINE_STATIC_SRCU(srcu_ctl_perf);
-static struct srcu_struct *srcu_ctlp = &srcu_ctl_perf;
+DEFINE_STATIC_SRCU(ref_srcu_ctl_perf);
+static struct srcu_struct *srcu_ctlp = &ref_srcu_ctl_perf;
 
 static void srcu_ref_perf_read_section(int nloops)
 {
-- 
2.26.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2020-04-05  1:49 Stephen Rothwell
  2020-04-05  3:10 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2020-04-05  1:49 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

kernel/trace/ftrace.c: In function 'ftrace_shutdown':
kernel/trace/ftrace.c:2924:3: error: implicit declaration of function 'synchronize_rcu_tasks_rude'; did you mean 'synchronize_rcu_tasks'? [-Werror=implicit-function-declaration]
 2924 |   synchronize_rcu_tasks_rude();
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |   synchronize_rcu_tasks

Caused by commit

  59377f3e06b8 ("ftrace: Use synchronize_rcu_tasks_rude() instead of ftrace_sync()")

synchronize_rcu_tasks_rude() is only declared when
CONFIG_TASKS_RCU_GENERIC is defined.

I have reverted that commit for today.

Just asking: are all the commits currently in the rcu tree actually
intended for v5.7?
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2020-01-17  3:07 Stephen Rothwell
  0 siblings, 0 replies; 152+ messages in thread
From: Stephen Rothwell @ 2020-01-17  3:07 UTC (permalink / raw)
  To: Paul E. McKenney, David Howells
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

security/keys/permission.c: In function 'key_set_acl':
security/keys/permission.c:273:2: error: implicit declaration of function 'rcu_swap_protected' [-Werror=implicit-function-declaration]
  273 |  rcu_swap_protected(key->acl, acl, lockdep_is_held(&key->sem));
      |  ^~~~~~~~~~~~~~~~~~
security/keys/permission.c:273:36: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_is_held_type'? [-Werror=implicit-function-declaration]
  273 |  rcu_swap_protected(key->acl, acl, lockdep_is_held(&key->sem));
      |                                    ^~~~~~~~~~~~~~~
      |                                    lockdep_is_held_type

Caused by commit

  4414abf89158 ("rcu: Remove rcu_swap_protected()")

interacting with commit

  af94dc1ff4c9 ("keys: Replace uid/gid/perm permissions checking with an ACL")

from the keys tree.

I have added this merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 17 Jan 2020 14:04:13 +1100
Subject: [PATCH] fixup 2 for removal of rcu_swap_protected

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 security/keys/permission.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/keys/permission.c b/security/keys/permission.c
index a651b3fd2007..f42e67b51aea 100644
--- a/security/keys/permission.c
+++ b/security/keys/permission.c
@@ -270,7 +270,7 @@ long key_set_acl(struct key *key, struct key_acl *acl)
 		}
 	}
 
-	rcu_swap_protected(key->acl, acl, lockdep_is_held(&key->sem));
+	acl = rcu_replace_pointer(key->acl, acl, lockdep_is_held(&key->sem));
 	key_put_acl(acl);
 	notify_key(key, NOTIFY_KEY_SETATTR, 0);
 	return 0;
-- 
2.24.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2019-12-12  2:45 Stephen Rothwell
  2019-12-12  4:07 ` Paul E. McKenney
  2020-01-17  3:09 ` Stephen Rothwell
  0 siblings, 2 replies; 152+ messages in thread
From: Stephen Rothwell @ 2019-12-12  2:45 UTC (permalink / raw)
  To: Paul E. McKenney, David Howells
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/misc/watch_queue.c: In function 'watch_queue_set_filter':
drivers/misc/watch_queue.c:526:2: error: implicit declaration of function 'rcu_swap_protected' [-Werror=implicit-function-declaration]
  526 |  rcu_swap_protected(wqueue->filter, wfilter,
      |  ^~~~~~~~~~~~~~~~~~

Caused by commit

  af8c9224182e ("rcu: Remove rcu_swap_protected()")

interacting with commit

  fe78d401ca6b ("General notification queue with user mmap()'able ring buffer")

from the keys tree.

I have added the following merge fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 12 Dec 2019 13:37:52 +1100
Subject: [PATCH] rcu: fix up for "Remove rcu_swap_protected()"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/misc/watch_queue.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/watch_queue.c b/drivers/misc/watch_queue.c
index b3fc59b4ef6c..a4a77ec977ac 100644
--- a/drivers/misc/watch_queue.c
+++ b/drivers/misc/watch_queue.c
@@ -523,8 +523,8 @@ static long watch_queue_set_filter(struct inode *inode,
 	kfree(tf);
 set:
 	inode_lock(inode);
-	rcu_swap_protected(wqueue->filter, wfilter,
-			   lockdep_is_held(&inode->i_rwsem));
+	wfilter = rcu_replace_pointer(wqueue->filter, wfilter,
+				      lockdep_is_held(&inode->i_rwsem));
 	inode_unlock(inode);
 	if (wfilter)
 		kfree_rcu(wfilter, rcu);
-- 
2.24.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2019-08-13  7:57 Stephen Rothwell
  2019-08-13 15:31 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2019-08-13  7:57 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Joel Fernandes (Google),
	Greg Kroah-Hartman

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (powerpc allnoconfig)
failed like this:

drivers/base/core.c: In function 'device_links_read_lock_held':
drivers/base/core.c:106:9: error: implicit declaration of function 'lock_is_held'; did you mean 'lockref_get'? [-Werror=implicit-function-declaration]
  return lock_is_held(&device_links_lock);
         ^~~~~~~~~~~~
         lockref_get

Caused by commit

  4a3a5474b4c1 ("driver/core: Convert to use built-in RCU list checking")

lock_is_held() us only available if CONFIG_LOCKDEP is set.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2019-08-12  6:12 Stephen Rothwell
  2019-08-12 16:19 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2019-08-12  6:12 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Peter Zijlstra

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

Hi all,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

arch/x86/xen/smp_pv.c: In function 'xen_pv_play_dead':
arch/x86/xen/smp_pv.c:439:2: error: implicit declaration of function 'tick_nohz_idle_stop_tick_protected'; did you mean 'tick_nohz_idle_stop_tick'? [-Werror=implicit-function-declaration]
  tick_nohz_idle_stop_tick_protected();
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  tick_nohz_idle_stop_tick

Caused by commit

  a96f9dca9820 ("idle: Prevent late-arriving interrupts from disrupting offline")

Also:

In file included from <command-line>:
include/linux/rcu_segcblist.h:69:2: error: unknown type name 'atomic_long_t'
  atomic_long_t len;
  ^~~~~~~~~~~~~
include/linux/rcu_segcblist.h:74:2: error: unknown type name 'u8'
  u8 enabled;
  ^~
include/linux/rcu_segcblist.h:75:2: error: unknown type name 'u8'
  u8 offloaded;
  ^~

Caused by commits:

  e084617762b7 ("rcu/nocb: Use separate flag to indicate disabled ->cblist")
  5e114ba3d7a5 ("rcu/nocb: Use separate flag to indicate offloaded ->cblist")
  9f3ca0945104 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")

We prefer our include files to be standalone now if at all possible.

I have used the rcu tree from next-20190809 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2017-09-04  4:50 Stephen Rothwell
  2017-09-04 16:39 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2017-09-04  4:50 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

Hi Paul,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "rcu_cpu_stall_suppress" [kernel/rcu/rcutorture.ko] undefined!
ERROR: "rcu_cpu_stall_suppress" [kernel/rcu/rcuperf.ko] undefined!

Caused by commit

  909bd6e3d9e7 ("rcu: Suppress RCU CPU stall warnings while dumping trace")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2017-08-28  4:25 Stephen Rothwell
  2017-08-28 17:50 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2017-08-28  4:25 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Mathieu Desnoyers

Hi Paul,

After merging the rcu tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from arch/arm/kernel/asm-offsets.c:14:0:
include/linux/sched.h: In function 'membarrier_sched_out':
include/linux/sched.h:1680:3: error: implicit declaration of function 'sync_core' [-Werror=implicit-function-declaration]
   sync_core();
   ^

Caused by commit

  0d6eb99818da ("membarrier: Provide register sync core cmd")

I have used the rcu tree from next-20170825 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2017-08-11  4:43 Stephen Rothwell
  2017-08-11  4:54 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2017-08-11  4:43 UTC (permalink / raw)
  To: Paul E. McKenney, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	Peter Zijlstra
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

Hi Paul,

After merging the rcu tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

kernel/sched/core.c: In function 'do_task_dead':
kernel/sched/core.c:3385:2: error: implicit declaration of function 'smp_mb__before_spinlock' [-Werror=implicit-function-declaration]
  smp_mb__before_spinlock();
  ^
cc1: some warnings being treated as errors

Caused by commit

  4a6fc6107e90 ("sched: Replace spin_unlock_wait() with lock/unlock pair")

Interacting with commit

  a9668cd6ee28 ("locking: Remove smp_mb__before_spinlock()")

from the tip tree.

I applied this patch for now, but I assume something better is required.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 11 Aug 2017 14:32:10 +1000
Subject: [PATCH] sched: temporary hack for locking: Remove smp_mb__before_spinlock()

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 2bd00feaea15..a4f4ba2e3be6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3382,7 +3382,7 @@ void __noreturn do_task_dead(void)
 	 * To avoid it, we have to wait for releasing tsk->pi_lock which
 	 * is held by try_to_wake_up()
 	 */
-	smp_mb__before_spinlock();
+	smp_mb();
 	raw_spin_lock_irq(&current->pi_lock);
 	raw_spin_unlock_irq(&current->pi_lock);
 
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2017-05-29  6:02 Stephen Rothwell
  2017-05-29 21:15 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2017-05-29  6:02 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Joe Perches,
	Mike Frysinger, Steven Miao

Hi Paul,

After merging the rcu tree, today's linux-next build (bfin
BF526-EZBRD_defconfig and several other bfin configs) failed like this:

In file included from include/linux/srcu.h:60:0,
                 from include/linux/notifier.h:15,
                 from include/linux/memory_hotplug.h:6,
                 from include/linux/mmzone.h:777,
                 from include/linux/gfp.h:5,
                 from include/linux/kmod.h:22,
                 from include/linux/module.h:13,
                 from include/linux/moduleloader.h:5,
                 from arch/blackfin/kernel/module.c:9:
include/linux/srcutiny.h: In function 'srcu_torture_stats_print':
include/linux/srcutiny.h:96:2: error: 'mod' undeclared (first use in this function)

Caused by commit

  54ffb22bd841 ("rcutorture: Move SRCU status printing to SRCU implementations")

arch/blackfin/kernel/module.c includes this:

#define pr_fmt(fmt) "module %s: " fmt, mod->name

added by commit

  b75a9e6bfba5 ("Blackfin: use more standard pr_fmt in the module loader")

before v2.6.39-rc2 ...

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2017-04-20  5:36 Stephen Rothwell
  2017-04-20 14:23 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2017-04-20  5:36 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Michael Ellerman, Benjamin Herrenschmidt, PowerPC

Hi Paul,

[Also reported by Michael elsewhere]

After merging the rcu tree, today's linux-next build (powerpc
pseries_le_defconfig) failed like this:

arch/powerpc/kvm/book3s_hv_rmhandlers.S: Assembler messages:
arch/powerpc/kvm/book3s_hv_rmhandlers.S:587: Error: operand out of range (0x0000000000009ff8 is not between 0xffffffffffff8000 and 0x0000000000007fff)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:617: Error: operand out of range (0x0000000000009d88 is not between 0xffffffffffff8000 and 0x0000000000007fff)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:619: Error: operand out of range (0x0000000000009dc0 is not between 0xffffffffffff8000 and 0x0000000000007ffc)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:643: Error: operand out of range (0x0000000000009df8 is not between 0xffffffffffff8000 and 0x0000000000007fff)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:650: Error: operand out of range (0x0000000000009d8c is not between 0xffffffffffff8000 and 0x0000000000007fff)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1353: Error: operand out of range (0x0000000000009ff8 is not between 0xffffffffffff8000 and 0x0000000000007fff)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1663: Error: operand out of range (0x0000000000009db0 is not between 0xffffffffffff8000 and 0x0000000000007fff)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1665: Error: operand out of range (0x0000000000009dc8 is not between 0xffffffffffff8000 and 0x0000000000007ffc)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1734: Error: operand out of range (0x0000000000009db8 is not between 0xffffffffffff8000 and 0x0000000000007ffc)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1782: Error: operand out of range (0x0000000000009ff8 is not between 0xffffffffffff8000 and 0x0000000000007fff)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1837: Error: operand out of range (0x0000000000009de0 is not between 0xffffffffffff8000 and 0x0000000000007ffc)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1877: Error: operand out of range (0x0000000000009ff8 is not between 0xffffffffffff8000 and 0x0000000000007fff)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1918: Error: operand out of range (0x0000000000009de0 is not between 0xffffffffffff8000 and 0x0000000000007ffc)
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1943: Error: operand out of range (0x000000000000a048 is not between 0xffffffffffff8000 and 0x0000000000007ffc)

Caused by commit

  b2bb79507ba1 ("srcu: Parallelize callback handling")

I have left it broken for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2017-04-19  3:50 Stephen Rothwell
  2017-04-19  4:06 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2017-04-19  3:50 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List

Hi Paul,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

kernel/rcu/rcutorture.c: In function 'rcu_torture_stats_print':
kernel/rcu/rcutorture.c:1369:3: error: implicit declaration of function 'srcutorture_get_gp_data' [-Werror=implicit-function-declaration]
   srcutorture_get_gp_data(cur_ops->ttype, srcu_ctlp,
   ^

Caused by commit

  b4d55cac0a93 ("srcu: Make rcutorture writer stalls print SRCU GP state")

This config has CONFIG_CLASSIC_SRCU=y and CONFIG_RCU_TORTURE_TEST=m, so
CONFIG_RCU_TORTURE_TEST is not defined - CONFIG_RCU_TORTURE_TEST_MODULE
is defined.  You probably want to protect srcutorture_get_gp_data() with
IS_ENABLED(CONFIG_RCU_TORTURE_TEST) instead.

I have used the rcu tree from next-20170418 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2017-03-08  1:16 Stephen Rothwell
  2017-03-08 10:13 ` Daniel Vetter
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2017-03-08  1:16 UTC (permalink / raw)
  To: Paul E. McKenney, Daniel Vetter, Intel Graphics, DRI
  Cc: linux-next, linux-kernel, Chris Wilson

Hi Paul,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from include/linux/resource_ext.h:19:0,
                 from include/linux/pci.h:32,
                 from include/drm/drmP.h:50,
                 from drivers/gpu/drm/i915/i915_gem.c:28:
drivers/gpu/drm/i915/selftests/mock_gem_device.c: In function 'mock_gem_device':
drivers/gpu/drm/i915/selftests/mock_gem_device.c:177:9: error: 'SLAB_DESTROY_BY_RCU' undeclared (first use in this function)
         SLAB_DESTROY_BY_RCU);
         ^
include/linux/slab.h:149:4: note: in definition of macro 'KMEM_CACHE'
   (__flags), NULL)
    ^
drivers/gpu/drm/i915/selftests/mock_gem_device.c:177:9: note: each undeclared identifier is reported only once for each function it appears in
         SLAB_DESTROY_BY_RCU);
         ^
include/linux/slab.h:149:4: note: in definition of macro 'KMEM_CACHE'
   (__flags), NULL)
    ^
/

Caused by commit

  24b7cb25b8d1 ("mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU")

interacting with commit

  0daf0113cff6 ("drm/i915: Mock infrastructure for request emission")

from the drm-intel tree.

I added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 8 Mar 2017 12:09:49 +1100
Subject: [PATCH] drm/i915: merge fix for "mm: Rename SLAB_DESTROY_BY_RCU to
 SLAB_TYPESAFE_BY_RCU"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index 6a8258eacdcb..9f24c5da3f8d 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -174,7 +174,7 @@ struct drm_i915_private *mock_gem_device(void)
 	i915->requests = KMEM_CACHE(mock_request,
 				    SLAB_HWCACHE_ALIGN |
 				    SLAB_RECLAIM_ACCOUNT |
-				    SLAB_DESTROY_BY_RCU);
+				    SLAB_TYPESAFE_BY_RCU);
 	if (!i915->requests)
 		goto err_vmas;
 
-- 
2.11.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2017-01-19  3:34 Stephen Rothwell
  2017-01-19 21:54 ` Paul McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2017-01-19  3:34 UTC (permalink / raw)
  To: Paul E. McKenney, David Miller, Networking
  Cc: linux-next, linux-kernel, Ursula Braun

Hi Paul,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

net/smc/af_smc.c:102:16: error: 'SLAB_DESTROY_BY_RCU' undeclared here (not in a function)
  .slab_flags = SLAB_DESTROY_BY_RCU,
                ^

Caused by commit

  c7a545924ca1 ("mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU")

interacting with commit

  ac7138746e14 ("smc: establish new socket family")

from the net-next tree.

I have applied the following merge fix patch (someone will need to
remember to mention this to Linus):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 19 Jan 2017 14:29:12 +1100
Subject: [PATCH] smc: merge fix for "mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/smc/af_smc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 4875e65f0c4a..a48260f9ebb7 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -99,7 +99,7 @@ struct proto smc_proto = {
 	.unhash		= smc_unhash_sk,
 	.obj_size	= sizeof(struct smc_sock),
 	.h.smc_hash	= &smc_v4_hashinfo,
-	.slab_flags	= SLAB_DESTROY_BY_RCU,
+	.slab_flags	= SLAB_TYPESAFE_BY_RCU,
 };
 EXPORT_SYMBOL_GPL(smc_proto);
 
-- 
2.10.2

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2016-05-02  4:37 Stephen Rothwell
  2016-05-02 11:06 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2016-05-02  4:37 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel, Christoph Hellwig

Hi Paul,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

arch/x86/kvm/vmx.c: In function 'vmx_init':
arch/x86/kvm/vmx.c:11026:2: error: function '_r_a_p__v' is initialized like a variable
  rcu_assign_pointer(crash_vmclear_loaded_vmcss,
  ^
In file included from include/linux/rbtree.h:34:0,
                 from include/linux/mm_types.h:9,
                 from arch/x86/kvm/irq.h:25,
                 from arch/x86/kvm/vmx.c:19:
include/linux/rcupdate.h:657:45: warning: the comparison will always evaluate as 'false' for the address of '_r_a_p__v' will never be NULL [-Waddress]
  if (__builtin_constant_p(v) && (_r_a_p__v) == NULL) \
                                             ^
arch/x86/kvm/vmx.c:11026:2: note: in expansion of macro 'rcu_assign_pointer'
  rcu_assign_pointer(crash_vmclear_loaded_vmcss,
  ^
include/linux/rcupdate.h:655:12: error: nested function '_r_a_p__v' declared but never defined  
  typeof(v) _r_a_p__v = (v); \
            ^
arch/x86/kvm/vmx.c:11026:2: note: in expansion of macro 'rcu_assign_pointer'
  rcu_assign_pointer(crash_vmclear_loaded_vmcss,
  ^

Caused by commit

  16d7afcaa530 ("rcu: No ordering for rcu_assign_pointer() of NULL")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2016-02-01  2:55 Stephen Rothwell
  2016-02-01  9:53 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2016-02-01  2:55 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel

Hi Paul,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from /home/sfr/next/next/include/linux/spinlock_types.h:18:0,
                 from /home/sfr/next/next/include/linux/spinlock.h:81,
                 from /home/sfr/next/next/kernel/rcu/tree.c:33:
/home/sfr/next/next/kernel/rcu/tree.c: In function 'rcu_init_one':
/home/sfr/next/next/include/linux/lockdep.h:299:27: error: 'struct rt_mutex' has no member named 'dep_map'
   lockdep_init_map(&(lock)->dep_map, name, key, 0)
                           ^
/home/sfr/next/next/kernel/rcu/tree.c:4572:4: note: in expansion of macro 'lockdep_set_class_and_name'
    lockdep_set_class_and_name(&rnp->exp_funnel_mutex,
    ^

Caused by commit

  725b7f3805c6 ("rcu: Convert expedited grace-period funnel lock to rt_mutex")

I have used the rcu tree from next-20160129 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2016-01-07  8:57 Stephen Rothwell
  2016-01-07 18:02 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2016-01-07  8:57 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel

Hi Paul,

[I found this a few days ago, but I think I forgot to send the email,
sorry.]

After merging the rcu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

kernel/rcu/rcuperf.o:(.discard+0x0): multiple definition of `__pcpu_unique_srcu_ctl_srcu_array'
kernel/rcu/rcutorture.o:(.discard+0x0): first defined here

Caused by commit

  abcd7ec0808e ("rcutorture: Add RCU grace-period performance tests")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2015-09-01  3:50 Stephen Rothwell
  2015-09-01  7:49 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2015-09-01  3:50 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel, Davidlohr Bueso

Hi Paul,

After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "sched_setscheduler_nocheck" [kernel/locking/locktorture.ko] undefined!
ERROR: "percpu_down_write" [kernel/locking/locktorture.ko] undefined!
ERROR: "percpu_up_write" [kernel/locking/locktorture.ko] undefined!
ERROR: "percpu_down_read" [kernel/locking/locktorture.ko] undefined!
ERROR: "percpu_up_read" [kernel/locking/locktorture.ko] undefined!
ERROR: "__percpu_init_rwsem" [kernel/locking/locktorture.ko] undefined!

Caused by commits

  04be76a9b067 ("locktorture: Support rtmutex torturing")
  40b2996f9b32 ("locktorture: Add torture tests for percpu_rwsem")

and maybe more.

I have used the rcu tree from next-20150831 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2015-07-16  3:14 Stephen Rothwell
  2015-07-16  3:51 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2015-07-16  3:14 UTC (permalink / raw)
  To: Paul E. McKenney, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	Peter Zijlstra
  Cc: linux-next, linux-kernel, Andy Lutomirski

Hi Paul,

After merging the rcu tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

kernel/notifier.c: In function 'notify_die':
kernel/notifier.c:547:2: error: implicit declaration of function 'rcu_lockdep_assert' [-Werror=implicit-function-declaration]
  rcu_lockdep_assert(rcu_is_watching(),
  ^

Caused by commit

  02300fdb3e5f ("rcu: Rename rcu_lockdep_assert() to RCU_LOCKDEP_WARN()")

interacting with commit

  e727c7d7a11e ("notifiers, RCU: Assert that RCU is watching in notify_die()")

[ and I also noted
  0333a209cbf6 ("x86/irq, context_tracking: Document how IRQ context tracking works and add an RCU assertion")
]

from the tip tree.

I added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 16 Jul 2015 13:08:50 +1000
Subject: [PATCH] rcu: merge fix for Rename rcu_lockdep_assert() to RCU_LOCKDEP_WARN()

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/x86/kernel/irq.c | 2 +-
 kernel/notifier.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 30dbf35bc90b..f9cd81825187 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -234,7 +234,7 @@ __visible unsigned int __irq_entry do_IRQ(struct pt_regs *regs)
 	entering_irq();
 
 	/* entering_irq() tells RCU that we're not quiescent.  Check it. */
-	rcu_lockdep_assert(rcu_is_watching(), "IRQ failed to wake up RCU");
+	RCU_LOCKDEP_WARN(!rcu_is_watching(), "IRQ failed to wake up RCU");
 
 	irq = __this_cpu_read(vector_irq[vector]);
 
diff --git a/kernel/notifier.c b/kernel/notifier.c
index 980e4330fb59..fd2c9acbcc19 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -544,7 +544,7 @@ int notrace notify_die(enum die_val val, const char *str,
 		.signr	= sig,
 
 	};
-	rcu_lockdep_assert(rcu_is_watching(),
+	RCU_LOCKDEP_WARN(!rcu_is_watching(),
 			   "notify_die called but RCU thinks we're quiescent");
 	return atomic_notifier_call_chain(&die_chain, val, &args);
 }
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply related	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2015-04-13 10:39 Stephen Rothwell
  2015-04-13 11:06 ` Borislav Petkov
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2015-04-13 10:39 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel, Borislav Petkov

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Hi Paul,

After merging the rcu tree, today's linux-next build (powerpc allnoconfig)
failed like this:

init/main.c: In function 'rest_init':
init/main.c:387:2: error: implicit declaration of function 'smpboot_thread_init' [-Werror=implicit-function-declaration]
  smpboot_thread_init();
  ^

Caused by commit c55f6e1f6f69 ("cpu: Defer smpboot kthread unparking
until CPU known to scheduler").  The declaration in include/linux/cpu.h
is protected by CONFIG_SMP, its use is not.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2015-02-27  2:18 Stephen Rothwell
  2015-02-27  5:59 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2015-02-27  2:18 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

Hi Paul,

After merging the rcu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

arch/x86/xen/smp.c: In function 'xen_cpu_up':
arch/x86/xen/smp.c:460:6: error: 'err' undeclared (first use in this function)
  if (err)
      ^

Caused by commit b92c23b083d6 ("x86: Use common
outgoing-CPU-notification code").

I have used the rcu tree from next-20150226 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2014-12-26  7:51 Stephen Rothwell
  2014-12-26 16:54 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2014-12-26  7:51 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel, Pranith Kumar

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

Hi Paul,

After merging the rcu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from arch/powerpc/include/asm/kvm_ppc.h:30:0,
                 from arch/powerpc/kernel/setup_64.c:68:
include/linux/kvm_host.h:366:21: error: field 'srcu' has incomplete type
  struct srcu_struct srcu;
                     ^
include/linux/kvm_host.h:367:21: error: field 'irq_srcu' has incomplete type
  struct srcu_struct irq_srcu;
                     ^

Caused by commit f01a973369dd ("srcu: Isolate srcu sections using
CONFIG_SRCU").  Please stop readding that commit after until it is
fixed :-(

I have reverted that commit for today (again :-().

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2014-12-12  6:12 Stephen Rothwell
  2014-12-12 17:23 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2014-12-12  6:12 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel, Pranith Kumar

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

Hi Paul,

After merging the rcu tree, today's linux-next build (powerpc64
allnoconfig) failed like this:

In file included from arch/powerpc/include/asm/kvm_ppc.h:30:0,
                 from arch/powerpc/kernel/setup_64.c:68:
include/linux/kvm_host.h:366:21: error: field 'srcu' has incomplete type
  struct srcu_struct srcu;
                     ^
include/linux/kvm_host.h:367:21: error: field 'irq_srcu' has incomplete type
  struct srcu_struct irq_srcu;
                     ^

I am sure we have seen this before :-(

Caused by commit 31a78b1b598a ("srcu: Isolate srcu sections using
CONFIG_SRCU") as it was before (I do wonder why this came back).

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2014-12-10  8:09 Stephen Rothwell
  2014-12-10 15:03 ` Pranith Kumar
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2014-12-10  8:09 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel, Pranith Kumar

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

Hi Paul,

After merging the rcu tree, today's linux-next build (powerpc64
allnoconfig) failed like this:

In file included from arch/powerpc/include/asm/kvm_ppc.h:30:0,
                 from arch/powerpc/kernel/setup_64.c:68:
include/linux/kvm_host.h:366:21: error: field 'srcu' has incomplete type
  struct srcu_struct srcu;
                     ^
include/linux/kvm_host.h:367:21: error: field 'irq_srcu' has incomplete type
  struct srcu_struct irq_srcu;
                     ^

Presumably caused by commit 6e8ef258b669 ("srcu: Isolate srcu sections
using CONFIG_SRCU").

I have reverted that commit again for today - more work required ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2014-12-09 11:42 Stephen Rothwell
  2014-12-09 14:07 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2014-12-09 11:42 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: linux-next, linux-kernel, Pranith Kumar

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

Hi Paul,

After merging the rcu tree, today's linux-next build (powerpc
allnoconfig) failed like this:

include/linux/notifier.h:51:4: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from include/linux/memory_hotplug.h:6:0,
                 from include/linux/mmzone.h:790,
                 from include/linux/gfp.h:5,
                 from arch/powerpc/mm/pgtable.c:25:
include/linux/notifier.h:51:4: error: 'struct notifier_block' declared inside parameter list [-Werror]
    unsigned long action, void *data);
    ^

And many more (most just warnings ...).

Presumably caused by commit 44dec3761b63 ("srcu: Isolate srcu sections
using CONFIG_SRCU") and reverting that commit makes the messages go
away, so I have done that for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2012-04-16  4:11 Stephen Rothwell
  2012-04-16 17:02 ` Paul E. McKenney
  0 siblings, 1 reply; 152+ messages in thread
From: Stephen Rothwell @ 2012-04-16  4:11 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: linux-next, linux-kernel, Linus Torvalds, Paul E. McKenney

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Hi Paul,

After merging the rcu tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/binfmt_misc.c: In function 'create_entry':
fs/binfmt_misc.c:314:2: error: implicit declaration of function '_copy_from_user' [-Werror=implicit-function-declaration]

Caused by commit d17faaa53e2e ("fs: Silence bogus copy_to_user() build
errors").  _copy_from_user() appears to only exist for the x86 and tile
architectures ...

I have used the rcu tree from next-20120413 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 152+ messages in thread
* linux-next: build failure after merge of the rcu tree
@ 2010-09-17  2:42 Stephen Rothwell
  2010-09-17  4:39 ` David Miller
  2010-09-17 23:17 ` Paul E. McKenney
  0 siblings, 2 replies; 152+ messages in thread
From: Stephen Rothwell @ 2010-09-17  2:42 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: linux-next, linux-kernel, Eric Dumazet, David Miller, netdev

Hi Paul,

After merging the rcu tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/core/dev.c: In function 'netdev_run_todo':
net/core/dev.c:5294: error: dereferencing pointer to incomplete type
net/core/dev.c:5294: warning: type defaults to 'int' in declaration of '_________p1'
net/core/dev.c:5294: error: dereferencing pointer to incomplete type
net/core/dev.c:5294: warning: type defaults to 'int' in declaration of 'type name'
net/core/dev.c:5294: error: dereferencing pointer to incomplete type
net/core/dev.c:5294: warning: type defaults to 'int' in declaration of 'type name'
net/core/dev.c:5294: warning: comparison of distinct pointer types lacks a cast
net/core/dev.c:5294: error: dereferencing pointer to incomplete type
net/core/dev.c:5294: warning: type defaults to 'int' in declaration of 'type name'

Caused by commit ca5ecddfa8fcbd948c95530e7e817cee9fb43a3d ("rcu: define
__rcu address space modifier for sparse") interacting with commit
95ae6b228f814fc0528d0506ee9f18ac333d6851 ("ipv4: ip_ptr cleanups") from
the net tree.

rcu_dereference_raw() now needs to know the type of the object its
argument points to.  I added the following merge fix (which could be
applied to the net tree anyway).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 17 Sep 2010 12:36:36 +1000
Subject: [PATCH] net: include inetdevice.h for rcu_dereference_raw api change

rcu_dereference_raw() now needs to know the type of its argument.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/core/dev.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index c6d837a..cadd28c 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -129,6 +129,7 @@
 #include <linux/random.h>
 #include <trace/events/napi.h>
 #include <linux/pci.h>
+#include <linux/inetdevice.h>
 
 #include "net-sysfs.h"
 
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply related	[flat|nested] 152+ messages in thread

end of thread, other threads:[~2024-01-24 14:20 UTC | newest]

Thread overview: 152+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-04  8:25 linux-next: build failure after merge of the rcu tree Stephen Rothwell
2020-12-04 19:20 ` Paul E. McKenney
2020-12-06 21:39   ` Stephen Rothwell
2020-12-07  4:48     ` Paul E. McKenney
2020-12-07  8:59       ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2024-01-24  4:17 Stephen Rothwell
2024-01-24  9:49 ` Jiri Wiesner
2024-01-24 12:12   ` Paul E. McKenney
2024-01-24 13:31     ` Jiri Wiesner
2024-01-24 14:20       ` Paul E. McKenney
2023-07-27  4:19 Stephen Rothwell
2023-07-27 14:08 ` Paul E. McKenney
2023-05-19  0:59 Stephen Rothwell
2023-05-19  2:12 ` Paul E. McKenney
2023-05-22  1:45   ` Stephen Rothwell
2023-05-22 14:57     ` Paul E. McKenney
2023-03-14  1:29 Stephen Rothwell
2023-03-14  4:43 ` Paul E. McKenney
2022-10-17 23:26 Stephen Rothwell
2022-10-18 10:43 ` Frederic Weisbecker
2022-10-18 14:57   ` Paul E. McKenney
2022-04-19  2:36 Stephen Rothwell
2022-04-19  3:31 ` Paul E. McKenney
2021-05-03  0:11 Stephen Rothwell
2021-05-03 16:25 ` Paul E. McKenney
2021-04-22  4:10 Stephen Rothwell
2021-04-22 16:36 ` Paul E. McKenney
2021-03-17  5:36 Stephen Rothwell
2021-03-17 14:23 ` Paul E. McKenney
2021-01-04  0:37 Stephen Rothwell
2021-01-04 12:56 ` Frederic Weisbecker
2020-09-17  5:19 Stephen Rothwell
2020-09-17 22:01 ` Paul E. McKenney
2020-09-18  0:00   ` Stephen Rothwell
2020-09-08  5:38 Stephen Rothwell
2020-09-08 13:54 ` Paul E. McKenney
2020-08-18  1:43 Stephen Rothwell
2020-08-18 14:08 ` Paul E. McKenney
2020-06-25  2:57 Stephen Rothwell
2020-06-25  3:45 ` Paul E. McKenney
2020-05-28  9:05 Stephen Rothwell
2020-05-28 16:33 ` Paul E. McKenney
2020-05-28 21:03   ` Paul E. McKenney
2020-04-05  1:49 Stephen Rothwell
2020-04-05  3:10 ` Paul E. McKenney
2020-01-17  3:07 Stephen Rothwell
2019-12-12  2:45 Stephen Rothwell
2019-12-12  4:07 ` Paul E. McKenney
2019-12-12  4:26   ` Stephen Rothwell
2019-12-12  4:41     ` Paul E. McKenney
2020-01-17  3:09 ` Stephen Rothwell
2019-08-13  7:57 Stephen Rothwell
2019-08-13 15:31 ` Paul E. McKenney
2019-08-12  6:12 Stephen Rothwell
2019-08-12 16:19 ` Paul E. McKenney
2019-08-13  5:25   ` Stephen Rothwell
2019-08-13 14:38     ` Paul E. McKenney
2017-09-04  4:50 Stephen Rothwell
2017-09-04 16:39 ` Paul E. McKenney
2017-08-28  4:25 Stephen Rothwell
2017-08-28 17:50 ` Paul E. McKenney
2017-08-11  4:43 Stephen Rothwell
2017-08-11  4:54 ` Paul E. McKenney
2017-08-11  9:14   ` Peter Zijlstra
2017-08-11 14:39     ` Paul E. McKenney
2017-08-11 14:45       ` Peter Zijlstra
2017-08-11 14:41     ` Peter Zijlstra
2017-08-11 20:12       ` Paul E. McKenney
2017-05-29  6:02 Stephen Rothwell
2017-05-29 21:15 ` Paul E. McKenney
2017-05-30  1:40   ` Stephen Rothwell
2017-05-30  1:54     ` Joe Perches
2017-05-30  2:14       ` Paul E. McKenney
2017-05-30  2:20         ` Joe Perches
2017-05-30  3:13           ` Stephen Rothwell
2017-05-30  4:10   ` Michael Ellerman
2017-06-02 17:51     ` Paul E. McKenney
2017-04-20  5:36 Stephen Rothwell
2017-04-20 14:23 ` Paul E. McKenney
2017-04-19  3:50 Stephen Rothwell
2017-04-19  4:06 ` Paul E. McKenney
2017-04-19  5:45   ` Stephen Rothwell
2017-03-08  1:16 Stephen Rothwell
2017-03-08 10:13 ` Daniel Vetter
2017-03-08 17:40   ` Paul E. McKenney
2017-01-19  3:34 Stephen Rothwell
2017-01-19 21:54 ` Paul McKenney
2017-02-13  2:21   ` Stephen Rothwell
2017-02-13  4:37     ` Paul E. McKenney
2017-02-13  6:43       ` Stephen Rothwell
2017-03-08  1:16         ` Stephen Rothwell
2017-03-08  1:37           ` Paul E. McKenney
2017-03-08 18:05           ` Paul E. McKenney
2016-05-02  4:37 Stephen Rothwell
2016-05-02 11:06 ` Paul E. McKenney
2016-02-01  2:55 Stephen Rothwell
2016-02-01  9:53 ` Paul E. McKenney
2016-01-07  8:57 Stephen Rothwell
2016-01-07 18:02 ` Paul E. McKenney
2016-01-07 20:19   ` Stephen Rothwell
2016-01-07 20:52     ` Paul E. McKenney
2016-01-08  1:37       ` Boqun Feng
2016-01-08  3:41         ` Paul E. McKenney
2016-01-08  4:08           ` Stephen Rothwell
2016-01-08  4:48             ` Paul E. McKenney
2016-01-08  4:54               ` Boqun Feng
2016-01-08 15:53                 ` Paul E. McKenney
2016-01-08 15:57                   ` Tejun Heo
2016-01-08 16:18                     ` Paul E. McKenney
2016-01-08 15:58                   ` Boqun Feng
2016-01-08  4:10         ` Stephen Rothwell
2015-09-01  3:50 Stephen Rothwell
2015-09-01  7:49 ` Paul E. McKenney
2015-09-02  3:58   ` Stephen Rothwell
2015-09-02  5:26     ` Paul E. McKenney
2015-09-02  6:40       ` Davidlohr Bueso
2015-09-02  7:14         ` Paul E. McKenney
2015-09-02  7:29           ` Ingo Molnar
2015-09-02  8:34             ` Paul E. McKenney
2015-07-16  3:14 Stephen Rothwell
2015-07-16  3:51 ` Paul E. McKenney
2015-07-16  5:50   ` Stephen Rothwell
2015-07-17 11:40   ` Ingo Molnar
2015-07-17 17:35     ` Paul E. McKenney
2015-07-17 18:53       ` Paul E. McKenney
2015-07-17 19:51         ` Ingo Molnar
2015-07-17 21:33           ` Paul E. McKenney
2015-07-18  2:40             ` Ingo Molnar
2015-04-13 10:39 Stephen Rothwell
2015-04-13 11:06 ` Borislav Petkov
2015-04-13 11:34   ` Ingo Molnar
2015-04-13 12:40     ` Paul E. McKenney
2015-02-27  2:18 Stephen Rothwell
2015-02-27  5:59 ` Paul E. McKenney
2014-12-26  7:51 Stephen Rothwell
2014-12-26 16:54 ` Paul E. McKenney
2014-12-27 16:24   ` Pranith Kumar
2014-12-27 17:20     ` Pranith Kumar
2014-12-31  1:45       ` Paul E. McKenney
2014-12-12  6:12 Stephen Rothwell
2014-12-12 17:23 ` Paul E. McKenney
2014-12-10  8:09 Stephen Rothwell
2014-12-10 15:03 ` Pranith Kumar
2014-12-10 15:18   ` Paul E. McKenney
2014-12-09 11:42 Stephen Rothwell
2014-12-09 14:07 ` Paul E. McKenney
2012-04-16  4:11 Stephen Rothwell
2012-04-16 17:02 ` Paul E. McKenney
2010-09-17  2:42 Stephen Rothwell
2010-09-17  4:39 ` David Miller
2010-09-17  5:34   ` Eric Dumazet
2010-09-17 23:17 ` Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).