From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Sven Van Asbroeck <thesven73@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
David S Miller <davem@davemloft.net>, Marek Vasut <marex@denx.de>,
Tristram Ha <Tristram.Ha@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v1] net: dsa: ksz8795: use correct number of physical ports
Date: Sat, 5 Dec 2020 00:43:21 +0100 [thread overview]
Message-ID: <20201204234321.GJ2400258@lunn.ch> (raw)
In-Reply-To: <20201204152456.247769b1@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
On Fri, Dec 04, 2020 at 03:24:56PM -0800, Jakub Kicinski wrote:
> On Thu, 3 Dec 2020 16:46:45 -0500 Sven Van Asbroeck wrote:
> > From: Sven Van Asbroeck <thesven73@gmail.com>
> >
> > The ksz8795 has five physical ports, but the driver assumes
> > it has only four. This prevents the driver from working correctly.
> >
> > Fix by indicating the correct number of physical ports.
> >
> > Fixes: e66f840c08a23 ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver")
> > Tested-by: Sven Van Asbroeck <thesven73@gmail.com> # ksz8795
> > Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com>
>
> All the port counts here are -1 compared to datasheets, so I'm assuming
> the are not supposed to include the host facing port or something?
>
> Can you describe the exact problem you're trying to solve?
>
> DSA devices are not supposed to have a netdev for the host facing port
> on the switch (sorry for stating the obvious).
Hi Jakub
It is the DSA core layer which takes care of that creating/not
creating netdevs. The switch should declare all the ports it has.
There has been issues with the ksz collection of drivers having
different meanings for port_cnt. There recently was some changes in
this area, maybe it broke something?
Andrew
next prev parent reply other threads:[~2020-12-04 23:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 21:46 [PATCH net v1] net: dsa: ksz8795: use correct number of physical ports Sven Van Asbroeck
2020-12-03 21:55 ` Florian Fainelli
2020-12-04 23:24 ` Jakub Kicinski
2020-12-04 23:43 ` Andrew Lunn [this message]
2020-12-05 14:35 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204234321.GJ2400258@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=thesven73@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).