* [PATCH] phy: mediatek: statify mtk_hdmi_phy_driver
@ 2020-12-05 9:11 Vinod Koul
2020-12-05 16:21 ` Chun-Kuang Hu
0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2020-12-05 9:11 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Vinod Koul, Chun-Kuang Hu, Philipp Zabel, Chunfeng Yun,
Matthias Brugger, dri-devel, linux-arm-kernel, linux-mediatek,
linux-kernel
mtk_hdmi_phy_driver is not declared as static, so statify it.
drivers/phy/mediatek/phy-mtk-hdmi.c:204:24: warning: symbol 'mtk_hdmi_phy_driver' was not declared. Should it be static?
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/phy/mediatek/phy-mtk-hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/phy-mtk-hdmi.c
index 47c029d4b270..c5c61f5a9ea0 100644
--- a/drivers/phy/mediatek/phy-mtk-hdmi.c
+++ b/drivers/phy/mediatek/phy-mtk-hdmi.c
@@ -201,7 +201,7 @@ static const struct of_device_id mtk_hdmi_phy_match[] = {
{},
};
-struct platform_driver mtk_hdmi_phy_driver = {
+static struct platform_driver mtk_hdmi_phy_driver = {
.probe = mtk_hdmi_phy_probe,
.driver = {
.name = "mediatek-hdmi-phy",
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: mediatek: statify mtk_hdmi_phy_driver
2020-12-05 9:11 [PATCH] phy: mediatek: statify mtk_hdmi_phy_driver Vinod Koul
@ 2020-12-05 16:21 ` Chun-Kuang Hu
0 siblings, 0 replies; 2+ messages in thread
From: Chun-Kuang Hu @ 2020-12-05 16:21 UTC (permalink / raw)
To: Vinod Koul
Cc: Kishon Vijay Abraham I, Chun-Kuang Hu, Philipp Zabel,
Chunfeng Yun, Matthias Brugger, DRI Development, Linux ARM,
moderated list:ARM/Mediatek SoC support, linux-kernel
Hi, Vinod:
Vinod Koul <vkoul@kernel.org> 於 2020年12月5日 週六 下午5:11寫道：
>
> mtk_hdmi_phy_driver is not declared as static, so statify it.
>
> drivers/phy/mediatek/phy-mtk-hdmi.c:204:24: warning: symbol 'mtk_hdmi_phy_driver' was not declared. Should it be static?
>
Acked-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/phy/mediatek/phy-mtk-hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/phy-mtk-hdmi.c
> index 47c029d4b270..c5c61f5a9ea0 100644
> --- a/drivers/phy/mediatek/phy-mtk-hdmi.c
> +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c
> @@ -201,7 +201,7 @@ static const struct of_device_id mtk_hdmi_phy_match[] = {
> {},
> };
>
> -struct platform_driver mtk_hdmi_phy_driver = {
> +static struct platform_driver mtk_hdmi_phy_driver = {
> .probe = mtk_hdmi_phy_probe,
> .driver = {
> .name = "mediatek-hdmi-phy",
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-05 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-05 9:11 [PATCH] phy: mediatek: statify mtk_hdmi_phy_driver Vinod Koul
2020-12-05 16:21 ` Chun-Kuang Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).