From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D0B3C433FE for ; Sat, 5 Dec 2020 22:35:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04729222F9 for ; Sat, 5 Dec 2020 22:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726447AbgLEWfV (ORCPT ); Sat, 5 Dec 2020 17:35:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:60274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725270AbgLEWfU (ORCPT ); Sat, 5 Dec 2020 17:35:20 -0500 Date: Sat, 5 Dec 2020 14:34:39 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607207680; bh=cMgJ5FN4yoxLMb7kikcjkva9GbT8haiAgzoG3+ezn8Y=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=fnGchznoa4sX0dD4vrAJT80RD++JmFEZjOPbDmnN97fen+bfpd9qsLcwwCPZrWp59 YplD++KkSVxZMVa4tOpWRDKf6gXt4dP2l80EX4/hPlb0uH43r1YEKL3p948f/ukIl9 2ibnBK7GXMozDGK9YQsnGIfxTyvXyxULRG/uJb1yH+YhuF4/8k89XKxPzoG53LFCrf YQMWarxaMqOYwVRkvulI7O9iFyuwyJfrQLPiWAmgH5QwkzwLSYipaYs7E6iPEU5dhd 4UROZLNdpkLRaa7jPSEFVk9bEIBjXhEjmrywx5n0PjVlyuN4YT57dompUp2hWWpbU5 VIIFJ3ydApdmw== From: Jakub Kicinski To: Zhang Changzhong Cc: "David S. Miller" , Oleksandr Mazur , Serhiy Pshyk , Vadym Kochan , Volodymyr Mytnyk , , Subject: Re: [PATCH net] net: marvell: prestera: Fix error return code in prestera_port_create() Message-ID: <20201205143439.3b3eb07f@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <1607071782-34006-1-git-send-email-zhangchangzhong@huawei.com> References: <1607071782-34006-1-git-send-email-zhangchangzhong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Dec 2020 16:49:42 +0800 Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Applied, thanks!