From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7430C4361A for ; Sat, 5 Dec 2020 20:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76BB323110 for ; Sat, 5 Dec 2020 20:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726993AbgLEU63 (ORCPT ); Sat, 5 Dec 2020 15:58:29 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:38512 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725270AbgLEU62 (ORCPT ); Sat, 5 Dec 2020 15:58:28 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7EB0C1C0B7C; Sat, 5 Dec 2020 21:57:44 +0100 (CET) Date: Sat, 5 Dec 2020 21:57:44 +0100 From: Pavel Machek To: Sven Van Asbroeck Cc: "H. Nikolaus Schaller" , Linus Walleij , Mark Brown , kernel list , Laurent Pinchart , Discussions about the Letux Kernel Subject: Re: [BUG] SPI broken for SPI based panel drivers Message-ID: <20201205205744.GD8578@amd> References: <2D7916FA-678F-4236-B478-C953CADF2FFA@goldelico.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="76DTJ5CE0DCVQemd" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --76DTJ5CE0DCVQemd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2020-11-30 15:13:02, Sven Van Asbroeck wrote: > Hi Nikolaus, thank you for reaching out ! >=20 > On Mon, Nov 30, 2020 at 2:06 PM H. Nikolaus Schaller = wrote: > > > > But reverting your patch brings back the display. So it appears as if i= t does not > > fix a breakage, rather breaks a previously working setup. >=20 > The patch in question fixes an important breakage: before the patch, lite= rally > hundreds of SPI drivers no longer worked - only if the SPI bus master > driver was using gpio descriptors. >=20 > We knew that there was a chance that our fix would break something else. > But hopefully "it fixes more than it breaks" If the patch causes regression it will ultimately need to be reverted... no matter how much it fixes. Pavel --=20 http://www.livejournal.com/~pavelmachek --76DTJ5CE0DCVQemd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl/L9EgACgkQMOfwapXb+vL2fwCgo5zigUkxc/oCVfM0ejb5HbIG OcYAoKaDlIR7tPY6jkLHFM+Dr10IbzE7 =VO34 -----END PGP SIGNATURE----- --76DTJ5CE0DCVQemd--